From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E6E3C4332F for ; Sat, 24 Dec 2022 15:12:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lTfcDRQ1uVE7wNvzUxQi1Zut1FZuripgZBn0eSHTNr8=; b=GbFN12tVqNjLmO ScmIGXQh/5JcmxyoEHsXzLmb4Ptu7lS+NuOorYLJlEt3wZ0zGU9pF7t5RASvGyaKrRr68MDEH7wkr ASMP0rcFg85+cfBImrzEvPus57cbb3+eUp3C12Ehw7NUOYQZbU6RZosWjWiGOTtQpMOPrG8vRadQx Zpip3PnrDfqXf4uNGZRlyknmnvIy9z9OYeudFWuZws4Bpzt1MXd1oXktrFqufp2wXrutNMR6i27yc ia1i6Xo99NBdpkMykBzGjt/yTgAkBVSQfobSjM3QBqA5P9eLvW2AaJNke+diHHUTH4y82joGxhCd9 zzzDtF87PEQVGH5+8+CQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p96Bs-000xYm-N2; Sat, 24 Dec 2022 15:12:01 +0000 Received: from mail-yb1-xb2f.google.com ([2607:f8b0:4864:20::b2f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p90BY-00GXpl-Ch for linux-riscv@lists.infradead.org; Sat, 24 Dec 2022 08:47:18 +0000 Received: by mail-yb1-xb2f.google.com with SMTP id 192so7368771ybt.6 for ; Sat, 24 Dec 2022 00:47:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ojdIoHtA8qRrSJH0IqbM6/hdw/qvVnURVzM4Y/Ji5XY=; b=ClboHjVO8qHK6/LsGtS7Gq+265uWJvU4yUhzopkrXmsYRDcLEckfvufGvne6ejswi8 drCgwYGAC75kEXoW9bD9MYbqMrKC4FR67lVsL8a4wFk0PhGMD9xJNrifpNjjx1hNTC25 Jw/9gk1bL2NqeJm/jeZAyjowobiMujFb6RNAluoLZMaDCc2gfb+SqhpC5bXDGVyiI50+ a7nVTOOfXphSj8oXFRHTFPw7Mo8Azo95+HE3q+s9EaK58ZjZP9J9IIK4TbNluE3uxwvw E1zj8rMgwbAFCcnT9J+IposLXMIB+5HY+tdsjA9vyJE//XPL+7JtoFY9LeYEudfzeFo5 HsKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ojdIoHtA8qRrSJH0IqbM6/hdw/qvVnURVzM4Y/Ji5XY=; b=jDTqk9EazENHN/XrPa1Rb2AuheiaNIH+6HVtjVz4tDXmj4obmhbHWVpsnOvEmbQ8sz zH7U/ZkmdUFEyC8+bMHPJwZqY0TQE6Xuf7ycPJi4Kl8hqvJVeY4QPazxixrY77YrAuZr +CQSthnIzoNMMatBG6iFt0Z8nfOsvjggoGuDL81nSD3b+m10o/5iLg+GmsYT/1Rt+lbt 94aub3H+NL6+hfzJTvVSR84Yf/P9iuxMNAy6iW7fSQwrlgNoI4rYfCc2lAHrj+Yvsl5G J7wVigrOUTG9yCA9GSolDFj4Vor7o2+E5GWydcy+4+oKpv914IIOgsKw744PN9grHVh1 1flw== X-Gm-Message-State: AFqh2kpOev/SevEqcg9D4Gbcq9ClTejw00rsSxUhx5gapwq7M4fFiPKw m+pVZSuJm5Y6pUvad38DqI1zh+OzkQr5lxG03MQ= X-Google-Smtp-Source: AMrXdXshUWllo895j6Lz02ae/aESMYuatKqF66HHlEvP2aJ8hnZ8iGOJpgIQ7rpFcfUL68G2rPFTg4codEdUK762Mxk= X-Received: by 2002:a25:aaaa:0:b0:737:75f9:e0e6 with SMTP id t39-20020a25aaaa000000b0073775f9e0e6mr1516555ybi.535.1671871633633; Sat, 24 Dec 2022 00:47:13 -0800 (PST) MIME-Version: 1.0 References: <20220829205219.283543-1-geomatsi@gmail.com> In-Reply-To: From: "Lad, Prabhakar" Date: Sat, 24 Dec 2022 08:46:47 +0000 Message-ID: Subject: Re: [RFC PATCH 1/1] riscv: mm: notify remote harts about mmu cache updates To: Sergey Matyukevich Cc: linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, Anup Patel , Atish Patra , Albert Ou , Palmer Dabbelt , Paul Walmsley , Guo Ren , Alexandre Ghiti , Heiko Stuebner , Sergey Matyukevich , Geert Uytterhoeven , Conor Dooley X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221224_004716_487452_8FA1866F X-CRM114-Status: GOOD ( 45.33 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Sergey, On Fri, Dec 23, 2022 at 5:22 PM Sergey Matyukevich wrote: > > Hi Prabhakar, > > On Fri, Dec 23, 2022 at 01:02:10PM +0000, Lad, Prabhakar wrote: > > Hi Sergey, > > > > On Thu, Dec 22, 2022 at 10:20 PM Sergey Matyukevich wrote: > > > > > > On Thu, Dec 22, 2022 at 09:26:07PM +0000, Lad, Prabhakar wrote: > > > > Hi Sergey, > > > > > > > > On Thu, Dec 22, 2022 at 9:14 PM Sergey Matyukevich wrote: > > > > > > > > > > Hi Prabhakar, > > > > > > > > > > > > > > From: Sergey Matyukevich > > > > > > > > > > > > > > > > > > Current implementation of update_mmu_cache function performs local TLB > > > > > > > > > flush. It does not take into account ASID information. Besides, it does > > > > > > > > > not take into account other harts currently running the same mm context > > > > > > > > > or possible migration of the running context to other harts. Meanwhile > > > > > > > > > TLB flush is not performed for every context switch if ASID support > > > > > > > > > is enabled. > > > > > > > > > > > > > > > > > > Patch [1] proposed to add ASID support to update_mmu_cache to avoid > > > > > > > > > flushing local TLB entirely. This patch takes into account other > > > > > > > > > harts currently running the same mm context as well as possible > > > > > > > > > migration of this context to other harts. > > > > > > > > > > > > > > > > > > For this purpose the approach from flush_icache_mm is reused. Remote > > > > > > > > > harts currently running the same mm context are informed via SBI calls > > > > > > > > > that they need to flush their local TLBs. All the other harts are marked > > > > > > > > > as needing a deferred TLB flush when this mm context runs on them. > > > > > > > > > > > > > > > > > > [1] https://lore.kernel.org/linux-riscv/20220821013926.8968-1-tjytimi@163.com/ > > > > > > > > > > > > > > > > > > Signed-off-by: Sergey Matyukevich > > > > > > > > > --- > > > > > > > > > arch/riscv/include/asm/mmu.h | 2 ++ > > > > > > > > > arch/riscv/include/asm/pgtable.h | 2 +- > > > > > > > > > arch/riscv/include/asm/tlbflush.h | 18 ++++++++++++++++++ > > > > > > > > > arch/riscv/mm/context.c | 10 ++++++++++ > > > > > > > > > arch/riscv/mm/tlbflush.c | 28 +++++++++++----------------- > > > > > > > > > 5 files changed, 42 insertions(+), 18 deletions(-) > > > > > > > > > > > > > > > > > > > > > > > [ 133.008752] Hardware name: Renesas SMARC EVK based on r9a07g043f01 (DT) > > > > > > > > [ 133.015338] Call Trace: > > > > > > > > [ 133.017778] [] dump_backtrace+0x1c/0x24 > > > > > > > > [ 133.023174] [] show_stack+0x2c/0x38 > > > > > > > > [ 133.028214] [] dump_stack_lvl+0x3c/0x54 > > > > > > > > [ 133.033597] [] dump_stack+0x14/0x1c > > > > > > > > [ 133.038633] [] panic+0x102/0x29a > > > > > > > > [ 133.043409] [] do_exit+0x704/0x70a > > > > > > > > [ 133.048362] [] do_group_exit+0x24/0x70 > > > > > > > > [ 133.053659] [] get_signal+0x68a/0x6dc > > > > > > > > [ 133.058874] [] do_work_pending+0xd6/0x44e > > > > > > > > [ 133.064427] [] resume_userspace_slow+0x8/0xa > > > > > > > > [ 133.070249] ---[ end Kernel panic - not syncing: Attempted to kill > > > > > > > > init! exitcode=0x0000000b ]--- > > > > > > > > > > > > > > > > If I revert this patch [0] bonnie++ works as expected. > > > > > > > > > > > > > > > > Any pointers on what could be the issue here? > > > > > > > > > > > > > > > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/palmer/linux.git/commit/?h=for-next&id=4bd1d80efb5af640f99157f39b50fb11326ce641 > > > > > > > > > > > > > > > > Cheers, > > > > > > > > Prabhakar > > > > > > > > > > > > > > Good catch. Thanks for reporting ! Discussion around the issue and > > > > > > > possible ways to fix it can be found in the following email thread: > > > > > > > > > > > > > > https://lore.kernel.org/linux-riscv/20221111075902.798571-1-guoren@kernel.org/ > > > > > > > > > > > > > > Could you please apply the patch from Guo Ren instead of [0] and check > > > > > > > if you have any issues with your test ? Besides, could you please share > > > > > > > your kernel configuration and the actual bonnie++ params from emmc_t_002.sh script ? > > > > > > > > > > > > > Thanks for the pointer, I'll undo my changes and test Guo's patch. > > > > > > > > > > > > I have pasted the script here [0] and attached config. > > > > > > > > > > > > [0] https://paste.debian.net/hidden/a7a769b5/ > > > > > > > > > > Thanks for the script and config. Could you please also share the > > > > > following information: > > > > > - how many cores your system has > > > > The Renesas RZ/Five SoC has a single Andes AX45MP core. > > > > > > > > > - does your system support ASID > > > > > > > > > With a quick look at [0] It does support ASID, unless there is a way > > > > to disable it. > > > > > > > > [0] http://www.andestech.com/wp-content/uploads/AX45MP-1C-Rev.-5.0.0-Datasheet.pdf > > > > > > So you have a single-core system, but your kernel configuration enables > > > CONFIG_SMP. Additional 'deferred TLB flush' logic is dropped at build > > > time if CONFIG_SMP is disabled. On the other hand, system should not > > > fail that way even if SMP is enabled. > > > > > I enabled CONFIG_SMP while doing some testing of PMA code and indeed > > enabling this config should not introduce a failure. > > > > > Let me double-check if anything can go wrong if cpumasks may have only > > > a single cpu. Another suspect is a change in update_mmu_cache: probably > > > making it asid-specific (and thus more granular) was a bad idea. > > > > > Thanks. > > > > BTW I tested the patch [0] which you pointed out and that fixes the > > issues seen earlier. > > > > [0] https://patchwork.kernel.org/project/linux-riscv/patch/20221111075902.798571-1-guoren@kernel.org/ > > All looks good with cpumasks in the single-core case. So deferred TLB > flush logic is not even executed in your case. So the root cause > should be in update_mmu_cache change. > > May I ask you to repeat the original emmc test on your platform from > for-next (i.e. with [0] and without [1]) with the following partial revert: > > : diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h > : index ec6fb83349ce..92ec2d9d7273 100644 > : --- a/arch/riscv/include/asm/pgtable.h > : +++ b/arch/riscv/include/asm/pgtable.h > : @@ -415,7 +415,7 @@ static inline void update_mmu_cache(struct vm_area_struct *vma, > : * Relying on flush_tlb_fix_spurious_fault would suffice, but > : * the extra traps reduce performance. So, eagerly SFENCE.VMA. > : */ > : - flush_tlb_page(vma, address); > : + local_flush_tlb_page(address); > : } > : > : static inline void update_mmu_cache_pmd(struct vm_area_struct *vma, > I tested your above proposed changes and I am no longer seeing an issue on my platform. Cheers, Prabhakar _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv