From: Alexandre Ghiti <alexandre.ghiti@canonical.com>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: David Abdurachmanov <david.abdurachmanov@gmail.com>,
Support Opensource <Support.Opensource@diasemi.com>,
Lee Jones <lee.jones@linaro.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: mfd: da9063: Add restart notifier implementation
Date: Tue, 5 Oct 2021 15:43:23 +0200 [thread overview]
Message-ID: <CA+zEjCsf6m8cctHNPBxJczg-J9XC-piAcdtNDO71qmtCtDj9gw@mail.gmail.com> (raw)
In-Reply-To: <DB9PR10MB4652294AB444536BF57E320A80AE9@DB9PR10MB4652.EURPRD10.PROD.OUTLOOK.COM>
On Mon, Oct 4, 2021 at 5:11 PM Adam Thomson
<Adam.Thomson.Opensource@diasemi.com> wrote:
>
> On 04 October 2021 13:05, Alexandre Ghiti wrote:
>
> > > > Today I was looking into OpenBSD DA9063 drivers and they might be
> > > > doing what you described for the reset.
> > > >
> > > > dev/fdt/dapmic.c
> > > >
> > > > [..]
> > > > 241 void
> > > > 242 dapmic_reset(void)
> > > > 243 {
> > > > 244 struct dapmic_softc *sc = dapmic_cd.cd_devs[0];
> > > > 245 uint8_t reg;
> > > > 246
> > > > 247 /* Enable tick alarm wakeup with a one second interval. */
> > > > 248 reg = dapmic_reg_read(sc, ALARM_MO);
> > > > 249 reg &= ~ALARM_MO_TICK_TYPE;
> > > > 250 reg |= ALARM_MO_TICK_WAKE;
> > > > 251 dapmic_reg_write(sc, ALARM_MO, reg);
> > > > 252
> > > > 253 /* Enable tick function. */
> > > > 254 reg = dapmic_reg_read(sc, ALARM_Y);
> > > > 255 reg |= ALARM_Y_TICK_ON;
> > > > 256 dapmic_reg_write(sc, ALARM_Y, reg);
> > > > 257
> > > > 258 /* Clear events such that we wake up again. */
> > > > 259 dapmic_reg_write(sc, EVENT_A, dapmic_reg_read(sc, EVENT_A));
> > > > 260 dapmic_reg_write(sc, CONTROL_F, CONTROL_F_SHUTDOWN);
> > > > 261 }
> > > > [..]
> > > >
> > >
> > > Thanks for the pointer! I have just tested this sequence from the
> > > u-boot shell, it resets the board correctly. But then if we try to
> > > power down the board by a long press to the corresponding button on
> > > the board within 16 seconds, it resets the board: so we cannot
> > > shutdown the board in the next 16 seconds that follow this sequence.
> > >
> > > Maybe that can be resolved by using the one-shot alarm as described by
> > > Adam, I'll try to find that in the datasheet.
> >
> > After configuring the one-shot alarm, I still have those intempestive
> > reboots if I try to power down the board by a long press within 16
> > seconds. The only thing I found in the datasheet regarding this timing
> > is in case of power undervoltage, not sure how this is linked to what
> > I see.
> >
> > @Adam Thomson Any ideas?
>
> Nothing immediately springs to mind. Can you confirm this is the nONKEY long
> press that you're attempting here, which is resetting the board rather than
> shutting down?
Yes, this is the nONKEY long press that, if done within ~16sec after
the board is reset using the alarm, resets the board instead of
shutting it down.
>
> Also, would you able to again provide events and fault log when this unwanted
> reset occurs, just in case there's anything there to give a clue. Can then
> discuss internally to see if we can ascertain what might be happening here.
FAULT_LOG = 0x60
EVENT_A = 0x12
EVENT_B to EVENT_D = 0
But I'm unsure of those values since they are the same after the reset
triggered by the one-shot alarm *and* if I clear EVENT_A, the
intempestive reboot does not appear!
Thanks,
Alex
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-10-05 13:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 5:33 [PATCH] drivers: mfd: da9063: Add restart notifier implementation Alexandre Ghiti
2021-09-21 10:16 ` Anup Patel
2021-09-21 11:20 ` Alexandre Ghiti
2021-09-21 10:25 ` Ben Dooks
2021-09-21 11:33 ` Alexandre Ghiti
2021-09-23 13:16 ` Alexandre Ghiti
2021-09-24 15:04 ` Adam Thomson
2021-09-24 16:17 ` Alexandre Ghiti
2021-09-29 13:33 ` Adam Thomson
2021-09-30 7:51 ` David Abdurachmanov
2021-09-30 9:28 ` Adam Thomson
2021-09-30 10:25 ` Alexandre Ghiti
2021-10-04 12:05 ` Alexandre Ghiti
2021-10-04 15:11 ` Adam Thomson
2021-10-05 13:43 ` Alexandre Ghiti [this message]
2021-10-06 9:30 ` Adam Thomson
2021-10-06 11:35 ` Alexandre Ghiti
2021-10-08 9:46 ` Adam Thomson
2021-10-12 10:32 ` Adam Thomson
2021-10-14 15:51 ` Alexandre Ghiti
2021-10-15 8:47 ` Adam Thomson
2021-09-30 9:37 ` Alexandre Ghiti
2021-09-30 10:47 ` Adam Thomson
2021-09-30 9:55 ` Alexandre Ghiti
2021-10-04 15:29 ` Adam Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+zEjCsf6m8cctHNPBxJczg-J9XC-piAcdtNDO71qmtCtDj9gw@mail.gmail.com \
--to=alexandre.ghiti@canonical.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=david.abdurachmanov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).