From: Alexandre Ghiti <alexandre.ghiti@canonical.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
devicetree@vger.kernel.org,
linux-riscv <linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH v2 2/5] riscv: dts: sifive: fix Unleashed board compatible
Date: Tue, 12 Oct 2021 06:36:25 +0200 [thread overview]
Message-ID: <CA+zEjCtE6OQEcgV3GG3OxdKL0JB+dBWCij35MMd-XVZnTcbsrA@mail.gmail.com> (raw)
In-Reply-To: <20210920130248.145058-2-krzysztof.kozlowski@canonical.com>
On Mon, Sep 20, 2021 at 3:05 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> Add missing sifive,fu540 compatible to fix dtbs_check warnings:
>
> arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dt.yaml: /: compatible: 'oneOf' conditional failed, one must be fixed:
> ['sifive,hifive-unleashed-a00', 'sifive,fu540-c000'] is too short
> 'sifive,hifive-unleashed-a00' is not one of ['sifive,hifive-unmatched-a00']
> 'sifive,fu740-c000' was expected
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> ---
>
> Changes since v1:
> 1. None
> ---
> arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> index 633b31b6e25c..2b4af7b4cc2f 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> @@ -11,7 +11,8 @@ / {
> #address-cells = <2>;
> #size-cells = <2>;
> model = "SiFive HiFive Unleashed A00";
> - compatible = "sifive,hifive-unleashed-a00", "sifive,fu540-c000";
> + compatible = "sifive,hifive-unleashed-a00", "sifive,fu540-c000",
> + "sifive,fu540";
>
> chosen {
> stdout-path = "serial0";
> --
> 2.30.2
>
>
This looks good to me, you can add:
Reviewed-by: Alexandre Ghiti <alexandre.ghiti@canonical.com>
Tested-by: Alexandre Ghiti <alexandre.ghiti@canonical.com>
Thanks,
Alex
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-10-12 4:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 13:02 [RESEND PATCH v2 1/5] riscv: dts: sifive: use only generic JEDEC SPI NOR flash compatible Krzysztof Kozlowski
2021-09-20 13:02 ` [RESEND PATCH v2 2/5] riscv: dts: sifive: fix Unleashed board compatible Krzysztof Kozlowski
2021-10-11 14:42 ` Krzysztof Kozlowski
2021-10-12 4:36 ` Alexandre Ghiti [this message]
2021-09-20 13:02 ` [RESEND PATCH v2 3/5] riscv: dts: sifive: drop duplicated nodes and properties in sifive Krzysztof Kozlowski
2021-10-12 4:56 ` Alexandre Ghiti
2021-09-20 13:04 ` [RESEND PATCH v2 4/5] riscv: dts: microchip: add missing compatibles for clint and plic Krzysztof Kozlowski
2021-09-20 13:04 ` [RESEND PATCH v2 5/5] riscv: dts: sifive: add missing compatible for plic Krzysztof Kozlowski
2021-10-12 4:49 ` Alexandre Ghiti
2021-10-12 4:29 ` [RESEND PATCH v2 1/5] riscv: dts: sifive: use only generic JEDEC SPI NOR flash compatible Alexandre Ghiti
2021-10-12 7:26 ` Krzysztof Kozlowski
2021-10-18 14:00 ` Krzysztof Kozlowski
2021-10-19 9:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+zEjCtE6OQEcgV3GG3OxdKL0JB+dBWCij35MMd-XVZnTcbsrA@mail.gmail.com \
--to=alexandre.ghiti@canonical.com \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).