From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B234C072B1 for ; Thu, 30 May 2019 03:55:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 541A824E67 for ; Thu, 30 May 2019 03:55:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Htek6deE"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="PJS5UiBm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 541A824E67 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tWc1SNNahBlLbKCeUPU6qJqLmsO1Ce2EBxtI6UgCZfQ=; b=Htek6deEELeg9k 5LcaI8zx4QztAp/dyOHDl2SoMMOb9wB4G8EQERyr8BdIQp33aV/CZhTLnzK5CmNpFQDF46ZNXIBzp Zr266K3FnLJH9DGyKQMYr0fFXJ0kMkT/kXrsfXe0HWyljnTkccNG6hTV81PU3OUc4OhzCy8F2DbJm 3Qtqa5f0Sp14qtxDdAcljlJpkullhF1WViqXh6nKMvE+W1JN6L7kkkhGDF0eQKI68MIS3/mABpfI1 oa4/Vby/uo+mKr3RSCy7LGFqJdX4y7Sld8AVSxezR4PdmznRx8jzma9U6/NXZ4h3IIEsvzIyARbBn OUYE+LbRb8v86phjZ4XA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWCA6-0002r2-0T; Thu, 30 May 2019 03:55:30 +0000 Received: from mail-vs1-xe43.google.com ([2607:f8b0:4864:20::e43]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWCA3-0002qO-L1 for linux-riscv@lists.infradead.org; Thu, 30 May 2019 03:55:29 +0000 Received: by mail-vs1-xe43.google.com with SMTP id t20so918671vso.2 for ; Wed, 29 May 2019 20:55:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X6NmEU4MLUbNQzagh8gX4QP4iLT9rJQT3hOjSe8ifDc=; b=PJS5UiBmoSH/3DJyhxGOMZG78bXAyiUF4XTie51QZ7dbgrXI1zCLR3U8Nl+oOK36ky kgARiC+iGA0i1LgHSOLzmR9shhXniAyk1IfzwKi+XPwvVHgfE03N/vGUPMxHyaxIlKx3 QNXmFoxqGrKJOjqsHXU1/mJ/s9zGASzYh6YhWWPJy6CFDLEx25e8KxjsT3NBDb597sbl SA14y4kkxHlk4s0JDfoa3UNLmgvUQSpA1IyfYq+YUB2WaLr6p18KtYY4J1x5AtI/K0FR Coo5aBmnhdCVaZKubHKwmLDOMc/9dOUm9pAKRbPZ+t8jViw0uJPDgOKW9vhTA10HSM+E 3iHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X6NmEU4MLUbNQzagh8gX4QP4iLT9rJQT3hOjSe8ifDc=; b=iA0byn+M6lIkkkEfYJKdGyGBqlIEDCu8nk/hFOORsPIo9jv3ptVwKzcVcfOaF+bsZn s+at3lJHUT6eXsxaZW1jhOJIUCJnJAM7cxno24x1L20g+XW95gyoZ/8Z76e2IPRckxFF DIupwWkHk/va29Xh4h8R2Nsx5FqkIOvZFaJAHFaTWV8HtIVjJ/y+a1fjkXYYRKOCzFOX MWP6t5E65AxhqlpLmJA/uTWIfCcY8hmWLzSL/r1sk8hsdegGIoi7uAtcuFwyvJizz4EL hxgeus8wrSh4VIImLK48fHh3YTGOd9Rbj3vjcxnRNO/gHAk/UOCqx9WruKaJbevKWbU6 XSog== X-Gm-Message-State: APjAAAU0FDqCkpeldjln9/Poq4yPV8v0psOcBFiD2Yo+4kyODggHWWd8 1RXvOWbxEpGkJBTneCfpNBQfKQVtXG7rKAd5ayqJgg== X-Google-Smtp-Source: APXvYqyyO5WeLJ5dPlMguAquOq6SsWs0QbvlKAigq7mHtha3TTqf4stH0xxhv4lIkvOmn1XRkHOYt60//4J8swpgBXI= X-Received: by 2002:a67:c84:: with SMTP id 126mr769392vsm.178.1559188525890; Wed, 29 May 2019 20:55:25 -0700 (PDT) MIME-Version: 1.0 References: <1559104047-13920-1-git-send-email-sagar.kadam@sifive.com> <1559104047-13920-4-git-send-email-sagar.kadam@sifive.com> <20190529155346.GA18059@lunn.ch> In-Reply-To: <20190529155346.GA18059@lunn.ch> From: Sagar Kadam Date: Thu, 30 May 2019 09:25:14 +0530 Message-ID: Subject: Re: [PATCH v8 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC. To: Andrew Lunn X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190529_205527_753772_8B235945 X-CRM114-Status: GOOD ( 12.56 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, peter@korsgaard.com, Palmer Dabbelt , linux-kernel@vger.kernel.org, Rob Herring , Linux I2C , Paul Walmsley , linux-riscv@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, May 29, 2019 at 9:23 PM Andrew Lunn wrote: > > On Wed, May 29, 2019 at 09:57:27AM +0530, Sagar Shrikant Kadam wrote: > > The i2c-ocore driver already has a polling mode interface.But it needs > > a workaround for FU540 Chipset on HiFive unleashed board (RevA00). > > There is an erratum in FU540 chip that prevents interrupt driven i2c > > transfers from working, and also the I2C controller's interrupt bit > > cannot be cleared if set, due to this the existing i2c polling mode > > interface added in mainline earlier doesn't work, and CPU stall's > > infinitely, when-ever i2c transfer is initiated. > > > > Ref: > > commit dd7dbf0eb090 ("i2c: ocores: refactor setup for polling") > > > > The workaround / fix under OCORES_FLAG_BROKEN_IRQ is particularly for > > FU540-COOO SoC. > > > > The polling function identifies a SiFive device based on the device node > > and enables the workaround. > > > > Signed-off-by: Sagar Shrikant Kadam > > Hi Sagar > > When you repost, you are supposed to add any reviewed-by, or acked-by > tags you received. Sorry Andrew, I missed it. I will repost it, with acked by Andrew Lunn as you had Acknowledged it earlier > > Andrew Thanks, Sagar _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv