From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE431CA9EAE for ; Wed, 23 Oct 2019 06:12:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C44F421872 for ; Wed, 23 Oct 2019 06:12:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qI5ZW18d"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=brainfault-org.20150623.gappssmtp.com header.i=@brainfault-org.20150623.gappssmtp.com header.b="nLqN5enM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C44F421872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k/Yqi6ZTDhf2QnloDlPivajcUm5RPVXo07Vzxg3xvJQ=; b=qI5ZW18dZ+HbZY vKA/rUSCDBfWdgXmuhCOde3cmk1EP1eMl2MazYMZDHi+rVR2am/qkJt2BIlLVrNDUSy9FYu2wjCus xhhBhleoEY6Q2LX3HKFNhp68hW1UFBGC++aJYsIYJyPmutGrMrpusFl2GP72C8KodsyDZ9NTNXtG3 A2VJz2TOwVfQgqOcP8gQqQyjGr9NkkCOCywSVlwV8A6p9qibpHrGhk0TPAM1JNJkitLhOrXzQW/Vl K3L2bMreMHCueIeAMfImRqtkd7vNNCUk1HhjpwTrZndqhfKJ+WTaFM0WdB8WQQxK2fP8fPsHRo/nW BcB/bEuIux2nnFsQI5tA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iN9t3-0002jT-OA; Wed, 23 Oct 2019 06:12:49 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iN9t0-0002iV-DG for linux-riscv@lists.infradead.org; Wed, 23 Oct 2019 06:12:48 +0000 Received: by mail-wm1-x342.google.com with SMTP id r141so8732361wme.4 for ; Tue, 22 Oct 2019 23:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s8le1WyXyeTyUa/Z2e+egXbBte2l9NNmas2pvZ4/syo=; b=nLqN5enMDqEAYntQA8O/U/OLZ4Os+aQ+ZzD6WpMcCZPacskczuoFfQR/hGWkoU+qOp 595KTJObybNJe9Yttsbv8w+eQaSRN5172hZMY0c+ng/c8nFcuKqh0+x8h5L/o1sSCnkl Tzb5YM+U54tWEeSy9vlmVeLVLP1Wd0dfEMDdABMF52bEAMkxkJOjap7woq9L3SAmBg4H mP6BWpEyDTn4JzFMckLEhhs86iwEk9RvbU114w9e1Nx9vS/RR/8IOD0qy8YdzCfFbzxF PxLMZ4GLbHfN8VrRdRGJQSkXhY9qQTbLuqJ9Dt5yo7c65rL4e9gZEvI/SsXphv9Ovsn8 y6Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s8le1WyXyeTyUa/Z2e+egXbBte2l9NNmas2pvZ4/syo=; b=ll+hlBDLPxFgKefh13n1I1JPGMMmM9V6lZgIlePrNKk+F8OUtCLsUOqo8cjidl01LB ZYt0nsthzJ15wMXCBb65vTtKqB2VU/L7mTV60FGRlO9uZPD7UlCl0MrB82vvKOXrifWo IakE/tXAuxOsCmeIBHIw/FOEwQ3ea0p80O4C95NwtjlXwXvo4bjn3htRADyeQsudRw7w dGIOhF534leJDIWBa0BOyr42PEROCrhlaD7c3T86MfcCd4ALP8vuujFuaLjKPF+6bnWW uOstz0EtK+/K5WXka6c1ICDDN/ziV8/mjjp0gNeUkk885YsXV47c7twlA6xUoepZQbAa NpTA== X-Gm-Message-State: APjAAAX1G84f2J7xFGPnr6ARVDM4uq60yXBYiG03jIYfpI82Tt14oaOf wJvzNolAIqpKjibdL2qeGZ9H9VBzGtgSaggJg+Q9hA== X-Google-Smtp-Source: APXvYqwyEoWUB1RH8jQxZgTmcn4QkfgMMeY3guAKffsaUXZDLVEqxRSPGnVR9jTgjqmizV+GwpDTEsSdSI25dby9QBs= X-Received: by 2002:a7b:c4d3:: with SMTP id g19mr5690896wmk.24.1571811163897; Tue, 22 Oct 2019 23:12:43 -0700 (PDT) MIME-Version: 1.0 References: <20190925063706.56175-3-anup.patel@wdc.com> <17db4a6244d09abf867daf2a6c10de6a5cd58c89.camel@wdc.com> In-Reply-To: From: Anup Patel Date: Wed, 23 Oct 2019 11:42:32 +0530 Message-ID: Subject: Re: [PATCH v2 2/2] RISC-V: defconfig: Enable Goldfish RTC driver To: Paul Walmsley X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191022_231246_509263_CC73AD78 X-CRM114-Status: GOOD ( 17.52 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "aou@eecs.berkeley.edu" , "gregkh@linuxfoundation.org" , Anup Patel , "palmer@sifive.com" , "linux-kernel@vger.kernel.org" , "hch@infradead.org" , Atish Patra , Alistair Francis , "rkir@google.com" , "linux-riscv@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Oct 23, 2019 at 11:30 AM Paul Walmsley wrote: > > On Wed, 23 Oct 2019, Anup Patel wrote: > > > On Wed, Oct 23, 2019 at 6:37 AM Paul Walmsley wrote: > > > > > Incidentally, just looking at drivers/platform/goldfish, that driver seems > > > to be some sort of Google-specific RPC driver. Are you all really sure > > > > Nopes, it's not RPC driver. In fact, all Goldfish virtual platform > > devices are MMIO devices. > > Is drivers/platform/goldfish/goldfish_pipe.c required for the Goldfish RTC > driver or not? No, it's not required. > > If not, then the first patch that was sent isn't the right fix. It would > be better to remove the Kbuild dependency between the code in > drivers/platform/goldfish and the Goldfish RTC. The common GOLDFISH kconfig option is there to specify the common expectations of all GOLDFISH drivers from Linux ARCH support. Currently, all GOLDFISH drivers require HAS_IOMEM and HAS_DMA support from underlying arch. If you still think that common GOLDFISH kconfig option is not required then please go ahead and send patch. > > If it is required, then surely there must be a simpler RTC implementation > available. GOLDFISH pipe is not required so GOLDFISH RTC is certainly a simple RTC implementation. > > > The problem is VirtIO spec does not define any RTC device so instead of > > inventing our own virtual RTC device we re-use RTC device defined in > > Goldfish virtual platform for QEMU virt machine. This way we can re-use > > the Linux Goldfish RTC driver. > > With 160+ RTC drivers in the kernel tree already, we certainly agree that > it doesn't make sense to invent a new RTC. > > > - Paul Regards, Anup _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv