From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 250C1C433FF for ; Tue, 6 Aug 2019 03:19:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0485216F4 for ; Tue, 6 Aug 2019 03:19:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hFkO0CvN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=brainfault-org.20150623.gappssmtp.com header.i=@brainfault-org.20150623.gappssmtp.com header.b="xQaMHCEu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0485216F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JsFDY0dF+MvDTNWZaGMbfKYSxMU0/gc3BtXxnENAK10=; b=hFkO0CvNQpS4Nw YumOKraHTURALenkjgrowfDsahU4IH+s1AVodhOsZrQ7voLt8BJrfT4Mn0klrqHU6Ad/YEBk4srGI USfhxqMAC+Pyl4jFuvQ2SIeyis4Iu71s3PjTUk62MYMqhjgP2cKKxGL1XdKMtef20UHQeV+X/v/UY 0o+ZezvKpaK8/uSS0Dzkc/M/A/rL1wFUH7uDZgxIJ2tHlJ8Rodj1J64mJuqVbCxg7RgR8XUxtrye/ 7ErtObz7zFhZh46wY5iKhKKCNWcl5yzfqxJ8Z7ZXDQ+JSwwbZeh15JoiBnFlN4+ylh8jpNfbBcHtJ hpA0MXEASliAU7y/o1EQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1huq0j-0007Rv-7K; Tue, 06 Aug 2019 03:19:41 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1huq0g-0007Ra-Lw for linux-riscv@lists.infradead.org; Tue, 06 Aug 2019 03:19:39 +0000 Received: by mail-wm1-x344.google.com with SMTP id h19so7934170wme.0 for ; Mon, 05 Aug 2019 20:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dr2+cEWOTjWIrHgq1rAPpBc6r9tZtYF1YbUnLR69BFg=; b=xQaMHCEu94MSWV0KnK1zA0WkUuR9+C2JoA7OyFGL1bMhbTfgWoKYiPiBLsiLmW+h+x MQ3B6t0N0TyWSy9h9rZc8F+4VTFAIH8Iedrf8KilAY2c5AOdX2tC2CndcOeVjxSy2GHO GI93PGu9zITG/U5rrHWGkkA5Ju5ktIJiHKkSvIGs+vOJ9Kez1Xb0dI8QvVhhWkfzaKsV tMP55LDR3YYdlt9K21sGMwHzYF9O1rH+IegheKtwbw9tlS2hUgPhoge/HJIJWt3xMgRz uA7D4HcLjXGGPwdp50RKYHh/RJ0kRwQ0JvqWO80/m5fi1DQlNlA09FUD+/020u8Gvf4D 8o6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dr2+cEWOTjWIrHgq1rAPpBc6r9tZtYF1YbUnLR69BFg=; b=ITc/2PlXLDILFzuXpMfNotUo8NK0oWfwJGC6RpbLFz5ZhmNS83NZAIyAUOWo4q37jd B6iQ1XUAoyijuKOUo1m/grHz9GsNbZYeQrAaZUEhFHmlyjAHEW6s+s16OQ7Dina5/jna UATScnbQehilmqELK+pK8ZHyOXxvv+P6LrUov3Ikwa5TFxe1zJbS2iHnjDFwR4QPIWih 0QvMcuQIjrHxnEaXTdPvVhiChbn5kmUcfAcMnZozGHjW+8VkC5Cx5y6n6LFhu0tXYkrR nZheo0lC7uc7szq6kl3XaQUIEpo1OYKCZIbcgOymow/ILGZdoY2jLNmKrOHCs3G5ekeT yA/w== X-Gm-Message-State: APjAAAWvr9VcUEOZ1dAkbHLgOdDHYwpReOaFBYL2MJEQDAhIr0aApgbJ /rs/bOHPMN7baWStXg35KWLmbJrHwAf5e0CADEoRRg== X-Google-Smtp-Source: APXvYqwH6qC9nSAJAWBGGxZ0uXvKgHP/raIkzQCYLK0pRSGDcTtZMMyScdsr3bxWn1y3xiVpXqFzA7f5nHQEnBJZ3yw= X-Received: by 2002:a05:600c:254b:: with SMTP id e11mr1313747wma.171.1565061575887; Mon, 05 Aug 2019 20:19:35 -0700 (PDT) MIME-Version: 1.0 References: <20190805134201.2814-1-anup.patel@wdc.com> <20190805134201.2814-12-anup.patel@wdc.com> <21bdde39-8d33-6aae-e729-476ce11406a3@redhat.com> In-Reply-To: <21bdde39-8d33-6aae-e729-476ce11406a3@redhat.com> From: Anup Patel Date: Tue, 6 Aug 2019 08:49:24 +0530 Message-ID: Subject: Re: [PATCH v3 11/19] RISC-V: KVM: Implement VMID allocator To: Paolo Bonzini X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190805_201938_720207_D42651F9 X-CRM114-Status: GOOD ( 11.16 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Le Moal , Palmer Dabbelt , Daniel Lezcano , "kvm@vger.kernel.org" , Radim K , Anup Patel , "linux-kernel@vger.kernel.org" , Christoph Hellwig , Atish Patra , Alistair Francis , Paul Walmsley , Thomas Gleixner , "linux-riscv@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Aug 5, 2019 at 9:33 PM Paolo Bonzini wrote: > > On 05/08/19 15:43, Anup Patel wrote: > > + spin_lock(&vmid_lock); > > + > > + /* > > + * We need to re-check the vmid_version here to ensure that if > > + * another vcpu already allocated a valid vmid for this vm. > > + */ > > + if (!kvm_riscv_stage2_vmid_ver_changed(vmid)) { > > + spin_unlock(&vmid_lock); > > + return; > > + } > > + > > + /* First user of a new VMID version? */ > > + if (unlikely(vmid_next == 0)) { > > + WRITE_ONCE(vmid_version, READ_ONCE(vmid_version) + 1); > > + vmid_next = 1; > > + > > + /* > > + * On SMP, we know no other CPUs can use this CPU's or > > + * each other's VMID after forced exit returns since the > > + * vmid_lock blocks them from re-entry to the guest. > > + */ > > + spin_unlock(&vmid_lock); > > + kvm_flush_remote_tlbs(vcpu->kvm); > > + spin_lock(&vmid_lock); > > This comment is not true anymore, so this "if" should become a "while". Sure, I will update in v4. Regards, Anup _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv