From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A15B9C43603 for ; Sun, 8 Dec 2019 05:27:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A12120692 for ; Sun, 8 Dec 2019 05:27:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ko8BTTbN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=brainfault-org.20150623.gappssmtp.com header.i=@brainfault-org.20150623.gappssmtp.com header.b="jLkzEE1E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A12120692 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To: Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z9pquV3bCMWDZGt16luo26JnnZC+AO01g0+9zHilts8=; b=ko8BTTbNHhkc1ibQrctj6StnM YrIMGZnxd8cONnoLSABDNqlhO5vlF4mtXdtHyq7Vpm0tVpubDnsyZ62IHuGpSxQkDH0ctlvo/0Cst Lgi7/cPfzovwws0zXc2z/waLTu1/nRPRaeFIclAtS1CMXClTZpSS9ld2gl7KrEP0fhb+Dc/x/q6/I AGusG6PrMshd74TNoLQBwT2At79QI5hmtZQUHFuBYOVdxqwytXyEHafKYIYwHiqWt1nK3Rbh7U+vi TuNNcKXZR0sq8X+1Ri8XolesXGzsBPKxrxwnglCnP3QKSiMS/IUgRlfiUuaygb+MBjV1sxPvaz/Jc 0iCOMbWAQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1idp6f-0001t9-LC; Sun, 08 Dec 2019 05:27:45 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1idp6c-0001si-OE for linux-riscv@lists.infradead.org; Sun, 08 Dec 2019 05:27:44 +0000 Received: by mail-wr1-x444.google.com with SMTP id d16so12253746wre.10 for ; Sat, 07 Dec 2019 21:27:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z9pquV3bCMWDZGt16luo26JnnZC+AO01g0+9zHilts8=; b=jLkzEE1Emr1PE83CAnq1AgI/inVp1i1XP/A3KxFtGeJPzlHjql/AW7qbDdoJ6RkwP/ M/blOWuFrHwTqVu0HD7XU6oBygARII63Io7FMuwFIxSBZNWXQE31nohsv70D5gUG4c0i lNvmgd8v9iiNwDU13GC2k+iVIOlGqM5ZLBBwFS0BOKt6JCa7on8rMz9kSlcs7esYIHgo fvsHYFEuxDFHfp+pl5oEMOHRNsbovOC8155cnN2xpFkU2AfJHF/8Ko8IyKuo7p2XDSiq 71OYrCMOENeHGiW1mvRDeWIrxseD+Z++mGviUs4LIgYBh6i6l3P4WQsYall4BQaOHbjs zn5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z9pquV3bCMWDZGt16luo26JnnZC+AO01g0+9zHilts8=; b=hcuE/KeSdEqGselbBDmmwu8Wjj7yCCoclQwju8IcpDRFq38/0G5KX6vVWUUyLBNMRC UT/AP19T53h3ApC5WDuzuFzapaiLvdjww/pwwypbec38UHlvidzY3fMxhHu5DLssVKp+ x//Oa14LodxKmos+W9igXCSDb5kBzGqawzUz46dgNv4t3bjnmC1yneOVgqckRnESEGpm pTIujMbteAlxt3U2Bzh0PLo465O2f2C/4TrjFfE3vG+FEuLmHeL4oACJtCG4zJhafN48 ppP6D9XRLDrojtO8cpJSPdmp4L5fCreIwSST50IVhNtD2hLImoY61mjTVnN1fhCt4kL+ pRFg== X-Gm-Message-State: APjAAAW3Mg33khOqf9JgJwGqmEi5PvHCvhEYNnl8KsSwgx2uCCwUbRTs JwY7xu6oGYv0O342kYd3ymsGM3r/kajR7Y+cPW79Lw== X-Google-Smtp-Source: APXvYqw49COcOiWILG4CPx3KrlSGO4gmMkeSr4gqepLQqQqL+tWII/HFy4Sqica4vGqIHrcRGxBt0cpTksMJcfg5rEs= X-Received: by 2002:adf:d850:: with SMTP id k16mr22791152wrl.96.1575782858366; Sat, 07 Dec 2019 21:27:38 -0800 (PST) MIME-Version: 1.0 References: <20191207212916.130825-1-olof@lixom.net> In-Reply-To: <20191207212916.130825-1-olof@lixom.net> From: Anup Patel Date: Sun, 8 Dec 2019 10:57:27 +0530 Message-ID: Subject: Re: [PATCH] riscv: Fix build dependency for loader To: Olof Johansson Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191207_212742_812808_CA373F58 X-CRM114-Status: GOOD ( 11.57 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Albert Ou , "linux-kernel@vger.kernel.org List" , Palmer Dabbelt , Paul Walmsley , linux-riscv , Christoph Hellwig Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Sun, Dec 8, 2019 at 2:59 AM Olof Johansson wrote: > > The Makefile addition for the flat image loader missed an obj prefix. > > For most parallel builds this worked out fine, but with -j1 the dependency > wasn't fulfilled and thus fails: > > arch/riscv/boot/loader.S: Assembler messages: > arch/riscv/boot/loader.S:7: Error: file not found: arch/riscv/boot/Image > > Fixes: 405fe7aa0dba ("riscv: provide a flat image loader") > Cc: Christoph Hellwig > Signed-off-by: Olof Johansson LGTM. Reviewed-by: Anup Patel Regards, Anup > --- > arch/riscv/boot/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/boot/Makefile b/arch/riscv/boot/Makefile > index a474f98ce4fae..36db8145f9f46 100644 > --- a/arch/riscv/boot/Makefile > +++ b/arch/riscv/boot/Makefile > @@ -24,7 +24,7 @@ $(obj)/Image: vmlinux FORCE > $(obj)/Image.gz: $(obj)/Image FORCE > $(call if_changed,gzip) > > -loader.o: $(src)/loader.S $(obj)/Image > +$(obj)/loader.o: $(src)/loader.S $(obj)/Image > > $(obj)/loader: $(obj)/loader.o $(obj)/Image $(obj)/loader.lds FORCE > $(Q)$(LD) -T $(obj)/loader.lds -o $@ $(obj)/loader.o > -- > 2.11.0 >