From: Anup Patel <anup@brainfault.org>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
Anup Patel <Anup.Patel@wdc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Atish Patra <Atish.Patra@wdc.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] RISC-V: Add debug defconfigs
Date: Thu, 5 Dec 2019 22:03:34 +0530 [thread overview]
Message-ID: <CAAhSdy1RQw3MVcVT5y1EHr72LDNADKRL5nO2E8OrzBi+tpuvtA@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1912041859070.215427@viisi.sifive.com>
On Thu, Dec 5, 2019 at 8:33 AM Paul Walmsley <paul.walmsley@sifive.com> wrote:
>
> On Thu, 5 Dec 2019, Anup Patel wrote:
>
> > Various Linux kernel DEBUG options have big performance impact
> > so these should not be enabled in RISC-V normal defconfigs.
> >
> > Instead we should have separate RISC-V debug defconfigs having
> > these DEBUG options enabled. This way Linux RISC-V can build both
> > non-debug and debug kernels separately.
>
> I respect your point of view, but until the RISC-V kernel port is more
> mature, I personally am not planning to merge this patch, for reasons
> discussed in the defconfig patch descriptions and the subsequent pull
> request threads.
>
> I'm sure we'll revisit this in the future to realign with the defconfig
> debug settings for more mature architecture ports - but my guess is that
> we'll probably avoid creating debug_defconfigs, since only S390 does that.
We have a lot of users (Yocto and Buildroot) dependent on the Linux
defconfig. I understand that you need DEBUG options for SiFive internal
use but this does not mean all users dependent on Linux defconfig
should be penalized in-terms of performance.
This is the right time to introduce debug defconfigs so that you can
use it for your SiFive internal use and all users dependent on normal
defconfigs are not penalized in-terms of performance.
If you still don't want debug defconfigs then I recommend reverting
your DEBUG options patch and you can find an alternative way to
enable DEBUG options for SiFive internal use.
Regards,
Anup
next prev parent reply other threads:[~2019-12-05 16:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 0:56 [PATCH] RISC-V: Add debug defconfigs Anup Patel
2019-12-05 3:03 ` Paul Walmsley
2019-12-05 16:33 ` Anup Patel [this message]
2019-12-05 16:47 ` Daniel Thompson
2019-12-05 17:09 ` Anup Patel
2019-12-05 17:01 ` Paul Walmsley
2019-12-05 17:05 ` Anup Patel
2019-12-05 23:14 ` Paul Walmsley
2019-12-05 23:23 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAhSdy1RQw3MVcVT5y1EHr72LDNADKRL5nO2E8OrzBi+tpuvtA@mail.gmail.com \
--to=anup@brainfault.org \
--cc=Alistair.Francis@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).