From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E591C432C2 for ; Wed, 25 Sep 2019 05:00:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4276A21A4A for ; Wed, 25 Sep 2019 05:00:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oncbjEXg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=brainfault-org.20150623.gappssmtp.com header.i=@brainfault-org.20150623.gappssmtp.com header.b="E8oKqEdy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4276A21A4A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iUPamDFM5LwKTjk9Zj1RjYJX2OoEF7/0mKfKkBRcHsc=; b=oncbjEXglVEbam w6IKwqGodiSPq/N24WzEunM0v2ZDlGY7RrGkjc0q8nMf2JlH/pp3guEEo612ozp/DjQRFx3Vfi6/P gkg4/U4BiTGU+ozrWONaUyVNGf44WHPZldoN8SRYJUzZQTViPhnFsFC2WWik8qEVe6vd08J8nfJOg VBBF/HAnM640jsm5R7GNXAlUt2pFwnnHEA5w1mvzzT+Uvqar80/im8KMdIBbtVo83UUfMNX7Ku5Qr sXBep9rCJxj1Pt4Ly3PhMYRUp8Uru1hM2ZVASb2s2qP3zPitMOjSKGzQn6v9ITruLUqcnOM9vznPq TwpuB0rb6B+Dffcn2qYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCzPX-0007iK-Pe; Wed, 25 Sep 2019 05:00:19 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCzPV-0007hW-BL for linux-riscv@lists.infradead.org; Wed, 25 Sep 2019 05:00:18 +0000 Received: by mail-wm1-x341.google.com with SMTP id 7so3106562wme.1 for ; Tue, 24 Sep 2019 22:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qCjUe0hDGDhMjnECf1F2ZQdV6LWs8J93Rkhj1cQXHGo=; b=E8oKqEdyG0bLy1YbJxVkgMWG5q1T851YJJLeEfwLZBcBzm/Z/rJFURALxIbiMzCeC6 q4vrrUEPF7pfaObZleGRa4FaCj45G3Ud97aVzTOTTvst/+YIL/jQAVb+Ufw72IsVoVrO SDfYjZS5eKmEAeURuNg31P2jNvK3iguYv/xX2yw9wlsqE/Q9AAEaXDq3XkJw7typ0Sil KghJ4psNwURfLM98alBol1KgNc2xz7kwEbDt9qoJ1b+MjSh/y4Z+nGfiuKHZWX5Hw+Ru Sx/fwESJyNav3DjbOeDTzBG/ItKImxkNKo3AcmrAl6rDzni/9Yf2SaQlB7nJc3jwflHT BkMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qCjUe0hDGDhMjnECf1F2ZQdV6LWs8J93Rkhj1cQXHGo=; b=MIbN7QTFTPBWhP3E4SNQcssqSx/BEU6YErq/9dHU32O8zpljS0N6bu18HRWb/ZNRJk AxkiZ0yCpsryVwGDak/DQjuAxPUFnquYEWHQM68YVSD+r7o7FoSnQ4KzLued7A8Ms1pX GY4uJWW/TJRbx1znjOdIVHy0FbMC5iQB0tVDgyzwRPDNj5U8ZSDe5XcE1ELhKNzY4a31 VlbBjKRgg3T2rYq+4X0IDBx/G2OtmSClOXVJ1akdxEeHYkOpGwHqFGaNqCSnNCXdm6OM ebSjJoRW7nLBbIqTHnD2RrgzQCi4EkGc0YVD2L2sKiIz2WjKuTWj++5GemwL/wW8JxQv X/sQ== X-Gm-Message-State: APjAAAVWvZ48ZqROp+Xy0u3fmlSFdrWoeIab7TBGEuR/ZvKf/+Zv+2hk lqN0a14lPE8TQP//J/4KtAbxj5y8ZGgw8TVMLkv4Vw== X-Google-Smtp-Source: APXvYqy1vkOuGEDqTNg8aNO4jpgMMXEuZMX6RWQpVXhNioHmNHB+PBavw+PntxSsQx8Rbkok2+C/qrGdOpdJ96+qhew= X-Received: by 2002:a1c:5451:: with SMTP id p17mr4901443wmi.103.1569387612159; Tue, 24 Sep 2019 22:00:12 -0700 (PDT) MIME-Version: 1.0 References: <20190925042912.119553-1-anup.patel@wdc.com> <20190925042912.119553-2-anup.patel@wdc.com> <20190925044308.GA1245729@kroah.com> In-Reply-To: <20190925044308.GA1245729@kroah.com> From: Anup Patel Date: Wed, 25 Sep 2019 10:30:00 +0530 Message-ID: Subject: Re: [PATCH 1/2] platform: goldfish: Allow goldfish virtual platform drivers for RISCV To: Greg Kroah-Hartman X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190924_220017_393621_F4312C83 X-CRM114-Status: GOOD ( 14.71 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Palmer Dabbelt , Anup Patel , "linux-kernel@vger.kernel.org" , Christoph Hellwig , Atish Patra , Albert Ou , Alistair Francis , Paul Walmsley , Roman Kiryanov , "linux-riscv@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Sep 25, 2019 at 10:13 AM Greg Kroah-Hartman wrote: > > On Wed, Sep 25, 2019 at 04:30:03AM +0000, Anup Patel wrote: > > We will be using some of the Goldfish virtual platform devices (such > > as RTC) on QEMU RISC-V virt machine so this patch enables goldfish > > kconfig option for RISC-V architecture. > > > > Signed-off-by: Anup Patel > > --- > > drivers/platform/goldfish/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/platform/goldfish/Kconfig b/drivers/platform/goldfish/Kconfig > > index 77b35df3a801..0ba825030ffe 100644 > > --- a/drivers/platform/goldfish/Kconfig > > +++ b/drivers/platform/goldfish/Kconfig > > @@ -1,7 +1,7 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > menuconfig GOLDFISH > > bool "Platform support for Goldfish virtual devices" > > - depends on X86_32 || X86_64 || ARM || ARM64 || MIPS > > + depends on X86_32 || X86_64 || ARM || ARM64 || MIPS || RISCV > > Why does this depend on any of these? Can't we just have: May be Goldfish drivers were compile tested/tried on these architectures only. > > > depends on HAS_IOMEM > > And that's it? I think it should be just "depends on HAS_IOMEM && HAS_DMA" just like VirtIO MMIO. Agree ?? Regards, Anup _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv