From: Anup Patel <anup@brainfault.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Palmer Dabbelt <palmer@sifive.com>,
Anup Patel <Anup.Patel@wdc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Atish Patra <Atish.Patra@wdc.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Paul Walmsley <paul.walmsley@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v2 4/5] RISC-V: Remove redundant trampoline page table
Date: Mon, 25 Mar 2019 09:47:24 +0530 [thread overview]
Message-ID: <CAAhSdy27fGCiFc_g06Q3AnaVEJ_P6GeOoEFw5vA6tkN++4xRTA@mail.gmail.com> (raw)
In-Reply-To: <20190322133330.GB32464@infradead.org>
On Fri, Mar 22, 2019 at 7:03 PM Christoph Hellwig <hch@infradead.org> wrote:
>
> >
> > - /* Compute satp for kernel page tables, but don't load it yet */
> > + /* Compute satp for kernel page directory, but don't load it yet */
>
>
> > /*
> > - * Load trampoline page directory, which will cause us to trap to
> > + * Load kernel page directory, which will cause us to trap to
> > * stvec if VA != PA, or simply fall through if VA == PA
> > */
>
> If we want to nitpick comments I think this should take about the
> page table root or something like that.
Okay, I will update comments.
>
> Otherwise the idea looks good, but I really think we should do this
> before all the changes to the setup_vm code.
Sure, I will move it before setup_vm code so that setup_vm code is
further simplified.
Regards,
Anup
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-03-25 4:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 9:47 [PATCH v2 0/5] Boot RISC-V kernel from any 4KB aligned address Anup Patel
2019-03-21 9:47 ` [PATCH v2 1/5] RISC-V: Add separate defconfig for 32bit systems Anup Patel
2019-03-21 9:47 ` [PATCH v2 2/5] RISC-V: Make setup_vm() independent of GCC code model Anup Patel
2019-03-23 15:45 ` Mike Rapoport
2019-03-25 4:19 ` Anup Patel
2019-03-21 9:47 ` [PATCH v2 3/5] RISC-V: Allow booting kernel from any 4KB aligned address Anup Patel
2019-03-23 15:40 ` Mike Rapoport
2019-03-23 17:24 ` Christoph Hellwig
2019-03-24 4:16 ` Anup Patel
2019-03-24 3:32 ` Anup Patel
2019-03-21 9:47 ` [PATCH v2 4/5] RISC-V: Remove redundant trampoline page table Anup Patel
2019-03-22 13:33 ` Christoph Hellwig
2019-03-25 4:17 ` Anup Patel [this message]
2019-03-21 9:47 ` [PATCH v2 5/5] RISC-V: Fix memory reservation in setup_bootmem() Anup Patel
2019-03-22 13:31 ` Christoph Hellwig
2019-03-23 15:44 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAhSdy27fGCiFc_g06Q3AnaVEJ_P6GeOoEFw5vA6tkN++4xRTA@mail.gmail.com \
--to=anup@brainfault.org \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).