From: Anup Patel <anup@brainfault.org>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Palmer Dabbelt <palmer@sifive.com>,
Anup Patel <Anup.Patel@wdc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
Atish Patra <Atish.Patra@wdc.com>,
Albert Ou <aou@eecs.berkeley.edu>, Gary Guo <gary@garyguo.net>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v2] RISC-V: Implement ASID allocator
Date: Fri, 29 Mar 2019 10:42:06 +0530 [thread overview]
Message-ID: <CAAhSdy2VaUJeMx0S=PA0NrX8s1eqvbNkknHi0cqX_OS4+y7u+g@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1903282158510.25278@viisi.sifive.com>
On Fri, Mar 29, 2019 at 10:34 AM Paul Walmsley <paul.walmsley@sifive.com> wrote:
>
>
> On Thu, 28 Mar 2019, Anup Patel wrote:
>
> > Signed-off-by: Gary Guo <gary@garyguo.net>
> > Signed-off-by: Anup Patel <anup.patel@wdc.com>
> > ---
> > Changes since v1:
> > - We adapt good aspects from Gary Guo's ASID allocator implementation
> > and provide due credit to him by adding his SoB.
>
> This isn't the right way to use Signed-off-by: lines in the kernel. See
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/5.Posting.rst#n213
>
> and
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n418
>
> The only people who should be listed in Signed-off-by: lines are patch
> authors.
>
> If your intention is to give Gary credit for changes in your patch,
> describe what ideas or code snippets you've taken in the patch description
> itself, above your Signed-off-by: lines so they would be included in the
> git commit description should your patch be merged.
Thanks for clarifying...
Under "Changes since v1" I have clarified what suggestions I have
taken from Gray.
Gray insist that I use "Co-developed-by:" so I have posted v3 with
"Co-developed-by:". Honestly, I don't mind "Signed-off-by: " or
"Co-developed-by:" as long as I am acknowledging other person's
efforts.
Regards,
Anup
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-03-29 5:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 6:32 [PATCH v2] RISC-V: Implement ASID allocator Anup Patel
2019-03-28 13:37 ` Gary Guo
2019-03-28 14:09 ` Anup Patel
2019-03-28 14:30 ` Gary Guo
2019-03-29 4:43 ` Anup Patel
2019-03-28 14:13 ` Anup Patel
2019-03-28 14:33 ` Gary Guo
2019-03-29 4:49 ` Anup Patel
2019-03-29 5:04 ` Paul Walmsley
2019-03-29 5:12 ` Anup Patel [this message]
2019-04-09 3:02 ` Guo Ren
2019-04-09 3:36 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAhSdy2VaUJeMx0S=PA0NrX8s1eqvbNkknHi0cqX_OS4+y7u+g@mail.gmail.com' \
--to=anup@brainfault.org \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=gary@garyguo.net \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).