From: Anup Patel <anup@brainfault.org>
To: Nick Kossifidis <mick@ics.forth.gr>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@sifive.com>,
"linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Atish Patra <atish.patra@wdc.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] RISC-V: Make BSS section as the last section in vmlinux.lds.S
Date: Tue, 18 Dec 2018 13:53:23 +0530 [thread overview]
Message-ID: <CAAhSdy2bxrP0VQui5AzEL5sueDACU9DkCN4h0--aC=8OpYKt8w@mail.gmail.com> (raw)
In-Reply-To: <587bbe80f25203e6122dfcc0eadba50b@mailhost.ics.forth.gr>
On Mon, Dec 17, 2018 at 6:29 PM Nick Kossifidis <mick@ics.forth.gr> wrote:
>
> Στις 2018-12-17 11:36, Anup Patel έγραψε:
> > On Mon, Nov 26, 2018 at 11:42 AM Anup Patel <anup@brainfault.org>
> > wrote:
> >>
> >> The objcopy only emits loadable sections when creating flat kernel
> >> Image. To have minimal possible size of flat kernel Image, we should
> >> have all non-loadable sections after loadable sections.
> >>
> >> Currently, execption table section (loadable section) is after BSS
> >> section (non-loadable section) in the RISC-V vmlinux.lds.S. This
> >> is not optimal for having minimal flat kernel Image size hence this
> >> patch makes BSS section as the last section in RISC-V vmlinux.lds.S.
> >>
> >> In addition, we make BSS section aligned to 16byte instead of PAGE
> >> aligned which further reduces flat kernel Image size by few KBs.
> >>
> >> The flat kernel Image size of Linux-4.20-rc4 using GCC 8.2.0 is
> >> 8819980 bytes with current RISC-V vmlinux.lds.S and it reduces to
> >> 7991740 bytes with this patch applied using GCC 8.2.0. In summary,
> >> this patch reduces Linux-4.20-rc4 flat kernel Image size by 809 KB.
> >>
> >> Signed-off-by: Anup Patel <anup@brainfault.org>
> >> ---
> >> arch/riscv/kernel/vmlinux.lds.S | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/riscv/kernel/vmlinux.lds.S
> >> b/arch/riscv/kernel/vmlinux.lds.S
> >> index 65df1dfdc303..cc99eed44931 100644
> >> --- a/arch/riscv/kernel/vmlinux.lds.S
> >> +++ b/arch/riscv/kernel/vmlinux.lds.S
> >> @@ -74,8 +74,6 @@ SECTIONS
> >> *(.sbss*)
> >> }
> >>
> >> - BSS_SECTION(PAGE_SIZE, PAGE_SIZE, 0)
> >> -
> >> EXCEPTION_TABLE(0x10)
> >> NOTES
> >>
> >> @@ -83,6 +81,8 @@ SECTIONS
> >> *(.rel.dyn*)
> >> }
> >>
> >> + BSS_SECTION(0x10, 0x10, 0x10)
> >> +
> >> _end = .;
> >>
> >> STABS_DEBUG
> >> --
> >> 2.17.1
> >>
> >
> > Hi All,
> >
> > Any comment on this patch?
> >
> > Regards,
> > Anup
> >
>
> Just a note on coding style, you should be using a macro instead of 0x10
> so that those who read the code can understand what it is and also a few
> comments since searching through the commit logs to understand why you
> used it isn't optimal.
RISC-V can support 32bit, 64bit and 128bit machine-word sizes.
The 0x10 number is the machine-word size in bytes for 128bit
RISC-V CPU (i.e. maximum machine-word size).
I will add a macro MAX_BYTES_PER_LONG in vmlinux.lds.S and
use it in-place of 0x10
Regards,
Anup
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2018-12-18 8:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 6:08 [PATCH] RISC-V: Make BSS section as the last section in vmlinux.lds.S Anup Patel
2018-11-26 6:08 ` Anup Patel
2018-11-29 7:36 ` Bin Meng
2018-11-29 7:36 ` Bin Meng
2018-12-17 9:36 ` Anup Patel
2018-12-17 12:59 ` Nick Kossifidis
2018-12-18 8:23 ` Anup Patel [this message]
2018-12-20 20:40 ` Palmer Dabbelt
2018-12-23 14:58 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAhSdy2bxrP0VQui5AzEL5sueDACU9DkCN4h0--aC=8OpYKt8w@mail.gmail.com' \
--to=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mick@ics.forth.gr \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).