From: Anup Patel <anup@brainfault.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Palmer Dabbelt <palmer@sifive.com>,
Anup Patel <Anup.Patel@wdc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Atish Patra <Atish.Patra@wdc.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alistair Francis <Alistair.Francis@wdc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Roman Kiryanov <rkir@google.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH 1/2] platform: goldfish: Allow goldfish virtual platform drivers for RISCV
Date: Wed, 25 Sep 2019 10:46:52 +0530 [thread overview]
Message-ID: <CAAhSdy3JyLyLF0FHdeXj2yZQO8wz=aAgjyg15x9ENeGxfgbp-A@mail.gmail.com> (raw)
In-Reply-To: <20190925050653.GA1337454@kroah.com>
On Wed, Sep 25, 2019 at 10:37 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Sep 25, 2019 at 10:30:00AM +0530, Anup Patel wrote:
> > On Wed, Sep 25, 2019 at 10:13 AM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Wed, Sep 25, 2019 at 04:30:03AM +0000, Anup Patel wrote:
> > > > We will be using some of the Goldfish virtual platform devices (such
> > > > as RTC) on QEMU RISC-V virt machine so this patch enables goldfish
> > > > kconfig option for RISC-V architecture.
> > > >
> > > > Signed-off-by: Anup Patel <anup.patel@wdc.com>
> > > > ---
> > > > drivers/platform/goldfish/Kconfig | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/platform/goldfish/Kconfig b/drivers/platform/goldfish/Kconfig
> > > > index 77b35df3a801..0ba825030ffe 100644
> > > > --- a/drivers/platform/goldfish/Kconfig
> > > > +++ b/drivers/platform/goldfish/Kconfig
> > > > @@ -1,7 +1,7 @@
> > > > # SPDX-License-Identifier: GPL-2.0-only
> > > > menuconfig GOLDFISH
> > > > bool "Platform support for Goldfish virtual devices"
> > > > - depends on X86_32 || X86_64 || ARM || ARM64 || MIPS
> > > > + depends on X86_32 || X86_64 || ARM || ARM64 || MIPS || RISCV
> > >
> > > Why does this depend on any of these? Can't we just have:
> >
> > May be Goldfish drivers were compile tested/tried on these architectures only.
>
> True, but that does not mean a driver should only have a specific list
> of arches. This should only be needed if you _know_ it doesn't work on
> a specific arch, not the other way around.
No problem, I will drop depends on various architectures line
>
> > > > depends on HAS_IOMEM
> > >
> > > And that's it?
> >
> > I think it should be just "depends on HAS_IOMEM && HAS_DMA" just like
> > VirtIO MMIO. Agree ??
>
> No idea, but if that's what is needed for building, then sure :)
The Goldfish framebuffer can do DMA access so I add dependency on
HAS_DMA.
Refer, https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT
I will send v2 as-per above.
Regards,
Anup
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-09-25 5:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 4:29 [PATCH 0/2] Enable Goldfish RTC for RISC-V Anup Patel
2019-09-25 4:30 ` [PATCH 1/2] platform: goldfish: Allow goldfish virtual platform drivers for RISCV Anup Patel
2019-09-25 4:43 ` Greg Kroah-Hartman
2019-09-25 5:00 ` Anup Patel
2019-09-25 5:06 ` Greg Kroah-Hartman
2019-09-25 5:16 ` Anup Patel [this message]
2019-09-25 4:30 ` [PATCH 2/2] RISC-V: defconfig: Enable Goldfish RTC driver Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAhSdy3JyLyLF0FHdeXj2yZQO8wz=aAgjyg15x9ENeGxfgbp-A@mail.gmail.com' \
--to=anup@brainfault.org \
--cc=Alistair.Francis@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=rkir@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).