From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B937C49ED7 for ; Tue, 10 Sep 2019 23:48:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 359DA21928 for ; Tue, 10 Sep 2019 23:48:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FLDf6rHN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fNEGUezE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 359DA21928 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MNVvY8bVg0meL4cHsCzUUQGGH66NVk9KRFZokHZKwY4=; b=FLDf6rHN85P0An MxrEqDRI/uqBNwOoMcVQpki6Rjxwd1Gv4arwlrg/k/k7oI7YGk4KuBavuwp9GDQO1rJDGBNJify71 TOv45zgRL99JU/XwTGHHs63f+CPDa5VzW1LqLZLQLuh9FMBbkuIalWIJ/bofuxV1Q48UBPxuSP3bW /y1hKiyd8QNUJzgDrNiT1PJvENtXiioryZaGo1syi3ES7/cjTQP+COHLekpBH+OVHEBzWKJq7+dVY b6dikr0anQkAZku12AuCUtYh9p5t+DYYbNi2s9blaa78m5y56MFwcUhMiRabJ+W10/1Unh4ZdLxGJ QA4qg4k5wDX9qw0OCKiw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i7psY-0000NE-55; Tue, 10 Sep 2019 23:48:58 +0000 Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i7psN-0000Hm-5F for linux-riscv@lists.infradead.org; Tue, 10 Sep 2019 23:48:51 +0000 Received: by mail-lf1-x143.google.com with SMTP id d10so14900225lfi.0 for ; Tue, 10 Sep 2019 16:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nL38C4T4rzT0VSsEiKY7BmomDl3hFeY7088tc9RdLq8=; b=fNEGUezEn4ClsVHmX/nmNiF7ZG6JTfC2btDRxEWPcdmRk0a0FsvI5GS8qdYjx25FKp Z5Q4/CFu+iDSAX2rFterlnGQ1MW2Sk6gR3mfMsTu8vyvU/jGEM0Jc08W0Sq44lgp0xR9 CuSR5RUBNAD9f/xSIv24vJgfP+XgU0l/RFI3nayQNe/1yYJJGrgKDIL8s6DHZhU39Dqr TBKpHqE1DkJvJTHx2NFHskH6dl7p95yi4sNbTImUxUlyGuSbemOLPHLEtIfXkNBw9d7/ rUpU1+cMWUkAMn+hR7NDiGLEM6b9jVVLEIcpdiiAIbYGINkcClRodvCdYR9vR8oMDgr8 5cAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nL38C4T4rzT0VSsEiKY7BmomDl3hFeY7088tc9RdLq8=; b=ioTPXXur6LjoVskt+MORNDfl8WWE2A3reD+umFqcBq8iCU7P3a0dOJvUnqV4xq9niN PAcuV3BwdkXORQlCzcVrRfJCadYbp59FR+pIK7SNBSPfioBf+uLnR/flwfFDOwCCBrzp F0dKIx9tFnV2cuewpXZBoWNS2ZDbCifKajOH/Q1AZ2KNY/+CqZWUU23xj3HUud/gPYRy TVl47I1AGzrts7Q7L2ATFAvN5kShJnZOq69KkcfJe/pawIqwKpWPWIMsESuoIScK2o2c bXeulNoLXYs6gj0qvcDL8gD5YdxiTSVuNk+Ltx78dtKoWTSCGc8EV0Fdx8/PDgGh0/+d I4rw== X-Gm-Message-State: APjAAAWPoVkP5TeFcdasiiMlmH9mzF/juBb6KdCx3lliM/bIgYFX0i0Z FkJzB2vfRSq2lsfiDF733JQIwLu8HRct9ig1KW+5/Q== X-Google-Smtp-Source: APXvYqxP4f7JH+QwULI+vOrlKcfc2e6lWO/TBU9/DTND7ll7mmRrx+NRPo2/Aht4Q5KFeqk+4RbtApAQjqBPq8BsL30= X-Received: by 2002:ac2:530e:: with SMTP id c14mr21391170lfh.165.1568159324971; Tue, 10 Sep 2019 16:48:44 -0700 (PDT) MIME-Version: 1.0 References: <1568123236-767-1-git-send-email-claudiu.beznea@microchip.com> <1568123236-767-8-git-send-email-claudiu.beznea@microchip.com> In-Reply-To: <1568123236-767-8-git-send-email-claudiu.beznea@microchip.com> From: Linus Walleij Date: Wed, 11 Sep 2019 00:48:33 +0100 Message-ID: Subject: Re: [PATCH 7/7] clocksource/drivers/integrator-ap: parse the chosen node To: Claudiu Beznea X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190910_164847_229348_5197A78B X-CRM114-Status: GOOD ( 16.49 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomer Maimon , "Nori, Sekhar" , guoren@kernel.org, linux-stm32@st-md-mailman.stormreply.com, =?UTF-8?Q?Heiko_St=C3=BCbner?= , linux-samsung-soc , "open list:ARM/Rockchip SoC..." , Kevin Hilman , Ludovic Desroches , NXP Linux Team , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , "moderated list:H8/300 ARCHITECTURE" , Marc Zyngier , Sascha Hauer , linux-unisoc@lists.infradead.org, Krzysztof Halasa , Thomas Gleixner , Scott Branden , "linux-kernel@vger.kernel.org" , Ralf Baechle , Paul Burton , Sascha Hauer , Mark Rutland , Alexandre Belloni , James Hogan , Palmer Dabbelt , Eric Anholt , "thierry.reding@gmail.com" , Manivannan Sadhasivam , Yoshinori Sato , Lyra Zhang , Daniel Lezcano , Jon Hunter , Bartosz Golaszewski , Kukjin Kim , Alexandre TORGUE , MSM , Sudeep Holla , Florian Fainelli , John Stultz , linux-rpi-kernel , "open list:ARM/Amlogic Meson..." , Linux ARM , Barry Song , Imre Kaloz , Stephen Boyd , Patrice CHOTARD , Stefan Wahren , Maxime Coquelin , Neil Armstrong , linux-tegra@vger.kernel.org, Fabio Estevam , Lorenzo Pieralisi , Benjamin Fair , Alexander Shiyan , Krzysztof Kozlowski , Nancy Yuen , Chen-Yu Tsai , bcm-kernel-feedback-list , Orson Zhai , "open list:SYNOPSYS ARC ARCHITECTURE" , Ray Jui , Vladimir Zapolskiy , John Crispin , tali.perry1@gmail.com, Avi Fishman , Patrick Venture , Ley Foon Tan , linux-oxnas@groups.io, Shawn Guo , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Baruch Siach , Maxime Ripard , Liviu Dudau , linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, OpenBMC Maillist , Russell King , Andy Gross , Sylvain Lemieux , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , aou@eecs.berkeley.edu, Rob Herring , "moderated list:ARM/Mediatek SoC support" , Santosh Shilimkar , Matthias Brugger , Michal Simek , Baolin Wang , Vineet Gupta , Nicolas Ferre , Tony Prisk , "moderated list:NIOS2 ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Sep 10, 2019 at 2:50 PM Claudiu Beznea wrote: > From: Alexandre Belloni > > The driver currently uses aliases to know whether the timer is the > clocksource or the clockevent. OK maybe that wasn't the most elegant solution. > Add the /chosen/linux,clocksource and > /chosen/linux,clockevent parsing while keeping backward compatibility. This is not how I would solve this today. I would simply remove/comment out the IRQ from the timer that cannot be used for clockevent from the device tree (apparently it doesn't work anyway), and make the code only pick a timer with a valid interrupt assigned as clock event, while a timer without interrupt can be used for clock source. This has the upside of not needing any special aliases or chosen things. Yours, Linus Walleij _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv