From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E648BC10F27 for ; Mon, 9 Mar 2020 10:34:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8AE920409 for ; Mon, 9 Mar 2020 10:34:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XOlJj4tR"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fCNoiI9Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8AE920409 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To: Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2lLFs54/t+Cu/Hph6UOSk9acLYx0FZED0nmtfF1kpbg=; b=XOlJj4tR7q8AJs3xqRm3U0COl fjk8MpGinkMvJIga6GGD4+WLf0hPfyWrOUNCegyUXkOkc8JtSVdRBTuOtHCzagCajFe8mNHAvfZNg Y68H3Ttw8iL9/3SDcMFoCFnOxZHi03OQ54JKJef3Gb3R0zoPgWbScBR0G1h0QBlxGRR68yat3TaIX OgYEGGyo/feo3Ag5xm0maCxqG38NG8/JByHXPBnatX1WhOuG12Lpu66jwukSbvNUlrbtER+mtgHYi 8D1Iu7xa5kNywQXpPzybZlG3Rp0jqiXwhEX7tbiqcsGp3JxcrVPsOqsOqu6WB2hAmmQBMizT49yx/ nTujIJGBQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBFjW-0007rC-1A; Mon, 09 Mar 2020 10:34:02 +0000 Received: from mail-yw1-xc43.google.com ([2607:f8b0:4864:20::c43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBFjS-0007qi-L1 for linux-riscv@lists.infradead.org; Mon, 09 Mar 2020 10:34:00 +0000 Received: by mail-yw1-xc43.google.com with SMTP id d79so8580176ywd.2 for ; Mon, 09 Mar 2020 03:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2lLFs54/t+Cu/Hph6UOSk9acLYx0FZED0nmtfF1kpbg=; b=fCNoiI9Yx/cFVasSw/y1aVs2sUUGiPwJVcjVHueIjmDe5MQ/ex5EwPT0mWUjaRccfh wef7+xllPDFKuG/jPB9c5XUwcHaWf10iXdadePtKh5LkWebjc1g5Kj1JEV1zmuOxOV/v KbR3WuN3rhQPjYNQJqFr+46lnlY9P56BSzV4lDraIzoH85YIr/IJ7BednoRSyz4f0Bf5 YzbzKBUYAasu8awc+8Z0oTZSHhPFLWXkU/NoDq+osdFJNWdLC0sX89vNI+0DYXe7D20i feXjK3rz0DZ9MHzY3rJOKDYfyeaNBxVte87+eoFwE5t/Jl0pXDXC93U0s8SXhv7O7Zxm cyKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2lLFs54/t+Cu/Hph6UOSk9acLYx0FZED0nmtfF1kpbg=; b=b5LF3YF+PEmbat88hjxAHn2QlF/+TusCuQFlGAgqxh6aJtztJt+ytWgCuRx5Ja1XwB AgPddngqsPvGH4ZWdlLJkWrrCpc/K5d20+nLgrCJhqWpKSiOtmgJH3Xlh0/G0kem9+WH p85SVe5IPxlse7BFC41/SlhGGicQhT1Pm8Ut5Px60x0N+tEp0coDKA7LdAp1Qz+wr8EW dRTDHtk0fi5wKh0vBX0Wbcqf6gQDoULZgCrrvksNbr36h9rzMVwm8iSaYLdRcjql8QEc bnVFV2Jp7rK9aH4C7ryjbsjDn7oARrcnw+jD2BhvNENWTdlZBldGaWtsV3+cZUUH90SP /iWA== X-Gm-Message-State: ANhLgQ2kgmrC4QDn+h5lSHAl51t5j8hGt6y/6NunfixiW0G+PoYs4Xsb pKN9aBe2ByYKBxVN3wIZCoZeK/LVfpMaQ34NRII= X-Google-Smtp-Source: ADFU+vvbwTwv9de92fogg5g5NKBMFkhlEG4/aeE5xF0RjYjjq7JmVdcxOpPviYEU+igLWaMrzewh0pqfzGulF9N+4zs= X-Received: by 2002:a25:54d:: with SMTP id 74mr17576126ybf.490.1583750037430; Mon, 09 Mar 2020 03:33:57 -0700 (PDT) MIME-Version: 1.0 References: <20200221004413.12869-1-atish.patra@wdc.com> <20200221004413.12869-3-atish.patra@wdc.com> In-Reply-To: <20200221004413.12869-3-atish.patra@wdc.com> From: Bin Meng Date: Mon, 9 Mar 2020 18:33:46 +0800 Message-ID: Subject: Re: [PATCH v9 02/12] RISC-V: Add basic support for SBI v0.2 To: Atish Patra Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200309_033358_720910_4406B425 X-CRM114-Status: GOOD ( 21.46 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Lezcano , Palmer Dabbelt , Heiko Carstens , linux-riscv , Jason Cooper , Marc Zyngier , "Rafael J. Wysocki" , Mike Rapoport , Geert Uytterhoeven , Borislav Petkov , Mao Han , Albert Ou , Kees Cook , Paul Walmsley , Thomas Gleixner , Nick Hu , Greg Kroah-Hartman , linux-kernel , Vincent Chen , Palmer Dabbelt , "Eric W. Biederman" , Anup Patel Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Feb 21, 2020 at 8:45 AM Atish Patra wrote: > > The SBI v0.2 introduces a base extension which is backward compatible > with v0.1. Implement all helper functions and minimum required SBI > calls from v0.2 for now. All other base extension function will be > added later as per need. > As v0.2 calling convention is backward compatible with v0.1, remove > the v0.1 helper functions and just use v0.2 calling convention. > > Signed-off-by: Atish Patra > Reviewed-by: Anup Patel > Reviewed-by: Palmer Dabbelt > --- > arch/riscv/include/asm/sbi.h | 140 ++++++++++---------- > arch/riscv/kernel/sbi.c | 243 ++++++++++++++++++++++++++++++++++- > arch/riscv/kernel/setup.c | 5 + > 3 files changed, 314 insertions(+), 74 deletions(-) > > diff --git a/arch/riscv/include/asm/sbi.h b/arch/riscv/include/asm/sbi.h > index b38bc36f7429..fbdb7443784a 100644 > --- a/arch/riscv/include/asm/sbi.h > +++ b/arch/riscv/include/asm/sbi.h > @@ -10,93 +10,88 @@ > #include > > #ifdef CONFIG_RISCV_SBI > -#define SBI_EXT_0_1_SET_TIMER 0x0 > -#define SBI_EXT_0_1_CONSOLE_PUTCHAR 0x1 > -#define SBI_EXT_0_1_CONSOLE_GETCHAR 0x2 > -#define SBI_EXT_0_1_CLEAR_IPI 0x3 > -#define SBI_EXT_0_1_SEND_IPI 0x4 > -#define SBI_EXT_0_1_REMOTE_FENCE_I 0x5 > -#define SBI_EXT_0_1_REMOTE_SFENCE_VMA 0x6 > -#define SBI_EXT_0_1_REMOTE_SFENCE_VMA_ASID 0x7 > -#define SBI_EXT_0_1_SHUTDOWN 0x8 > +enum sbi_ext_id { > + SBI_EXT_0_1_SET_TIMER = 0x0, > + SBI_EXT_0_1_CONSOLE_PUTCHAR = 0x1, > + SBI_EXT_0_1_CONSOLE_GETCHAR = 0x2, > + SBI_EXT_0_1_CLEAR_IPI = 0x3, > + SBI_EXT_0_1_SEND_IPI = 0x4, > + SBI_EXT_0_1_REMOTE_FENCE_I = 0x5, > + SBI_EXT_0_1_REMOTE_SFENCE_VMA = 0x6, > + SBI_EXT_0_1_REMOTE_SFENCE_VMA_ASID = 0x7, > + SBI_EXT_0_1_SHUTDOWN = 0x8, > + SBI_EXT_BASE = 0x10, > +}; > > -#define SBI_CALL(which, arg0, arg1, arg2, arg3) ({ \ > - register uintptr_t a0 asm ("a0") = (uintptr_t)(arg0); \ > - register uintptr_t a1 asm ("a1") = (uintptr_t)(arg1); \ > - register uintptr_t a2 asm ("a2") = (uintptr_t)(arg2); \ > - register uintptr_t a3 asm ("a3") = (uintptr_t)(arg3); \ > - register uintptr_t a7 asm ("a7") = (uintptr_t)(which); \ > - asm volatile ("ecall" \ > - : "+r" (a0) \ > - : "r" (a1), "r" (a2), "r" (a3), "r" (a7) \ > - : "memory"); \ > - a0; \ > -}) > +enum sbi_ext_base_fid { > + SBI_EXT_BASE_GET_SPEC_VERSION = 0, > + SBI_EXT_BASE_GET_IMP_ID, > + SBI_EXT_BASE_GET_IMP_VERSION, > + SBI_EXT_BASE_PROBE_EXT, > + SBI_EXT_BASE_GET_MVENDORID, > + SBI_EXT_BASE_GET_MARCHID, > + SBI_EXT_BASE_GET_MIMPID, > +}; > > -/* Lazy implementations until SBI is finalized */ > -#define SBI_CALL_0(which) SBI_CALL(which, 0, 0, 0, 0) > -#define SBI_CALL_1(which, arg0) SBI_CALL(which, arg0, 0, 0, 0) > -#define SBI_CALL_2(which, arg0, arg1) SBI_CALL(which, arg0, arg1, 0, 0) > -#define SBI_CALL_3(which, arg0, arg1, arg2) \ > - SBI_CALL(which, arg0, arg1, arg2, 0) > -#define SBI_CALL_4(which, arg0, arg1, arg2, arg3) \ > - SBI_CALL(which, arg0, arg1, arg2, arg3) > +#define SBI_SPEC_VERSION_DEFAULT 0x1 > +#define SBI_SPEC_VERSION_MAJOR_SHIFT 24 > +#define SBI_SPEC_VERSION_MAJOR_MASK 0x7f > +#define SBI_SPEC_VERSION_MINOR_MASK 0xffffff > > -static inline void sbi_console_putchar(int ch) > -{ > - SBI_CALL_1(SBI_EXT_0_1_CONSOLE_PUTCHAR, ch); > -} > +/* SBI return error codes */ > +#define SBI_SUCCESS 0 > +#define SBI_ERR_FAILURE -1 > +#define SBI_ERR_NOT_SUPPORTED -2 > +#define SBI_ERR_INVALID_PARAM -3 nits: should use tab before -3 > +#define SBI_ERR_DENIED -4 > +#define SBI_ERR_INVALID_ADDRESS -5 nits: should use tab before -5 > > -static inline int sbi_console_getchar(void) > -{ > - return SBI_CALL_0(SBI_EXT_0_1_CONSOLE_GETCHAR); > -} > +extern unsigned long sbi_spec_version; > +struct sbiret { > + long error; > + long value; > +}; > > -static inline void sbi_set_timer(uint64_t stime_value) > -{ > -#if __riscv_xlen == 32 > - SBI_CALL_2(SBI_EXT_0_1_SET_TIMER, stime_value, > - stime_value >> 32); > -#else > - SBI_CALL_1(SBI_EXT_0_1_SET_TIMER, stime_value); > -#endif > -} > - > -static inline void sbi_shutdown(void) > -{ > - SBI_CALL_0(SBI_EXT_0_1_SHUTDOWN); > -} > +int sbi_init(void); > +struct sbiret sbi_ecall(int ext, int fid, unsigned long arg0, > + unsigned long arg1, unsigned long arg2, > + unsigned long arg3, unsigned long arg4, > + unsigned long arg5); > > -static inline void sbi_clear_ipi(void) > -{ > - SBI_CALL_0(SBI_EXT_0_1_CLEAR_IPI); > -} > +void sbi_console_putchar(int ch); > +int sbi_console_getchar(void); > +void sbi_set_timer(uint64_t stime_value); > +void sbi_shutdown(void); > +void sbi_clear_ipi(void); > +void sbi_send_ipi(const unsigned long *hart_mask); > +void sbi_remote_fence_i(const unsigned long *hart_mask); > +void sbi_remote_sfence_vma(const unsigned long *hart_mask, > + unsigned long start, > + unsigned long size); > > -static inline void sbi_send_ipi(const unsigned long *hart_mask) > -{ > - SBI_CALL_1(SBI_EXT_0_1_SEND_IPI, hart_mask); > -} > +void sbi_remote_sfence_vma_asid(const unsigned long *hart_mask, > + unsigned long start, > + unsigned long size, > + unsigned long asid); > +int sbi_probe_extension(int ext); > > -static inline void sbi_remote_fence_i(const unsigned long *hart_mask) > +/* Check if current SBI specification version is 0.1 or not */ > +static inline int sbi_spec_is_0_1(void) > { > - SBI_CALL_1(SBI_EXT_0_1_REMOTE_FENCE_I, hart_mask); > + return (sbi_spec_version == SBI_SPEC_VERSION_DEFAULT) ? 1 : 0; > } > > -static inline void sbi_remote_sfence_vma(const unsigned long *hart_mask, > - unsigned long start, > - unsigned long size) > +/* Get the major version of SBI */ > +static inline unsigned long sbi_major_version(void) > { > - SBI_CALL_3(SBI_EXT_0_1_REMOTE_SFENCE_VMA, hart_mask, > - start, size); > + return (sbi_spec_version >> SBI_SPEC_VERSION_MAJOR_SHIFT) & > + SBI_SPEC_VERSION_MAJOR_MASK; > } > > -static inline void sbi_remote_sfence_vma_asid(const unsigned long *hart_mask, > - unsigned long start, > - unsigned long size, > - unsigned long asid) > +/* Get the minor version of SBI */ > +static inline unsigned long sbi_minor_version(void) > { > - SBI_CALL_4(SBI_EXT_0_1_REMOTE_SFENCE_VMA_ASID, hart_mask, > - start, size, asid); > + return sbi_spec_version & SBI_SPEC_VERSION_MINOR_MASK; > } > #else /* CONFIG_RISCV_SBI */ > /* stubs for code that is only reachable under IS_ENABLED(CONFIG_RISCV_SBI): */ > @@ -104,5 +99,6 @@ void sbi_set_timer(uint64_t stime_value); > void sbi_clear_ipi(void); > void sbi_send_ipi(const unsigned long *hart_mask); > void sbi_remote_fence_i(const unsigned long *hart_mask); > +void sbi_init(void); > #endif /* CONFIG_RISCV_SBI */ > #endif /* _ASM_RISCV_SBI_H */ > diff --git a/arch/riscv/kernel/sbi.c b/arch/riscv/kernel/sbi.c > index f6c7c3e82d28..33632e7f91da 100644 > --- a/arch/riscv/kernel/sbi.c > +++ b/arch/riscv/kernel/sbi.c > @@ -1,17 +1,256 @@ > // SPDX-License-Identifier: GPL-2.0-only > +/* > + * SBI initialilization and all extension implementation. > + * > + * Copyright (c) 2019 Western Digital Corporation or its affiliates. > + */ > > #include > #include > #include > > +/* default SBI version is 0.1 */ > +unsigned long sbi_spec_version = SBI_SPEC_VERSION_DEFAULT; > +EXPORT_SYMBOL(sbi_spec_version); > + > +struct sbiret sbi_ecall(int ext, int fid, unsigned long arg0, > + unsigned long arg1, unsigned long arg2, > + unsigned long arg3, unsigned long arg4, > + unsigned long arg5) > +{ > + struct sbiret ret; > + > + register uintptr_t a0 asm ("a0") = (uintptr_t)(arg0); > + register uintptr_t a1 asm ("a1") = (uintptr_t)(arg1); > + register uintptr_t a2 asm ("a2") = (uintptr_t)(arg2); > + register uintptr_t a3 asm ("a3") = (uintptr_t)(arg3); > + register uintptr_t a4 asm ("a4") = (uintptr_t)(arg4); > + register uintptr_t a5 asm ("a5") = (uintptr_t)(arg5); > + register uintptr_t a6 asm ("a6") = (uintptr_t)(fid); > + register uintptr_t a7 asm ("a7") = (uintptr_t)(ext); > + asm volatile ("ecall" > + : "+r" (a0), "+r" (a1) > + : "r" (a2), "r" (a3), "r" (a4), "r" (a5), "r" (a6), "r" (a7) > + : "memory"); > + ret.error = a0; > + ret.value = a1; > + > + return ret; > +} > +EXPORT_SYMBOL(sbi_ecall); > + > +static int sbi_err_map_linux_errno(int err) > +{ > + switch (err) { > + case SBI_SUCCESS: > + return 0; > + case SBI_ERR_DENIED: > + return -EPERM; > + case SBI_ERR_INVALID_PARAM: > + return -EINVAL; > + case SBI_ERR_INVALID_ADDRESS: > + return -EFAULT; > + case SBI_ERR_NOT_SUPPORTED: > + case SBI_ERR_FAILURE: > + default: > + return -ENOTSUPP; > + }; > +} > + > +/** > + * sbi_console_putchar() - Writes given character to the console device. > + * @ch: The data to be written to the console. > + * > + * Return: None > + */ > +void sbi_console_putchar(int ch) > +{ > + sbi_ecall(SBI_EXT_0_1_CONSOLE_PUTCHAR, 0, ch, 0, 0, 0, 0, 0); > +} > +EXPORT_SYMBOL(sbi_console_putchar); > + > +/** > + * sbi_console_getchar() - Reads a byte from console device. > + * > + * Returns the value read from console. > + */ > +int sbi_console_getchar(void) > +{ > + struct sbiret ret; > + > + ret = sbi_ecall(SBI_EXT_0_1_CONSOLE_GETCHAR, 0, 0, 0, 0, 0, 0, 0); > + > + return ret.error; > +} > +EXPORT_SYMBOL(sbi_console_getchar); > + > +/** > + * sbi_set_timer() - Program the timer for next timer event. > + * @stime_value: The value after which next timer event should fire. > + * > + * Return: None > + */ > +void sbi_set_timer(uint64_t stime_value) > +{ > +#if __riscv_xlen == 32 > + sbi_ecall(SBI_EXT_0_1_SET_TIMER, 0, stime_value, > + stime_value >> 32, 0, 0, 0, 0); nits: leading spaces before stime_value. The alignment should match open parenthesis of previous line > +#else > + sbi_ecall(SBI_EXT_0_1_SET_TIMER, 0, stime_value, 0, 0, 0, 0, 0); > +#endif > +} > +EXPORT_SYMBOL(sbi_set_timer); > + > +/** > + * sbi_shutdown() - Remove all the harts from executing supervisor code. > + * > + * Return: None > + */ > +void sbi_shutdown(void) > +{ > + sbi_ecall(SBI_EXT_0_1_SHUTDOWN, 0, 0, 0, 0, 0, 0, 0); > +} > +EXPORT_SYMBOL(sbi_shutdown); > + > +/** > + * sbi_clear_ipi() - Clear any pending IPIs for the calling hart. > + * > + * Return: None > + */ > +void sbi_clear_ipi(void) > +{ > + sbi_ecall(SBI_EXT_0_1_CLEAR_IPI, 0, 0, 0, 0, 0, 0, 0); > +} > + > +/** > + * sbi_send_ipi() - Send an IPI to any hart. > + * @hart_mask: A cpu mask containing all the target harts. > + * > + * Return: None > + */ > +void sbi_send_ipi(const unsigned long *hart_mask) > +{ > + sbi_ecall(SBI_EXT_0_1_SEND_IPI, 0, (unsigned long)hart_mask, > + 0, 0, 0, 0, 0); nits: the alignment should match open parenthesis of previous line > +} > +EXPORT_SYMBOL(sbi_send_ipi); > + > +/** > + * sbi_remote_fence_i() - Execute FENCE.I instruction on given remote harts. > + * @hart_mask: A cpu mask containing all the target harts. > + * > + * Return: None > + */ > +void sbi_remote_fence_i(const unsigned long *hart_mask) > +{ > + sbi_ecall(SBI_EXT_0_1_REMOTE_FENCE_I, 0, (unsigned long)hart_mask, > + 0, 0, 0, 0, 0); nits: the alignment should match open parenthesis of previous line > +} > +EXPORT_SYMBOL(sbi_remote_fence_i); > + > +/** > + * sbi_remote_sfence_vma() - Execute SFENCE.VMA instructions on given remote > + * harts for the specified virtual address range. > + * @hart_mask: A cpu mask containing all the target harts. > + * @start: Start of the virtual address > + * @size: Total size of the virtual address range. > + * > + * Return: None > + */ > +void sbi_remote_sfence_vma(const unsigned long *hart_mask, > + unsigned long start, > + unsigned long size) nits: the alignment of above 2 lines should match open parenthesis of previous line > +{ > + sbi_ecall(SBI_EXT_0_1_REMOTE_SFENCE_VMA, 0, > + (unsigned long)hart_mask, start, size, 0, 0, 0); > +} > +EXPORT_SYMBOL(sbi_remote_sfence_vma); > + > +/** > + * sbi_remote_sfence_vma_asid() - Execute SFENCE.VMA instructions on given > + * remote harts for a virtual address range belonging to a specific ASID. > + * > + * @hart_mask: A cpu mask containing all the target harts. > + * @start: Start of the virtual address > + * @size: Total size of the virtual address range. > + * @asid: The value of address space identifier (ASID). > + * > + * Return: None > + */ > +void sbi_remote_sfence_vma_asid(const unsigned long *hart_mask, > + unsigned long start, > + unsigned long size, > + unsigned long asid) nits: the alignment of above 3 lines should match open parenthesis of previous line > +{ > + sbi_ecall(SBI_EXT_0_1_REMOTE_SFENCE_VMA_ASID, 0, > + (unsigned long)hart_mask, start, size, asid, 0, 0); nits: the alignment should match open parenthesis of previous line > +} > +EXPORT_SYMBOL(sbi_remote_sfence_vma_asid); > + > +/** > + * sbi_probe_extension() - Check if an SBI extension ID is supported or not. > + * @extid: The extension ID to be probed. > + * > + * Return: Extension specific nonzero value f yes, -ENOTSUPP otherwise. > + */ > +int sbi_probe_extension(int extid) > +{ > + struct sbiret ret; > + > + ret = sbi_ecall(SBI_EXT_BASE, SBI_EXT_BASE_PROBE_EXT, extid, > + 0, 0, 0, 0, 0); nits: the alignment should match open parenthesis of previous line > + if (!ret.error) > + if (ret.value) > + return ret.value; > + > + return -ENOTSUPP; > +} > +EXPORT_SYMBOL(sbi_probe_extension); > + > +static long __sbi_base_ecall(int fid) > +{ > + struct sbiret ret; > + > + ret = sbi_ecall(SBI_EXT_BASE, fid, 0, 0, 0, 0, 0, 0); > + if (!ret.error) > + return ret.value; > + else > + return sbi_err_map_linux_errno(ret.error); > +} > + > +static inline long sbi_get_spec_version(void) > +{ > + return __sbi_base_ecall(SBI_EXT_BASE_GET_SPEC_VERSION); > +} > + > +static inline long sbi_get_firmware_id(void) > +{ > + return __sbi_base_ecall(SBI_EXT_BASE_GET_IMP_ID); > +} > + > +static inline long sbi_get_firmware_version(void) > +{ > + return __sbi_base_ecall(SBI_EXT_BASE_GET_IMP_VERSION); > +} > + > static void sbi_power_off(void) > { > sbi_shutdown(); > } > > -static int __init sbi_init(void) > +int __init sbi_init(void) > { > + int ret; > + > pm_power_off = sbi_power_off; > + ret = sbi_get_spec_version(); > + if (ret > 0) > + sbi_spec_version = ret; > + > + pr_info("SBI specification v%lu.%lu detected\n", > + sbi_major_version(), sbi_minor_version()); > + if (!sbi_spec_is_0_1()) > + pr_info("SBI implementation ID=0x%lx Version=0x%lx\n", > + sbi_get_firmware_id(), sbi_get_firmware_version()); > return 0; > } > -early_initcall(sbi_init); > diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c > index 0a6d415b0a5a..582ecbed6442 100644 > --- a/arch/riscv/kernel/setup.c > +++ b/arch/riscv/kernel/setup.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -79,6 +80,10 @@ void __init setup_arch(char **cmdline_p) > kasan_init(); > #endif > > +#if IS_ENABLED(CONFIG_RISCV_SBI) > + sbi_init(); > +#endif > + > #ifdef CONFIG_SMP > setup_smp(); > #endif > -- Regards, Bin