From: Greentime Hu <greentime.hu@sifive.com>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Andreas Schwab <schwab@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>, Gt <green.hu@gmail.com>,
Anup Patel <anup@brainfault.org>,
greentime@kernel.org,
linux-riscv <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v3] riscv: make sure the cores stay looping in .Lsecondary_park
Date: Wed, 15 Jan 2020 15:06:51 +0800 [thread overview]
Message-ID: <CAHCEeh+utXxqF65rtvRJXq6cPDjCcwpAeUaiD1pSpGGMFXRT9Q@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.2001141449500.21279@viisi.sifive.com>
On Wed, Jan 15, 2020 at 6:55 AM Paul Walmsley <paul.walmsley@sifive.com> wrote:
>
> Hi Greentime,
>
> On Tue, 14 Jan 2020, Greentime Hu wrote:
>
> > I think it is because the sections are too far for bqeu to jump and
> > the config I used just small enough for it to jump so I didn't see
> > this bug. Sorry about that.
>
> No problem.
>
> > I tried this fix to boot in Unleashed board.
> >
> > #ifdef CONFIG_SMP
> > li t0, CONFIG_NR_CPUS
> > - bgeu a0, t0, .Lsecondary_park
> > + blt a0, t0, .Lgood_cores
> > + tail .Lsecondary_park
> > +.Lgood_cores:
> > #endif
>
> Looks reasonable to me. Care to update and repost the patch?
Yes, Paul. I have sent the v4 patch.
It is tested in Unleashed board.
prev parent reply other threads:[~2020-01-15 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 3:15 [PATCH v3] riscv: make sure the cores stay looping in .Lsecondary_park Greentime Hu
2020-01-09 19:27 ` Paul Walmsley
2020-01-12 18:12 ` Paul Walmsley
2020-01-14 3:48 ` Greentime Hu
2020-01-14 22:55 ` Paul Walmsley
2020-01-15 7:06 ` Greentime Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHCEeh+utXxqF65rtvRJXq6cPDjCcwpAeUaiD1pSpGGMFXRT9Q@mail.gmail.com \
--to=greentime.hu@sifive.com \
--cc=anup@brainfault.org \
--cc=green.hu@gmail.com \
--cc=greentime@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).