From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7BD2C4332B for ; Mon, 23 Mar 2020 23:57:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC8462070A for ; Mon, 23 Mar 2020 23:57:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oOY+qjfP"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="cxRClrga" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC8462070A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ix8wgcI17GVIT6csUF0tAYBE2LaGOYJ65o4zi4Z+Z6c=; b=oOY+qjfPRQznBE HL/z4RFrR1O6FRbxORrVCJAY0JbVYzQvREI1KZZ0jHTJDKq0f5cKqC/4+JpFs0TIiRDVqvuUWBMri VAWhdvKTMbt6t/Fkpi+FzQ1acGPh2bS+MpwxwLtwAJ1G3bpyG8jj1cA9qoBmKqVH63Jbm5H9d6SzQ 3xfl3hsZ8BBhZ6jQnIQBY1C7zGzEuwXhaCPsET91hzRhLzcR/pg9hMOH9K9SZITz2PBoSNPx4N19u dc2QpkpAhFldQqA6HYiIoiAnm0Wh9JGQMyno51D8drnAIEm+wp6u9n6xV5IFK7eO7y5XG3+zL9FC2 gFRAXr4Gk0+BWP/s3wIg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGWwL-0007qc-VY; Mon, 23 Mar 2020 23:57:05 +0000 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGWwB-0007cn-Qn for linux-riscv@lists.infradead.org; Mon, 23 Mar 2020 23:56:57 +0000 Received: by mail-ot1-x343.google.com with SMTP id s18so5833364otr.9 for ; Mon, 23 Mar 2020 16:56:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Ix8wgcI17GVIT6csUF0tAYBE2LaGOYJ65o4zi4Z+Z6c=; b=cxRClrgaWN/fpDic28j6dquzcmGVw+xYCBcb9evltHJpyFpceHUzfKZJMIJhOLclFx Yn2A3TP5Stbe0rKKKA/IDNeP6sQu7YUUq74s5fXrAmxwnECa9lFLzGP2bXzZ2DmVKPgL UDLguXXmIlABThiCSt5lssfGYmuDsDVHy3ovX3K/B0/plnPrQcOqebITxOQuZ/DZffwT OhGqRBkkNp3UqEPletWR4FAIHWjJFvKqYVN8qCAzkXSZ9bQ7aH/jjGGf8ucrXstsZArj gA7y7Jxp7obe4aoMrhUye9oj3Q9UqQfJGy1EH69U31823NIqpoSP5pj6ibFOe6U4weCd K+uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ix8wgcI17GVIT6csUF0tAYBE2LaGOYJ65o4zi4Z+Z6c=; b=Rbtkn3O+o87Yp7LsN5ih51cGrTbmH2UEW+m3oKITs2X0Voi24Bn6yxFFG8Dg03OlXj PsZgLGSoKjwKn+LFLiXyLHsfK60SeYx6C7xkF0x0lBXZ6YQ5PGM7FZkUbmdZwN0rgG45 bg/fBBoP+IZ8fngITrDGs9px1PHOKJvuV5H9Caw2jJ9jzzaBEaUoiQefpQuQEPpXoDQP bjhGI5pBeRfUT3nSIKGv2cvI5iGcOs0eHhlvG2ceDEDSCPoXK5QT8hCW5ssVcZqHrOup D/3zxcK2WAeQy0cQ69Fq/A6gjfanf+8RJtH3veC16qAclwFDjXNjgpDBG7wxc8M7E8Cu PU/w== X-Gm-Message-State: ANhLgQ1DgfJogCXOwtHowrmzONlCEYANFujs/liH66oBGLToK0uFltGf E+Vk14HHQabVi/QnkR5ECwlJFk4MUYa7CUra3/fugK58h6E= X-Google-Smtp-Source: ADFU+vuDPdpSQy4eIZVOQE+DA/YA6x9KuEZDOGaV/GyUNXkAFHrjBMzNKJjNEWfmfUZNmYn+XKHPMpfaDEYyQ1QtrIo= X-Received: by 2002:a05:6830:1e10:: with SMTP id s16mr4024265otr.33.1585007814217; Mon, 23 Mar 2020 16:56:54 -0700 (PDT) MIME-Version: 1.0 References: <20200318220634.32100-1-mike.kravetz@oracle.com> <20200318220634.32100-3-mike.kravetz@oracle.com> <2ca058dc-47e6-1d08-154b-77d2cbe98e34@c-s.fr> In-Reply-To: <2ca058dc-47e6-1d08-154b-77d2cbe98e34@c-s.fr> From: Mina Almasry Date: Mon, 23 Mar 2020 16:56:43 -0700 Message-ID: Subject: Re: [PATCH 2/4] hugetlbfs: move hugepagesz= parsing to arch independent code To: Christophe Leroy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200323_165655_896810_5EB4A737 X-CRM114-Status: GOOD ( 18.54 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-doc@vger.kernel.org, Catalin Marinas , Dave Hansen , Heiko Carstens , Linux-MM , Paul Mackerras , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Will Deacon , linux-s390@vger.kernel.org, Jonathan Corbet , Christian Borntraeger , Ingo Molnar , Longpeng , Albert Ou , Vasily Gorbik , Paul Walmsley , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, open list , Palmer Dabbelt , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Mar 19, 2020 at 12:04 AM Christophe Leroy wrote: > > > > Le 18/03/2020 =C3=A0 23:06, Mike Kravetz a =C3=A9crit : > > Now that architectures provide arch_hugetlb_valid_size(), parsing > > of "hugepagesz=3D" can be done in architecture independent code. > > Create a single routine to handle hugepagesz=3D parsing and remove > > all arch specific routines. We can also remove the interface > > hugetlb_bad_size() as this is no longer used outside arch independent > > code. > > > > This also provides consistent behavior of hugetlbfs command line > > options. The hugepagesz=3D option should only be specified once for > > a specific size, but some architectures allow multiple instances. > > This appears to be more of an oversight when code was added by some > > architectures to set up ALL huge pages sizes. > > > > Signed-off-by: Mike Kravetz > > --- > > arch/arm64/mm/hugetlbpage.c | 15 --------------- > > arch/powerpc/mm/hugetlbpage.c | 15 --------------- > > arch/riscv/mm/hugetlbpage.c | 16 ---------------- > > arch/s390/mm/hugetlbpage.c | 18 ------------------ > > arch/sparc/mm/init_64.c | 22 ---------------------- > > arch/x86/mm/hugetlbpage.c | 16 ---------------- > > include/linux/hugetlb.h | 1 - > > mm/hugetlb.c | 24 ++++++++++++++++++------ > > 8 files changed, 18 insertions(+), 109 deletions(-) > > > > [snip] > > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index 2f99359b93af..cd4ec07080fb 100644 > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -3149,12 +3149,6 @@ static int __init hugetlb_init(void) > > } > > subsys_initcall(hugetlb_init); > > > > -/* Should be called on processing a hugepagesz=3D... option */ > > -void __init hugetlb_bad_size(void) > > -{ > > - parsed_valid_hugepagesz =3D false; > > -} > > - > > void __init hugetlb_add_hstate(unsigned int order) > > { > > struct hstate *h; > > @@ -3224,6 +3218,24 @@ static int __init hugetlb_nrpages_setup(char *s) > > } > > __setup("hugepages=3D", hugetlb_nrpages_setup); > > > > +static int __init hugepagesz_setup(char *s) > > +{ > > + unsigned long long size; > > + char *saved_s =3D s; > > + > > + size =3D memparse(s, &s); > > You don't use s after that, so you can pass NULL instead of &s and avoid > the saved_s > +1 Acked-by: Mina Almasry