Linux-RISC-V Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] RISC-V: Load modules within relative jump range of the kernel text.
@ 2018-04-09 12:58 shea
  2018-04-22 12:53 ` shea
  0 siblings, 1 reply; 9+ messages in thread
From: shea @ 2018-04-09 12:58 UTC (permalink / raw)
  To: linux-riscv

Signed-off-by: Shea Levy <shea@shealevy.com>
---

Note that this patch worked in my old modules patchset and seems to be
working now, but my kernel boot locks up on top of
riscv-for-linus-4.17-mw0 and I don't know if it's due to this patch or
something else that's changed in the mean time.

---
 arch/riscv/include/asm/pgtable.h |  9 +++++++++
 arch/riscv/kernel/module.c       | 11 +++++++++++
 2 files changed, 20 insertions(+)

diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
index 16301966d65b..b08ded13364a 100644
--- a/arch/riscv/include/asm/pgtable.h
+++ b/arch/riscv/include/asm/pgtable.h
@@ -25,6 +25,7 @@
 #include <asm/page.h>
 #include <asm/tlbflush.h>
 #include <linux/mm_types.h>
+#include <linux/sizes.h>
 
 #ifdef CONFIG_64BIT
 #include <asm/pgtable-64.h>
@@ -425,6 +426,14 @@ static inline void pgtable_cache_init(void)
 #define TASK_SIZE VMALLOC_START
 #endif
 
+/*
+ * The module space lives between the addresses given by TASK_SIZE
+ * and PAGE_OFFSET - it must be within 2G of the kernel text.
+ */
+#define MODULES_SIZE		(SZ_128M)
+#define MODULES_VADDR		(PAGE_OFFSET - MODULES_SIZE)
+#define MODULES_END		(VMALLOC_END)
+
 #include <asm-generic/pgtable.h>
 
 #endif /* !__ASSEMBLY__ */
diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c
index 5dddba301d0a..1b382c7de095 100644
--- a/arch/riscv/kernel/module.c
+++ b/arch/riscv/kernel/module.c
@@ -16,6 +16,8 @@
 #include <linux/err.h>
 #include <linux/errno.h>
 #include <linux/moduleloader.h>
+#include <linux/vmalloc.h>
+#include <asm/pgtable.h>
 
 static int apply_r_riscv_64_rela(struct module *me, u32 *location, Elf_Addr v)
 {
@@ -382,3 +384,12 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab,
 
 	return 0;
 }
+
+void *module_alloc(unsigned long size)
+{
+	return __vmalloc_node_range(size, 1, MODULES_VADDR,
+				    MODULES_END, GFP_KERNEL,
+				    PAGE_KERNEL_EXEC, 0,
+				    NUMA_NO_NODE,
+				    __builtin_return_address(0));
+}
-- 
2.16.2

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] RISC-V: Load modules within relative jump range of the kernel text.
  2018-04-09 12:58 [PATCH] RISC-V: Load modules within relative jump range of the kernel text shea
@ 2018-04-22 12:53 ` shea
  2018-04-23 22:08   ` palmer
  0 siblings, 1 reply; 9+ messages in thread
From: shea @ 2018-04-22 12:53 UTC (permalink / raw)
  To: linux-riscv

Hi Palmer,

Shea Levy <shea@shealevy.com> writes:

> Signed-off-by: Shea Levy <shea@shealevy.com>
> ---
>
> Note that this patch worked in my old modules patchset and seems to be
> working now, but my kernel boot locks up on top of
> riscv-for-linus-4.17-mw0 and I don't know if it's due to this patch or
> something else that's changed in the mean time.
>
> ---
>  arch/riscv/include/asm/pgtable.h |  9 +++++++++
>  arch/riscv/kernel/module.c       | 11 +++++++++++
>  2 files changed, 20 insertions(+)
>
> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
> index 16301966d65b..b08ded13364a 100644
> --- a/arch/riscv/include/asm/pgtable.h
> +++ b/arch/riscv/include/asm/pgtable.h
> @@ -25,6 +25,7 @@
>  #include <asm/page.h>
>  #include <asm/tlbflush.h>
>  #include <linux/mm_types.h>
> +#include <linux/sizes.h>
>  
>  #ifdef CONFIG_64BIT
>  #include <asm/pgtable-64.h>
> @@ -425,6 +426,14 @@ static inline void pgtable_cache_init(void)
>  #define TASK_SIZE VMALLOC_START
>  #endif
>  
> +/*
> + * The module space lives between the addresses given by TASK_SIZE
> + * and PAGE_OFFSET - it must be within 2G of the kernel text.
> + */
> +#define MODULES_SIZE		(SZ_128M)
> +#define MODULES_VADDR		(PAGE_OFFSET - MODULES_SIZE)
> +#define MODULES_END		(VMALLOC_END)
> +
>  #include <asm-generic/pgtable.h>
>  
>  #endif /* !__ASSEMBLY__ */
> diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c
> index 5dddba301d0a..1b382c7de095 100644
> --- a/arch/riscv/kernel/module.c
> +++ b/arch/riscv/kernel/module.c
> @@ -16,6 +16,8 @@
>  #include <linux/err.h>
>  #include <linux/errno.h>
>  #include <linux/moduleloader.h>
> +#include <linux/vmalloc.h>
> +#include <asm/pgtable.h>
>  
>  static int apply_r_riscv_64_rela(struct module *me, u32 *location, Elf_Addr v)
>  {
> @@ -382,3 +384,12 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab,
>  
>  	return 0;
>  }
> +
> +void *module_alloc(unsigned long size)
> +{
> +	return __vmalloc_node_range(size, 1, MODULES_VADDR,
> +				    MODULES_END, GFP_KERNEL,
> +				    PAGE_KERNEL_EXEC, 0,
> +				    NUMA_NO_NODE,
> +				    __builtin_return_address(0));
> +}
> -- 
> 2.16.2

Any thoughts on this?

Thanks,
Shea
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20180422/40ad4641/attachment.sig>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] RISC-V: Load modules within relative jump range of the kernel text.
  2018-04-22 12:53 ` shea
@ 2018-04-23 22:08   ` palmer
  2018-04-24 11:54     ` shea
  0 siblings, 1 reply; 9+ messages in thread
From: palmer @ 2018-04-23 22:08 UTC (permalink / raw)
  To: linux-riscv

On Sun, 22 Apr 2018 05:53:56 PDT (-0700), shea at shealevy.com wrote:
> Hi Palmer,
>
> Shea Levy <shea@shealevy.com> writes:
>
>> Signed-off-by: Shea Levy <shea@shealevy.com>
>> ---
>>
>> Note that this patch worked in my old modules patchset and seems to be
>> working now, but my kernel boot locks up on top of
>> riscv-for-linus-4.17-mw0 and I don't know if it's due to this patch or
>> something else that's changed in the mean time.
>>
>> ---
>>  arch/riscv/include/asm/pgtable.h |  9 +++++++++
>>  arch/riscv/kernel/module.c       | 11 +++++++++++
>>  2 files changed, 20 insertions(+)
>>
>> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
>> index 16301966d65b..b08ded13364a 100644
>> --- a/arch/riscv/include/asm/pgtable.h
>> +++ b/arch/riscv/include/asm/pgtable.h
>> @@ -25,6 +25,7 @@
>>  #include <asm/page.h>
>>  #include <asm/tlbflush.h>
>>  #include <linux/mm_types.h>
>> +#include <linux/sizes.h>
>>  
>>  #ifdef CONFIG_64BIT
>>  #include <asm/pgtable-64.h>
>> @@ -425,6 +426,14 @@ static inline void pgtable_cache_init(void)
>>  #define TASK_SIZE VMALLOC_START
>>  #endif
>>  
>> +/*
>> + * The module space lives between the addresses given by TASK_SIZE
>> + * and PAGE_OFFSET - it must be within 2G of the kernel text.
>> + */
>> +#define MODULES_SIZE		(SZ_128M)
>> +#define MODULES_VADDR		(PAGE_OFFSET - MODULES_SIZE)
>> +#define MODULES_END		(VMALLOC_END)
>> +
>>  #include <asm-generic/pgtable.h>
>>  
>>  #endif /* !__ASSEMBLY__ */
>> diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c
>> index 5dddba301d0a..1b382c7de095 100644
>> --- a/arch/riscv/kernel/module.c
>> +++ b/arch/riscv/kernel/module.c
>> @@ -16,6 +16,8 @@
>>  #include <linux/err.h>
>>  #include <linux/errno.h>
>>  #include <linux/moduleloader.h>
>> +#include <linux/vmalloc.h>
>> +#include <asm/pgtable.h>
>>  
>>  static int apply_r_riscv_64_rela(struct module *me, u32 *location, Elf_Addr v)
>>  {
>> @@ -382,3 +384,12 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab,
>>  
>>  	return 0;
>>  }
>> +
>> +void *module_alloc(unsigned long size)
>> +{
>> +	return __vmalloc_node_range(size, 1, MODULES_VADDR,
>> +				    MODULES_END, GFP_KERNEL,
>> +				    PAGE_KERNEL_EXEC, 0,
>> +				    NUMA_NO_NODE,
>> +				    __builtin_return_address(0));
>> +}
>> -- 
>> 2.16.2
>
> Any thoughts on this?

The concept looks good, but does this actually keep the modules within 2GiB of 
the text if PAGE_OFFSET is large?

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] RISC-V: Load modules within relative jump range of the kernel text.
  2018-04-23 22:08   ` palmer
@ 2018-04-24 11:54     ` shea
  2018-05-09 11:20       ` shea
  0 siblings, 1 reply; 9+ messages in thread
From: shea @ 2018-04-24 11:54 UTC (permalink / raw)
  To: linux-riscv

Hi Palmer,

Palmer Dabbelt <palmer@sifive.com> writes:

> On Sun, 22 Apr 2018 05:53:56 PDT (-0700), shea at shealevy.com wrote:
>> Hi Palmer,
>>
>> Shea Levy <shea@shealevy.com> writes:
>>
>>> Signed-off-by: Shea Levy <shea@shealevy.com>
>>> ---
>>>
>>> Note that this patch worked in my old modules patchset and seems to be
>>> working now, but my kernel boot locks up on top of
>>> riscv-for-linus-4.17-mw0 and I don't know if it's due to this patch or
>>> something else that's changed in the mean time.
>>>
>>> ---
>>>  arch/riscv/include/asm/pgtable.h |  9 +++++++++
>>>  arch/riscv/kernel/module.c       | 11 +++++++++++
>>>  2 files changed, 20 insertions(+)
>>>
>>> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
>>> index 16301966d65b..b08ded13364a 100644
>>> --- a/arch/riscv/include/asm/pgtable.h
>>> +++ b/arch/riscv/include/asm/pgtable.h
>>> @@ -25,6 +25,7 @@
>>>  #include <asm/page.h>
>>>  #include <asm/tlbflush.h>
>>>  #include <linux/mm_types.h>
>>> +#include <linux/sizes.h>
>>>  
>>>  #ifdef CONFIG_64BIT
>>>  #include <asm/pgtable-64.h>
>>> @@ -425,6 +426,14 @@ static inline void pgtable_cache_init(void)
>>>  #define TASK_SIZE VMALLOC_START
>>>  #endif
>>>  
>>> +/*
>>> + * The module space lives between the addresses given by TASK_SIZE
>>> + * and PAGE_OFFSET - it must be within 2G of the kernel text.
>>> + */
>>> +#define MODULES_SIZE		(SZ_128M)
>>> +#define MODULES_VADDR		(PAGE_OFFSET - MODULES_SIZE)
>>> +#define MODULES_END		(VMALLOC_END)
>>> +
>>>  #include <asm-generic/pgtable.h>
>>>  
>>>  #endif /* !__ASSEMBLY__ */
>>> diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c
>>> index 5dddba301d0a..1b382c7de095 100644
>>> --- a/arch/riscv/kernel/module.c
>>> +++ b/arch/riscv/kernel/module.c
>>> @@ -16,6 +16,8 @@
>>>  #include <linux/err.h>
>>>  #include <linux/errno.h>
>>>  #include <linux/moduleloader.h>
>>> +#include <linux/vmalloc.h>
>>> +#include <asm/pgtable.h>
>>>  
>>>  static int apply_r_riscv_64_rela(struct module *me, u32 *location, Elf_Addr v)
>>>  {
>>> @@ -382,3 +384,12 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab,
>>>  
>>>  	return 0;
>>>  }
>>> +
>>> +void *module_alloc(unsigned long size)
>>> +{
>>> +	return __vmalloc_node_range(size, 1, MODULES_VADDR,
>>> +				    MODULES_END, GFP_KERNEL,
>>> +				    PAGE_KERNEL_EXEC, 0,
>>> +				    NUMA_NO_NODE,
>>> +				    __builtin_return_address(0));
>>> +}
>>> -- 
>>> 2.16.2
>>
>> Any thoughts on this?
>
> The concept looks good, but does this actually keep the modules within 2GiB of 
> the text if PAGE_OFFSET is large?

It's been some time since I wrote this, but I thought PAGE_OFFSET was
where the kernel text *started*? So unless the text itself is bigger
than 2G - 128 M, in which case we're SOL anyway, it seems like this
should work. Is there something better we can do, without a large memory
model?

Thanks,
Shea
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20180424/a609d868/attachment.sig>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] RISC-V: Load modules within relative jump range of the kernel text.
  2018-04-24 11:54     ` shea
@ 2018-05-09 11:20       ` shea
  2019-11-26 13:14         ` Björn Töpel
  0 siblings, 1 reply; 9+ messages in thread
From: shea @ 2018-05-09 11:20 UTC (permalink / raw)
  To: linux-riscv

Hi Palmer,

Shea Levy <shea@shealevy.com> writes:

> Hi Palmer,
>
> Palmer Dabbelt <palmer@sifive.com> writes:
>
>> On Sun, 22 Apr 2018 05:53:56 PDT (-0700), shea at shealevy.com wrote:
>>> Hi Palmer,
>>>
>>> Shea Levy <shea@shealevy.com> writes:
>>>
>>>> Signed-off-by: Shea Levy <shea@shealevy.com>
>>>> ---
>>>>
>>>> Note that this patch worked in my old modules patchset and seems to be
>>>> working now, but my kernel boot locks up on top of
>>>> riscv-for-linus-4.17-mw0 and I don't know if it's due to this patch or
>>>> something else that's changed in the mean time.
>>>>
>>>> ---
>>>>  arch/riscv/include/asm/pgtable.h |  9 +++++++++
>>>>  arch/riscv/kernel/module.c       | 11 +++++++++++
>>>>  2 files changed, 20 insertions(+)
>>>>
>>>> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
>>>> index 16301966d65b..b08ded13364a 100644
>>>> --- a/arch/riscv/include/asm/pgtable.h
>>>> +++ b/arch/riscv/include/asm/pgtable.h
>>>> @@ -25,6 +25,7 @@
>>>>  #include <asm/page.h>
>>>>  #include <asm/tlbflush.h>
>>>>  #include <linux/mm_types.h>
>>>> +#include <linux/sizes.h>
>>>>  
>>>>  #ifdef CONFIG_64BIT
>>>>  #include <asm/pgtable-64.h>
>>>> @@ -425,6 +426,14 @@ static inline void pgtable_cache_init(void)
>>>>  #define TASK_SIZE VMALLOC_START
>>>>  #endif
>>>>  
>>>> +/*
>>>> + * The module space lives between the addresses given by TASK_SIZE
>>>> + * and PAGE_OFFSET - it must be within 2G of the kernel text.
>>>> + */
>>>> +#define MODULES_SIZE		(SZ_128M)
>>>> +#define MODULES_VADDR		(PAGE_OFFSET - MODULES_SIZE)
>>>> +#define MODULES_END		(VMALLOC_END)
>>>> +
>>>>  #include <asm-generic/pgtable.h>
>>>>  
>>>>  #endif /* !__ASSEMBLY__ */
>>>> diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c
>>>> index 5dddba301d0a..1b382c7de095 100644
>>>> --- a/arch/riscv/kernel/module.c
>>>> +++ b/arch/riscv/kernel/module.c
>>>> @@ -16,6 +16,8 @@
>>>>  #include <linux/err.h>
>>>>  #include <linux/errno.h>
>>>>  #include <linux/moduleloader.h>
>>>> +#include <linux/vmalloc.h>
>>>> +#include <asm/pgtable.h>
>>>>  
>>>>  static int apply_r_riscv_64_rela(struct module *me, u32 *location, Elf_Addr v)
>>>>  {
>>>> @@ -382,3 +384,12 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab,
>>>>  
>>>>  	return 0;
>>>>  }
>>>> +
>>>> +void *module_alloc(unsigned long size)
>>>> +{
>>>> +	return __vmalloc_node_range(size, 1, MODULES_VADDR,
>>>> +				    MODULES_END, GFP_KERNEL,
>>>> +				    PAGE_KERNEL_EXEC, 0,
>>>> +				    NUMA_NO_NODE,
>>>> +				    __builtin_return_address(0));
>>>> +}
>>>> -- 
>>>> 2.16.2
>>>
>>> Any thoughts on this?
>>
>> The concept looks good, but does this actually keep the modules within 2GiB of 
>> the text if PAGE_OFFSET is large?
>
> It's been some time since I wrote this, but I thought PAGE_OFFSET was
> where the kernel text *started*? So unless the text itself is bigger
> than 2G - 128 M, in which case we're SOL anyway, it seems like this
> should work. Is there something better we can do, without a large memory
> model?
>
> Thanks,
> Shea

Any further thoughts on this?

Thanks,
Shea
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20180509/1a390a03/attachment.sig>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] RISC-V: Load modules within relative jump range of the kernel text.
  2018-05-09 11:20       ` shea
@ 2019-11-26 13:14         ` Björn Töpel
  2019-11-26 13:25           ` Shea Levy
  0 siblings, 1 reply; 9+ messages in thread
From: Björn Töpel @ 2019-11-26 13:14 UTC (permalink / raw)
  To: Shea Levy
  Cc: Netdev, LKML, Palmer Dabbelt, albert, Paul Walmsley, linux-riscv

On Wed, 9 May 2018 at 13:22, Shea Levy <shea@shealevy.com> wrote:
>
> Hi Palmer,
>
> Shea Levy <shea@shealevy.com> writes:
>
> > Hi Palmer,
> >
> > Palmer Dabbelt <palmer@sifive.com> writes:
> >
> >> On Sun, 22 Apr 2018 05:53:56 PDT (-0700), shea@shealevy.com wrote:
> >>> Hi Palmer,
> >>>
> >>> Shea Levy <shea@shealevy.com> writes:
> >>>
> >>>> Signed-off-by: Shea Levy <shea@shealevy.com>
> >>>> ---
> >>>>
> >>>> Note that this patch worked in my old modules patchset and seems to be
> >>>> working now, but my kernel boot locks up on top of
> >>>> riscv-for-linus-4.17-mw0 and I don't know if it's due to this patch or
> >>>> something else that's changed in the mean time.
> >>>>
> >>>> ---
> >>>>  arch/riscv/include/asm/pgtable.h |  9 +++++++++
> >>>>  arch/riscv/kernel/module.c       | 11 +++++++++++
> >>>>  2 files changed, 20 insertions(+)
> >>>>
> >>>> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
> >>>> index 16301966d65b..b08ded13364a 100644
> >>>> --- a/arch/riscv/include/asm/pgtable.h
> >>>> +++ b/arch/riscv/include/asm/pgtable.h
> >>>> @@ -25,6 +25,7 @@
> >>>>  #include <asm/page.h>
> >>>>  #include <asm/tlbflush.h>
> >>>>  #include <linux/mm_types.h>
> >>>> +#include <linux/sizes.h>
> >>>>
> >>>>  #ifdef CONFIG_64BIT
> >>>>  #include <asm/pgtable-64.h>
> >>>> @@ -425,6 +426,14 @@ static inline void pgtable_cache_init(void)
> >>>>  #define TASK_SIZE VMALLOC_START
> >>>>  #endif
> >>>>
> >>>> +/*
> >>>> + * The module space lives between the addresses given by TASK_SIZE
> >>>> + * and PAGE_OFFSET - it must be within 2G of the kernel text.
> >>>> + */
> >>>> +#define MODULES_SIZE              (SZ_128M)
> >>>> +#define MODULES_VADDR             (PAGE_OFFSET - MODULES_SIZE)
> >>>> +#define MODULES_END               (VMALLOC_END)
> >>>> +
> >>>>  #include <asm-generic/pgtable.h>
> >>>>
> >>>>  #endif /* !__ASSEMBLY__ */
> >>>> diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c
> >>>> index 5dddba301d0a..1b382c7de095 100644
> >>>> --- a/arch/riscv/kernel/module.c
> >>>> +++ b/arch/riscv/kernel/module.c
> >>>> @@ -16,6 +16,8 @@
> >>>>  #include <linux/err.h>
> >>>>  #include <linux/errno.h>
> >>>>  #include <linux/moduleloader.h>
> >>>> +#include <linux/vmalloc.h>
> >>>> +#include <asm/pgtable.h>
> >>>>
> >>>>  static int apply_r_riscv_64_rela(struct module *me, u32 *location, Elf_Addr v)
> >>>>  {
> >>>> @@ -382,3 +384,12 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab,
> >>>>
> >>>>    return 0;
> >>>>  }
> >>>> +
> >>>> +void *module_alloc(unsigned long size)
> >>>> +{
> >>>> +  return __vmalloc_node_range(size, 1, MODULES_VADDR,
> >>>> +                              MODULES_END, GFP_KERNEL,
> >>>> +                              PAGE_KERNEL_EXEC, 0,
> >>>> +                              NUMA_NO_NODE,
> >>>> +                              __builtin_return_address(0));
> >>>> +}
> >>>> --
> >>>> 2.16.2
> >>>
> >>> Any thoughts on this?
> >>
> >> The concept looks good, but does this actually keep the modules within 2GiB of
> >> the text if PAGE_OFFSET is large?
> >
> > It's been some time since I wrote this, but I thought PAGE_OFFSET was
> > where the kernel text *started*? So unless the text itself is bigger
> > than 2G - 128 M, in which case we're SOL anyway, it seems like this
> > should work. Is there something better we can do, without a large memory
> > model?
> >
> > Thanks,
> > Shea
>
> Any further thoughts on this?
>
> Thanks,
> Shea

Shea,

Waking up the dead (threads)!

I'm hacking on call improvements for the RISC-V BPF JIT.
module_alloc() is used under the hood of bpf_jit_binary_alloc(), which
in turn is used to allocate the JIT image. The current JIT
implementation has to to "load imm64 + jalr" to call kernel syms,
since the relative offset is >32b. With your patch, I can use regular
jal/auipc+jalr instead. IOW, it would be great if it could be merged.
;-) I'd prefer not having the patch in my BPF JIT series, since that
will go through a different tree than Paul's RV one.

Wdyt about brushing of the dust of the patch, and re-send it?


Thanks!
Björn

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] RISC-V: Load modules within relative jump range of the kernel text.
  2019-11-26 13:14         ` Björn Töpel
@ 2019-11-26 13:25           ` Shea Levy
  2019-11-26 16:43             ` Björn Töpel
  0 siblings, 1 reply; 9+ messages in thread
From: Shea Levy @ 2019-11-26 13:25 UTC (permalink / raw)
  To: Björn Töpel
  Cc: Netdev, LKML, Palmer Dabbelt, albert, Paul Walmsley, linux-riscv

[-- Attachment #1.1: Type: text/plain, Size: 4652 bytes --]

Hi Björn,

Unfortunately I'm not sure what more is needed to get this in, and I'm
in the middle of a move and won't have easy access to my RISC-V setup
for testing. I don't think you can count on me for this one.

Thanks,
Shea

Björn Töpel <bjorn.topel@gmail.com> writes:

> On Wed, 9 May 2018 at 13:22, Shea Levy <shea@shealevy.com> wrote:
>>
>> Hi Palmer,
>>
>> Shea Levy <shea@shealevy.com> writes:
>>
>> > Hi Palmer,
>> >
>> > Palmer Dabbelt <palmer@sifive.com> writes:
>> >
>> >> On Sun, 22 Apr 2018 05:53:56 PDT (-0700), shea@shealevy.com wrote:
>> >>> Hi Palmer,
>> >>>
>> >>> Shea Levy <shea@shealevy.com> writes:
>> >>>
>> >>>> Signed-off-by: Shea Levy <shea@shealevy.com>
>> >>>> ---
>> >>>>
>> >>>> Note that this patch worked in my old modules patchset and seems to be
>> >>>> working now, but my kernel boot locks up on top of
>> >>>> riscv-for-linus-4.17-mw0 and I don't know if it's due to this patch or
>> >>>> something else that's changed in the mean time.
>> >>>>
>> >>>> ---
>> >>>>  arch/riscv/include/asm/pgtable.h |  9 +++++++++
>> >>>>  arch/riscv/kernel/module.c       | 11 +++++++++++
>> >>>>  2 files changed, 20 insertions(+)
>> >>>>
>> >>>> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
>> >>>> index 16301966d65b..b08ded13364a 100644
>> >>>> --- a/arch/riscv/include/asm/pgtable.h
>> >>>> +++ b/arch/riscv/include/asm/pgtable.h
>> >>>> @@ -25,6 +25,7 @@
>> >>>>  #include <asm/page.h>
>> >>>>  #include <asm/tlbflush.h>
>> >>>>  #include <linux/mm_types.h>
>> >>>> +#include <linux/sizes.h>
>> >>>>
>> >>>>  #ifdef CONFIG_64BIT
>> >>>>  #include <asm/pgtable-64.h>
>> >>>> @@ -425,6 +426,14 @@ static inline void pgtable_cache_init(void)
>> >>>>  #define TASK_SIZE VMALLOC_START
>> >>>>  #endif
>> >>>>
>> >>>> +/*
>> >>>> + * The module space lives between the addresses given by TASK_SIZE
>> >>>> + * and PAGE_OFFSET - it must be within 2G of the kernel text.
>> >>>> + */
>> >>>> +#define MODULES_SIZE              (SZ_128M)
>> >>>> +#define MODULES_VADDR             (PAGE_OFFSET - MODULES_SIZE)
>> >>>> +#define MODULES_END               (VMALLOC_END)
>> >>>> +
>> >>>>  #include <asm-generic/pgtable.h>
>> >>>>
>> >>>>  #endif /* !__ASSEMBLY__ */
>> >>>> diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c
>> >>>> index 5dddba301d0a..1b382c7de095 100644
>> >>>> --- a/arch/riscv/kernel/module.c
>> >>>> +++ b/arch/riscv/kernel/module.c
>> >>>> @@ -16,6 +16,8 @@
>> >>>>  #include <linux/err.h>
>> >>>>  #include <linux/errno.h>
>> >>>>  #include <linux/moduleloader.h>
>> >>>> +#include <linux/vmalloc.h>
>> >>>> +#include <asm/pgtable.h>
>> >>>>
>> >>>>  static int apply_r_riscv_64_rela(struct module *me, u32 *location, Elf_Addr v)
>> >>>>  {
>> >>>> @@ -382,3 +384,12 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab,
>> >>>>
>> >>>>    return 0;
>> >>>>  }
>> >>>> +
>> >>>> +void *module_alloc(unsigned long size)
>> >>>> +{
>> >>>> +  return __vmalloc_node_range(size, 1, MODULES_VADDR,
>> >>>> +                              MODULES_END, GFP_KERNEL,
>> >>>> +                              PAGE_KERNEL_EXEC, 0,
>> >>>> +                              NUMA_NO_NODE,
>> >>>> +                              __builtin_return_address(0));
>> >>>> +}
>> >>>> --
>> >>>> 2.16.2
>> >>>
>> >>> Any thoughts on this?
>> >>
>> >> The concept looks good, but does this actually keep the modules within 2GiB of
>> >> the text if PAGE_OFFSET is large?
>> >
>> > It's been some time since I wrote this, but I thought PAGE_OFFSET was
>> > where the kernel text *started*? So unless the text itself is bigger
>> > than 2G - 128 M, in which case we're SOL anyway, it seems like this
>> > should work. Is there something better we can do, without a large memory
>> > model?
>> >
>> > Thanks,
>> > Shea
>>
>> Any further thoughts on this?
>>
>> Thanks,
>> Shea
>
> Shea,
>
> Waking up the dead (threads)!
>
> I'm hacking on call improvements for the RISC-V BPF JIT.
> module_alloc() is used under the hood of bpf_jit_binary_alloc(), which
> in turn is used to allocate the JIT image. The current JIT
> implementation has to to "load imm64 + jalr" to call kernel syms,
> since the relative offset is >32b. With your patch, I can use regular
> jal/auipc+jalr instead. IOW, it would be great if it could be merged.
> ;-) I'd prefer not having the patch in my BPF JIT series, since that
> will go through a different tree than Paul's RV one.
>
> Wdyt about brushing of the dust of the patch, and re-send it?
>
>
> Thanks!
> Björn

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] RISC-V: Load modules within relative jump range of the kernel text.
  2019-11-26 13:25           ` Shea Levy
@ 2019-11-26 16:43             ` Björn Töpel
  2019-11-26 19:26               ` Björn Töpel
  0 siblings, 1 reply; 9+ messages in thread
From: Björn Töpel @ 2019-11-26 16:43 UTC (permalink / raw)
  To: Shea Levy
  Cc: Netdev, LKML, Palmer Dabbelt, albert, Paul Walmsley, linux-riscv

On Tue, 26 Nov 2019 at 14:25, Shea Levy <shea@shealevy.com> wrote:
>
> Hi Björn,
>
> Unfortunately I'm not sure what more is needed to get this in, and I'm
> in the middle of a move and won't have easy access to my RISC-V setup
> for testing. I don't think you can count on me for this one.
>

Thanks for getting back quickly! No worries, I'll pick it up!


Cheers,
Björn

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] RISC-V: Load modules within relative jump range of the kernel text.
  2019-11-26 16:43             ` Björn Töpel
@ 2019-11-26 19:26               ` Björn Töpel
  0 siblings, 0 replies; 9+ messages in thread
From: Björn Töpel @ 2019-11-26 19:26 UTC (permalink / raw)
  To: Shea Levy
  Cc: Netdev, LKML, Palmer Dabbelt, albert, Paul Walmsley, linux-riscv

On Tue, 26 Nov 2019 at 17:43, Björn Töpel <bjorn.topel@gmail.com> wrote:
>
> On Tue, 26 Nov 2019 at 14:25, Shea Levy <shea@shealevy.com> wrote:
> >
> > Hi Björn,
> >
> > Unfortunately I'm not sure what more is needed to get this in, and I'm
> > in the middle of a move and won't have easy access to my RISC-V setup
> > for testing. I don't think you can count on me for this one.
> >
>
> Thanks for getting back quickly! No worries, I'll pick it up!
>

I just pulled in your patch in my series [1] (it's not done for
submission yet, but passes all tests); Just to get the idea. Reading
up on the thread, it looks like we can share some more between the
archs (mips).


Thanks,
Björn

[1] https://github.com/bjoto/linux/tree/rv64-bpf-jit-bcc
>
> Cheers,
> Björn

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-09 12:58 [PATCH] RISC-V: Load modules within relative jump range of the kernel text shea
2018-04-22 12:53 ` shea
2018-04-23 22:08   ` palmer
2018-04-24 11:54     ` shea
2018-05-09 11:20       ` shea
2019-11-26 13:14         ` Björn Töpel
2019-11-26 13:25           ` Shea Levy
2019-11-26 16:43             ` Björn Töpel
2019-11-26 19:26               ` Björn Töpel

Linux-RISC-V Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-riscv/0 linux-riscv/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-riscv linux-riscv/ https://lore.kernel.org/linux-riscv \
		linux-riscv@lists.infradead.org
	public-inbox-index linux-riscv

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-riscv


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git