From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47D44C43603 for ; Tue, 10 Dec 2019 05:31:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 191AA206D5 for ; Tue, 10 Dec 2019 05:31:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PXWQ3zK+"; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tQ7NTeRH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 191AA206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0i5fqFii9h3zbWBDVAysAxtbLv8smZHCpf4SOKLHP/I=; b=PXWQ3zK+I5vMdD 1K+zHJ6kU5BkrvDeM6y6NjcHgfGcttBUBxPcjqDOyLUbhWiWUQ4t/QeuTALh/hUgQUkHiBepQ4+ae NYyFuOVOmkIpuJ+1XH9ucSFFB9DymkRqByjn9ESzSxqvxKGadNc8pQjIJOpfQTflxYDJiDrW8XKis trHYOk2t+6MLUOyaeV3G6prIK8Vwq3aU3tgVdxnBv1EJcdN8fbq6rG8Dlvc8rywS7L7X3vf8ps86N zxOzE9DiI1upoPDtfB285RZa+xyeSl7iZu6TAV0BCo+txH0NV6mpJkBfprJpRjeA3AO/tWnff6koq eDbgjZ+BHaMWtdzpQPuw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieY7d-0005Us-Vl; Tue, 10 Dec 2019 05:31:45 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieY7b-0005Tw-Ht for linux-riscv@lists.infradead.org; Tue, 10 Dec 2019 05:31:44 +0000 Received: by mail-qt1-x842.google.com with SMTP id t17so1682905qtr.7 for ; Mon, 09 Dec 2019 21:31:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=0i5fqFii9h3zbWBDVAysAxtbLv8smZHCpf4SOKLHP/I=; b=tQ7NTeRHAxaLNx6IHMXSqyBmJf1gYVzude/M4QCDh2PlbjUzZWSuF/VGZ9HZuZ1qY/ zRqG2q0O57zGo8OLc0aTt6cCoy+v728+FGFWdR3q4NrKc5WjmIkVRMxG3os3wTy71PiT e55ZNE+XG6nCfbyKVpnAkgeeWKHlZNhRQ2pyspfAXPPPcwlx3Qs98vs4K8I4qosdW2Ro qXfg99EKHSV0wBEGiSKUoP68UcF8Tv322d+Fl7Bw1C8DmiHyVq1vju8tDJqkLReeaFH6 To+/5yzd/3j/0Rho77UBs+d9oMyT6eJTf2RTUyhuCIWKAECYHrVRoV5LGRzBUpHvrYq3 P/AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0i5fqFii9h3zbWBDVAysAxtbLv8smZHCpf4SOKLHP/I=; b=QjzE+hrnIzWl+WPthwJ06J6I/XxfV0fnYVYNzd8Bwlb+i3STwPAiDZVo33Qz3zl0G8 Pqt6O3MyItHmn+Rt4uVP/P0Idi9jrRL4T3Ia/5X0VYv+giIMs0/x7Mdvex1AKFnCzrnr 1gkAOeyDeNgKZCkkYP5ojune2+ti0cj4bsfBwx59cTolu4u5m0Dxb5sOQCWZE2cohkl9 NXwhntW62FmAgjv3GpVZzXviDdf4u7XEC3Qt2n12l4ZFqnwniTyGQmZPm3zr+MZzifX4 eS6nl0TaocEr+VuCm9xiSTP9Rl/wEZtTMh3mEm54naruiqCiaPBY0HYHO+xZs9f3J4Ds 1pJA== X-Gm-Message-State: APjAAAVKLAozaLTeMuAv5nvUNScaLkAPqEgx+TPWbrj5TjjcvTCh7NjM c8/YUrblrg3RGlsGjY65SHdqEa+OOWtnefR3RjBKj6et24XZIg== X-Google-Smtp-Source: APXvYqyt0Hno3XoOYazUzPfoq8HIUPXgg2qVyO9UxGrvCfIciJG9wGyISvcyjdvUm+i1pmUEpuEObOvV8wUJni1oyws= X-Received: by 2002:ac8:2310:: with SMTP id a16mr28240964qta.46.1575955899915; Mon, 09 Dec 2019 21:31:39 -0800 (PST) MIME-Version: 1.0 References: <20191209173136.29615-1-bjorn.topel@gmail.com> <20191209173136.29615-3-bjorn.topel@gmail.com> In-Reply-To: <20191209173136.29615-3-bjorn.topel@gmail.com> From: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Date: Tue, 10 Dec 2019 06:31:28 +0100 Message-ID: Subject: Re: [PATCH bpf-next 2/8] riscv, bpf: add support for far branching To: Daniel Borkmann , Alexei Starovoitov , Netdev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191209_213143_616385_A392BEE5 X-CRM114-Status: UNSURE ( 8.11 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-riscv@lists.infradead.org, bpf Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, 9 Dec 2019 at 18:31, Bj=C3=B6rn T=C3=B6pel = wrote: > > This commit adds branch relaxation to the BPF JIT, and with that > support for far (offset greater than 12b) branching. > > The branch relaxation requires more than two passes to converge. For > most programs it is three passes, but for larger programs it can be > more. > > Signed-off-by: Bj=C3=B6rn T=C3=B6pel > --- > arch/riscv/net/bpf_jit_comp.c | 352 ++++++++++++++++++---------------- [...] > +} > + > +static void emit_branch(u8 cond, u8 rd, u8 rs, int insn, int rvoff, The "insn" is not used. I'll do a respin.