From: Guo Ren <guoren@kernel.org>
To: Chen Wang <unicornxw@gmail.com>
Cc: aou@eecs.berkeley.edu, chao.wei@sophgo.com, conor@kernel.org,
krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
palmer@dabbelt.com, paul.walmsley@sifive.com,
richardcochran@gmail.com, robh+dt@kernel.org, sboyd@kernel.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
haijiao.liu@sophgo.com, xiaoguang.xing@sophgo.com,
jszhang@kernel.org, inochiama@outlook.com,
samuel.holland@sifive.com, Chen Wang <unicorn_wang@outlook.com>
Subject: Re: [PATCH v10 5/5] riscv: dts: add clock generator for Sophgo SG2042 SoC
Date: Tue, 20 Feb 2024 09:18:03 +0800 [thread overview]
Message-ID: <CAJF2gTRPU6-8Wwds=PRREjU3W0cmCpBcc=w7=J9p_y+XSd3o6w@mail.gmail.com> (raw)
In-Reply-To: <dc899c89e5c30e2267965f185b52d6dded4eb1ac.1708223519.git.unicorn_wang@outlook.com>
On Sun, Feb 18, 2024 at 10:52 AM Chen Wang <unicornxw@gmail.com> wrote:
>
> From: Chen Wang <unicorn_wang@outlook.com>
>
> Add clock generator node to device tree for SG2042, and enable clock for
> uart.
>
> Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
> ---
> .../boot/dts/sophgo/sg2042-milkv-pioneer.dts | 12 +++++
> arch/riscv/boot/dts/sophgo/sg2042.dtsi | 48 +++++++++++++++++++
> 2 files changed, 60 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts b/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts
> index 49b4b9c2c101..80cb017974d8 100644
> --- a/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts
> +++ b/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts
> @@ -14,6 +14,18 @@ chosen {
> };
> };
>
> +&cgi_main {
> + clock-frequency = <25000000>;
> +};
> +
> +&cgi_dpll0 {
> + clock-frequency = <25000000>;
> +};
> +
> +&cgi_dpll1 {
> + clock-frequency = <25000000>;
> +};
> +
If all are fixed, why do we separate them into three pieces? To show
real internal hardware?
> &uart0 {
> status = "okay";
> };
> diff --git a/arch/riscv/boot/dts/sophgo/sg2042.dtsi b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> index ead1cc35d88b..e70c43e2ccbe 100644
> --- a/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> @@ -5,6 +5,9 @@
>
> /dts-v1/;
> #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/clock/sophgo,sg2042-pll.h>
> +#include <dt-bindings/clock/sophgo,sg2042-rpgate.h>
> +#include <dt-bindings/clock/sophgo,sg2042-clkgen.h>
>
> #include "sg2042-cpus.dtsi"
>
> @@ -18,12 +21,54 @@ aliases {
> serial0 = &uart0;
> };
>
> + cgi_main: oscillator0 {
> + compatible = "fixed-clock";
> + clock-output-names = "cgi_main";
> + #clock-cells = <0>;
> + };
> +
> + cgi_dpll0: oscillator1 {
> + compatible = "fixed-clock";
> + clock-output-names = "cgi_dpll0";
> + #clock-cells = <0>;
> + };
> +
> + cgi_dpll1: oscillator2 {
> + compatible = "fixed-clock";
> + clock-output-names = "cgi_dpll1";
> + #clock-cells = <0>;
> + };
> +
> soc: soc {
> compatible = "simple-bus";
> #address-cells = <2>;
> #size-cells = <2>;
> ranges;
>
> + pllclk: clock-controller@70300100c0 {
> + compatible = "sophgo,sg2042-pll";
> + reg = <0x70 0x300100c0 0x0 0x40>;
> + clocks = <&cgi_main>, <&cgi_dpll0>, <&cgi_dpll1>;
> + #clock-cells = <1>;
> + };
> +
> + rpgate: clock-controller@7030010368 {
> + compatible = "sophgo,sg2042-rpgate";
> + reg = <0x70 0x30010368 0x0 0x98>;
> + clocks = <&clkgen GATE_CLK_RP_CPU_NORMAL>;
> + #clock-cells = <1>;
> + };
> +
> + clkgen: clock-controller@7030012000 {
> + compatible = "sophgo,sg2042-clkgen";
> + reg = <0x70 0x30012000 0x0 0x1000>;
> + clocks = <&pllclk MPLL_CLK>,
> + <&pllclk FPLL_CLK>,
> + <&pllclk DPLL0_CLK>,
> + <&pllclk DPLL1_CLK>;
> + #clock-cells = <1>;
> + };
> +
> clint_mswi: interrupt-controller@7094000000 {
> compatible = "sophgo,sg2042-aclint-mswi", "thead,c900-aclint-mswi";
> reg = <0x00000070 0x94000000 0x00000000 0x00004000>;
> @@ -333,6 +378,9 @@ uart0: serial@7040000000 {
> interrupt-parent = <&intc>;
> interrupts = <112 IRQ_TYPE_LEVEL_HIGH>;
> clock-frequency = <500000000>;
> + clocks = <&clkgen GATE_CLK_UART_500M>,
> + <&clkgen GATE_CLK_APB_UART>;
> + clock-names = "baudclk", "apb_pclk";
> reg-shift = <2>;
> reg-io-width = <4>;
> status = "disabled";
> --
> 2.25.1
>
Others LGTM.
Reviewed-by: Guo Ren <guoren@kernel.org>
--
Best Regards
Guo Ren
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-02-20 1:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 2:50 [PATCH v10 0/5] riscv: sophgo: add clock support for sg2042 Chen Wang
2024-02-18 2:50 ` [PATCH v10 1/5] dt-bindings: clock: sophgo: add pll clocks for SG2042 Chen Wang
2024-02-20 1:14 ` Guo Ren
2024-02-18 2:51 ` [PATCH v10 2/5] dt-bindings: clock: sophgo: add RP gate " Chen Wang
2024-02-18 4:37 ` Rob Herring
2024-02-18 2:51 ` [PATCH v10 3/5] dt-bindings: clock: sophgo: add clkgen " Chen Wang
2024-02-18 4:37 ` Rob Herring
2024-02-18 2:52 ` [PATCH v10 4/5] clk: sophgo: Add SG2042 clock driver Chen Wang
2024-02-18 2:52 ` [PATCH v10 5/5] riscv: dts: add clock generator for Sophgo SG2042 SoC Chen Wang
2024-02-20 1:18 ` Guo Ren [this message]
2024-02-20 1:22 ` Chen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJF2gTRPU6-8Wwds=PRREjU3W0cmCpBcc=w7=J9p_y+XSd3o6w@mail.gmail.com' \
--to=guoren@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=chao.wei@sophgo.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=haijiao.liu@sophgo.com \
--cc=inochiama@outlook.com \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=samuel.holland@sifive.com \
--cc=sboyd@kernel.org \
--cc=unicorn_wang@outlook.com \
--cc=unicornxw@gmail.com \
--cc=xiaoguang.xing@sophgo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).