From: Guo Ren <guoren@kernel.org>
To: Conor.Dooley@microchip.com
Cc: arnd@arndb.de, palmer@rivosinc.com, tglx@linutronix.de,
peterz@infradead.org, luto@kernel.org, heiko@sntech.de,
jszhang@kernel.org, lazyparser@gmail.com, falcon@tinylab.org,
chenhuacai@kernel.org, apatel@ventanamicro.com,
atishp@atishpatra.org, palmer@dabbelt.com,
paul.walmsley@sifive.com, bigeasy@linutronix.de,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, guoren@linux.alibaba.com
Subject: Re: [PATCH V3 0/7] riscv: Add GENERIC_ENTRY, irq stack support
Date: Wed, 7 Sep 2022 10:52:18 +0800 [thread overview]
Message-ID: <CAJF2gTRU6xWv5z7FvYkupCfmc0_EEceeowpjemoUWSAz8OgfWg@mail.gmail.com> (raw)
In-Reply-To: <CAJF2gTQ29bn=hgubC+YU1qSw_L3W2kAt3Yi4_EknrNCkR-dRFg@mail.gmail.com>
Hi Conor,
I've found the root cause, you are using llvm:
$ grep "bare sym" llvm -rn |grep RISCV
llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1296: return
Error(ErrorLoc, "operand must be a bare symbol name");
llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1304: return
Error(ErrorLoc, "operand must be a bare symbol name");
That means we could fix up Binutils with a warning at least.
Thx for pointing it out.
On Wed, Sep 7, 2022 at 8:54 AM Guo Ren <guoren@kernel.org> wrote:
>
> On Wed, Sep 7, 2022 at 1:42 AM <Conor.Dooley@microchip.com> wrote:
> >
> > On 06/09/2022 04:54, guoren@kernel.org wrote:
> > > From: Guo Ren <guoren@linux.alibaba.com>
> > >
> > > The patches convert riscv to use the generic entry infrastructure from
> > > kernel/entry/*. Add independent irq stacks (IRQ_STACKS) for percpu to
> > > prevent kernel stack overflows. Add the HAVE_SOFTIRQ_ON_OWN_STACK
> > > feature for the IRQ_STACKS config. You can try it directly with [1].
> >
> > Hey Guo Ren,
> > I applied this patchset to v6.0-rc4 & ran into a build error:
> > /stuff/linux/arch/riscv/kernel/entry.S:347:9: error: operand must be a bare symbol name
> > la a3, ((1 << (12)) << (2 + 0))
> Yes, please try:
> - la a3, IRQ_STACK_SIZE
> + li a3, IRQ_STACK_SIZE
>
> la is for the symbol, not immediate. But why does my toolchain not
> report the error?
>
> ➜ linux git:(generic_entry_v3) make ARCH=riscv
> CROSS_COMPILE=riscv64-unknown-linux-gnu- EXTRA_CFLAGS+=-g
> O=../build-riscv/ -kj62 all -kj
> ➜ linux git:(generic_entry_v3) riscv64-unknown-linux-gnu-gcc -v
> Using built-in specs.
> COLLECT_GCC=riscv64-unknown-linux-gnu-gcc
> COLLECT_LTO_WRAPPER=/opt/riscv/libexec/gcc/riscv64-unknown-linux-gnu/11.1.0/lto-wrapper
> Target: riscv64-unknown-linux-gnu
> Configured with:
> /home/guoren/source/riscv-gnu-toolchain/riscv-gcc/configure
> --target=riscv64-unknown-linux-gnu --prefix=/opt/riscv
> --with-sysroot=/opt/riscv/sysroot --with-pkgversion=g5964b5cd7272
> --with-system-zlib --enable-shared --enable-tls
> --enable-languages=c,c++,fortran --disable-libmudflap --disable-libssp
> --disable-libquadmath --disable-libsanitizer --disable-nls
> --disable-bootstrap --src=.././riscv-gcc --enable-multilib
> --with-abi=lp64d --with-arch=rv64imafdc --with-tune=rocket
> --with-isa-spec=2.2 'CFLAGS_FOR_TARGET=-O2 -mcmodel=medlow'
> 'CXXFLAGS_FOR_TARGET=-O2 -mcmodel=medlow'
> Thread model: posix
> Supported LTO compression algorithms: zlib
> gcc version 11.1.0 (g5964b5cd7272)
>
>
>
> > ^
> > CC arch/riscv/kernel/process.o
> > make[5]: *** [/stuff/linux/scripts/Makefile.build:322: arch/riscv/kernel/entry.o] Error 1
> > make[5]: *** Waiting for unfinished jobs....
> >
> > Thanks,
> > Conor.
> > >
> > > [1] https://github.com/guoren83/linux/tree/generic_entry_v3
> > >
> > > V3:
> > > - Fixup CONFIG_COMPAT=n compile error
> > > - Add THREAD_SIZE_ORDER config
> > > - Optimize elf_kexec.c warning fixup
> > > - Add static to irq_stack_ptr definition
> > >
> > > V2:
> > > Link: https://lore.kernel.org/linux-riscv/20220904072637.8619-1-guoren@kernel.org/
> > > - Fixup compile error by include "riscv: ptrace: Remove duplicate
> > > operation"
> > > - Fixup compile warning
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > - Add test repo link in cover letter
> > >
> > > V1:
> > > Link: https://lore.kernel.org/linux-riscv/20220903163808.1954131-1-guoren@kernel.org/
> > >
> > > Guo Ren (7):
> > > riscv: elf_kexec: Fixup compile warning
> > > riscv: compat_syscall_table: Fixup compile warning
> > > riscv: ptrace: Remove duplicate operation
> > > riscv: convert to generic entry
> > > riscv: Support HAVE_IRQ_EXIT_ON_IRQ_STACK
> > > riscv: Support HAVE_SOFTIRQ_ON_OWN_STACK
> > > riscv: Add config of thread stack size
> > >
> > > arch/riscv/Kconfig | 19 ++
> > > arch/riscv/include/asm/csr.h | 1 -
> > > arch/riscv/include/asm/entry-common.h | 8 +
> > > arch/riscv/include/asm/irq.h | 3 +
> > > arch/riscv/include/asm/ptrace.h | 10 +-
> > > arch/riscv/include/asm/stacktrace.h | 5 +
> > > arch/riscv/include/asm/syscall.h | 6 +
> > > arch/riscv/include/asm/thread_info.h | 19 +-
> > > arch/riscv/include/asm/vmap_stack.h | 28 +++
> > > arch/riscv/kernel/Makefile | 1 +
> > > arch/riscv/kernel/elf_kexec.c | 2 +-
> > > arch/riscv/kernel/entry.S | 255 +++++---------------------
> > > arch/riscv/kernel/irq.c | 75 ++++++++
> > > arch/riscv/kernel/ptrace.c | 41 -----
> > > arch/riscv/kernel/signal.c | 21 +--
> > > arch/riscv/kernel/sys_riscv.c | 27 +++
> > > arch/riscv/kernel/traps.c | 11 ++
> > > arch/riscv/mm/fault.c | 12 +-
> > > 18 files changed, 259 insertions(+), 285 deletions(-)
> > > create mode 100644 arch/riscv/include/asm/entry-common.h
> > > create mode 100644 arch/riscv/include/asm/vmap_stack.h
> > >
>
>
>
> --
> Best Regards
> Guo Ren
--
Best Regards
Guo Ren
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-09-07 2:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 3:54 [PATCH V3 0/7] riscv: Add GENERIC_ENTRY, irq stack support guoren
2022-09-06 3:54 ` [PATCH V3 1/7] riscv: elf_kexec: Fixup compile warning guoren
2022-09-06 3:54 ` [PATCH V3 2/7] riscv: compat_syscall_table: " guoren
2022-09-06 3:54 ` [PATCH V3 3/7] riscv: ptrace: Remove duplicate operation guoren
2022-09-06 3:54 ` [PATCH V3 4/7] riscv: convert to generic entry guoren
2022-09-06 9:20 ` Peter Zijlstra
2022-09-07 0:59 ` Guo Ren
2022-09-06 3:54 ` [PATCH V3 5/7] riscv: Support HAVE_IRQ_EXIT_ON_IRQ_STACK guoren
2022-09-06 3:54 ` [PATCH V3 6/7] riscv: Support HAVE_SOFTIRQ_ON_OWN_STACK guoren
2022-09-06 3:54 ` [PATCH V3 7/7] riscv: Add config of thread stack size guoren
2022-09-06 17:42 ` [PATCH V3 0/7] riscv: Add GENERIC_ENTRY, irq stack support Conor.Dooley
2022-09-07 0:54 ` Guo Ren
2022-09-07 2:52 ` Guo Ren [this message]
2022-09-07 6:23 ` Conor.Dooley
2022-09-07 7:06 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJF2gTRU6xWv5z7FvYkupCfmc0_EEceeowpjemoUWSAz8OgfWg@mail.gmail.com \
--to=guoren@kernel.org \
--cc=Conor.Dooley@microchip.com \
--cc=apatel@ventanamicro.com \
--cc=arnd@arndb.de \
--cc=atishp@atishpatra.org \
--cc=bigeasy@linutronix.de \
--cc=chenhuacai@kernel.org \
--cc=falcon@tinylab.org \
--cc=guoren@linux.alibaba.com \
--cc=heiko@sntech.de \
--cc=jszhang@kernel.org \
--cc=lazyparser@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=luto@kernel.org \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).