linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Guo Ren <guoren@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: "Patrick Stählin" <me@packi.ch>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Anders Roxell" <anders.roxell@linaro.org>,
	"David Abdurachmanov" <david.abdurachmanov@gmail.com>,
	"Zong Li" <zong.li@sifive.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Greentime Hu" <greentime.hu@sifive.com>,
	linux-riscv <linux-riscv@lists.infradead.org>
Subject: Re: [RFC/RFT 2/2] RISC-V: kprobes/kretprobe support
Date: Fri, 19 Jun 2020 00:14:14 +0800	[thread overview]
Message-ID: <CAJF2gTSEV37ZnXS_VF_OT1tmxzER98XzDswoM2fCZ4XRoq6uzg@mail.gmail.com> (raw)
In-Reply-To: <20200617235443.4110b4ef31150722dda7973a@kernel.org>

Hi Masami,

On Wed, Jun 17, 2020 at 10:54 PM Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> Hi Guo and Patrick,
>
> On Wed, 17 Jun 2020 20:58:32 +0800
> Guo Ren <guoren@kernel.org> wrote:
>
> > Hi Patrick,
> >
> > I'm the author of csky's kprobe & uprobe, please ref to kprobe [1], uprobe [2]
> >
> > 1: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/csky?h=v5.8-rc1&id=33e53ae1ce413a081254e686d9b27cc1b3585e2f
> > 2: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/csky?h=v5.8-rc1&id=8f6bb793b2be82f1f73bfb416486f156f70b4314
>
> Thanks for the porting!
>
> >
> > May I continue your patches to finish the work? I'll keep the primary
> > author's name of you with the patches which you've done.
> >
> > Most of the instructions' emulation codes will be deprecated, but the
> > rest is ok. Maybe you should finish executing out of the slot first
> > and then implement pc-related instructions' emulation.
>
> I can review the patch if you update it. Anyway, my major concern was the
> self-modifying code, others are minor points.
Great! I'll start the job this week. Frankly, csky's haven't been
reviewed enough and I could get some new feedback from riscv's job.

-- 
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/


  reply	other threads:[~2020-06-18 16:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13 19:58 [RFC/RFT 0/2] " Patrick Stählin
2018-11-13 19:58 ` Patrick Stählin
2018-11-13 19:58 ` [RFC/RFT 1/2] RISC-V: Implement ptrace regs and stack API Patrick Stählin
2018-11-13 19:58   ` Patrick Stählin
2019-11-21 22:34   ` Paul Walmsley
2018-11-13 19:58 ` [RFC/RFT 2/2] RISC-V: kprobes/kretprobe support Patrick Stählin
2018-11-13 19:58   ` Patrick Stählin
2018-11-14  8:37   ` Masami Hiramatsu
2018-11-14  8:37     ` Masami Hiramatsu
2018-11-14 15:49     ` Masami Hiramatsu
2018-11-14 15:49       ` Masami Hiramatsu
2018-11-14 21:10       ` Patrick Staehlin
2018-11-14 21:10         ` Patrick Staehlin
2018-11-15  7:50         ` Masami Hiramatsu
2018-11-15  7:50           ` Masami Hiramatsu
2019-12-20 11:14         ` Paul Walmsley
2019-12-20 22:46           ` Paul Walmsley
2018-11-14 20:52     ` Patrick Staehlin
2018-11-14 20:52       ` Patrick Staehlin
2018-11-15  8:41       ` Masami Hiramatsu
2018-11-15  8:41         ` Masami Hiramatsu
     [not found]         ` <CANXhq0qWwKRrz80Q3LSeQu-cH19otCF1my6dDGDxH0Q5j1RYYw@mail.gmail.com>
     [not found]           ` <9cdd84b5-6c81-9bfa-5d35-6645f542f71e@packi.ch>
2019-12-19  9:28             ` Zong Li
2020-03-31  2:45               ` Zong Li
2020-06-12  5:57                 ` David Abdurachmanov
2020-06-17 12:58                   ` Guo Ren
2020-06-17 14:54                     ` Masami Hiramatsu
2020-06-18 16:14                       ` Guo Ren [this message]
2020-07-05 14:57                       ` Guo Ren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJF2gTSEV37ZnXS_VF_OT1tmxzER98XzDswoM2fCZ4XRoq6uzg@mail.gmail.com \
    --to=guoren@kernel.org \
    --cc=anders.roxell@linaro.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=david.abdurachmanov@gmail.com \
    --cc=greentime.hu@sifive.com \
    --cc=linux-riscv@lists.infradead.org \
    --cc=me@packi.ch \
    --cc=mhiramat@kernel.org \
    --cc=paul.walmsley@sifive.com \
    --cc=zong.li@sifive.com \
    --subject='Re: [RFC/RFT 2/2] RISC-V: kprobes/kretprobe support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).