From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC065CCA473 for ; Wed, 6 Jul 2022 14:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A2fT4svbKpTr7BAhytMWik/Oa8cbVIGktdRn2ceYTvM=; b=nTMXnxyxDsyNBF 54TT4+7eBVUmn86dk/w6i1GWGrVW+gimNMtnqkgDkrCvkc4iG1RAgazGLLOoEKkOhGJGkNPfIkb68 5eEjVU766IDVFQ4MffOkseinw8PfyuyQzWs4GVkK+sbYtIT38Hdb1HDWpt18ZWvvfUa/goD9PQOMw jUuC5pk4P43lVvG2V6mtF7KjSpw4PqFnRSNPLxtyCfO5g2cKrdIwHDAbKli+mI1UygCu+3IOBsFd4 ZljSfH6u7JvFPcuGC2aO8S1H74lvTo8UKGoVrPKsU3+HzWyTVBOak+PCXA1pDm1zy2dblSlTCHCf8 yTZbcltDodzXmoEDx3zg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o95ef-00AWVu-6y; Wed, 06 Jul 2022 14:05:25 +0000 Received: from mail-yb1-f173.google.com ([209.85.219.173]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o95a6-00AV6Y-0U; Wed, 06 Jul 2022 14:00:43 +0000 Received: by mail-yb1-f173.google.com with SMTP id l11so27423684ybu.13; Wed, 06 Jul 2022 07:00:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lln/3deL7qOtLziJcXYPqqy6CqnXU6Vj8A13Rxsyfck=; b=62RBKYF6/UxHlPCioYCvwYOm6EIDuHA28dJz2501PPE8JO+7b1xY2azP2qYxzN1fo6 /iiTLa/1xbvJ2ingqtY+Y6LpHfUsOG4R1GInsqrwMvwqeXCY3fR40/SJ9l3j5BOEd3kK Hrgr5vbyizkhhDLJZi+u3BLda4kkNNBSh9EUWXqXMbg54WgqpjJJURSdq+Dxo/RihrFF kwKLcoLoz+O45kct7g5LQ+YpjVX12RqWXZuIPFLDW1czVTh6Fs8WZkyadVRnXX2sQnmx O/uvDWcgK9tTMkmB+fWhNIjUIzip2gz3ePr60SNu0Xv3hvpgR8MAyvw0fdI6G6A6ney+ /3Mw== X-Gm-Message-State: AJIora/vLCAUaTGcMLlkynAM2kxAjbwsjjWYMZMW0IRt4mJhg1mwKjjf QrB4PFfMgPkYpwZXUBg0WqINaIlz5MlGsum4Pic= X-Google-Smtp-Source: AGRyM1vGBIO6ejUezqbzrzuaUC5etUaxh8lxWDh293Sam2Jc/zFfeBj4g08hdYpvSA8zzuIj5u2PxdHOfRWqZSWT82c= X-Received: by 2002:a05:6902:50e:b0:66e:7f55:7a66 with SMTP id x14-20020a056902050e00b0066e7f557a66mr7763507ybs.365.1657116039561; Wed, 06 Jul 2022 07:00:39 -0700 (PDT) MIME-Version: 1.0 References: <20220608142723.103523089@infradead.org> <20220608144517.061583457@infradead.org> In-Reply-To: <20220608144517.061583457@infradead.org> From: "Rafael J. Wysocki" Date: Wed, 6 Jul 2022 16:00:28 +0200 Message-ID: Subject: Re: [PATCH 18/36] cpuidle: Annotate poll_idle() To: Peter Zijlstra Cc: rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, Russell King - ARM Linux , ulli.kroll@googlemail.com, Linus Walleij , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , Tony Lindgren , Kevin Hilman , Catalin Marinas , Will Deacon , Guo Ren , bcain@quicinc.com, Huacai Chen , kernel@xen0n.name, Geert Uytterhoeven , sammy@sammy.net, Michal Simek , Thomas Bogendoerfer , dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, Stafford Horne , James Bottomley , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , David Miller , Richard Weinberger , anton.ivanov@cambridgegreys.com, Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , acme@kernel.org, Mark Rutland , Alexander Shishkin , jolsa@kernel.org, namhyung@kernel.org, Juergen Gross , srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, Boris Ostrovsky , Chris Zankel , jcmvbkbc@gmail.com, "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Michael Turquette , Stephen Boyd , Daniel Lezcano , Lorenzo Pieralisi , Sudeep Holla , Andy Gross , Bjorn Andersson , Anup Patel , Thierry Reding , Jon Hunter , Jacob Pan , Arnd Bergmann , Yury Norov , Andy Shevchenko , Rasmus Villemoes , Steven Rostedt , Petr Mladek , senozhatsky@chromium.org, John Ogness , "Paul E. McKenney" , Frederic Weisbecker , quic_neeraju@quicinc.com, Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Mel Gorman , Daniel Bristot de Oliveira , vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, Linux Kernel Mailing List , linux-snps-arc@lists.infradead.org, Linux ARM , Linux OMAP Mailing List , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , openrisc@lists.librecores.org, Parisc List , linuxppc-dev , linux-riscv , linux-s390@vger.kernel.org, Linux-sh list , sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, ACPI Devel Maling List , Linux PM , linux-clk , linux-arm-msm , linux-tegra , linux-arch , rcu@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220706_070042_102691_4CA9A9AF X-CRM114-Status: GOOD ( 18.18 ) X-Mailman-Approved-At: Wed, 06 Jul 2022 07:05:16 -0700 X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Jun 8, 2022 at 4:46 PM Peter Zijlstra wrote: > > The __cpuidle functions will become a noinstr class, as such they need > explicit annotations. > > Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Rafael J. Wysocki > --- > drivers/cpuidle/poll_state.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > --- a/drivers/cpuidle/poll_state.c > +++ b/drivers/cpuidle/poll_state.c > @@ -13,7 +13,10 @@ > static int __cpuidle poll_idle(struct cpuidle_device *dev, > struct cpuidle_driver *drv, int index) > { > - u64 time_start = local_clock(); > + u64 time_start; > + > + instrumentation_begin(); > + time_start = local_clock(); > > dev->poll_time_limit = false; > > @@ -39,6 +42,7 @@ static int __cpuidle poll_idle(struct cp > raw_local_irq_disable(); > > current_clr_polling(); > + instrumentation_end(); > > return index; > } > > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv