Linux-RISC-V Archive on lore.kernel.org
 help / Atom feed
* [PATCH] riscv: remove redundant kernel-space generic-y
@ 2018-12-16 14:11 Masahiro Yamada
  2019-01-04  1:05 ` Palmer Dabbelt
  0 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2018-12-16 14:11 UTC (permalink / raw)
  To: Palmer Dabbelt, Albert Ou, linux-riscv
  Cc: Alan Kao, linux-kernel, Masahiro Yamada, Geert Uytterhoeven,
	Deepa Dinamani, Jim Wilson

This commit removes redundant generic-y defines in
arch/riscv/include/asm/Kbuild.

[1] It is redundant to define the same generic-y in both
    arch/$(ARCH)/include/asm/Kbuild and
    arch/$(ARCH)/include/uapi/asm/Kbuild.

    Remove the following generic-y:

      errno.h
      fcntl.h
      ioctl.h
      ioctls.h
      ipcbuf.h
      mman.h
      msgbuf.h
      param.h
      poll.h
      posix_types.h
      resource.h
      sembuf.h
      setup.h
      shmbuf.h
      signal.h
      socket.h
      sockios.h
      stat.h
      statfs.h
      swab.h
      termbits.h
      termios.h
      types.h

[2] It is redundant to define generic-y when arch-specific
    implementation exists in arch/$(ARCH)/include/asm/*.h

    Remove the following generic-y:

      cacheflush.h
      dma-mapping.h
      module.h

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/riscv/include/asm/Kbuild | 26 --------------------------
 1 file changed, 26 deletions(-)

diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
index 6a646d9..f7068f3 100644
--- a/arch/riscv/include/asm/Kbuild
+++ b/arch/riscv/include/asm/Kbuild
@@ -1,5 +1,4 @@
 generic-y += bugs.h
-generic-y += cacheflush.h
 generic-y += checksum.h
 generic-y += compat.h
 generic-y += cputime.h
@@ -7,18 +6,12 @@ generic-y += device.h
 generic-y += div64.h
 generic-y += dma.h
 generic-y += dma-contiguous.h
-generic-y += dma-mapping.h
 generic-y += emergency-restart.h
-generic-y += errno.h
 generic-y += exec.h
 generic-y += fb.h
-generic-y += fcntl.h
 generic-y += hardirq.h
 generic-y += hash.h
 generic-y += hw_irq.h
-generic-y += ioctl.h
-generic-y += ioctls.h
-generic-y += ipcbuf.h
 generic-y += irq_regs.h
 generic-y += irq_work.h
 generic-y += kdebug.h
@@ -27,34 +20,15 @@ generic-y += kvm_para.h
 generic-y += local.h
 generic-y += local64.h
 generic-y += mm-arch-hooks.h
-generic-y += mman.h
-generic-y += module.h
-generic-y += msgbuf.h
 generic-y += mutex.h
-generic-y += param.h
 generic-y += percpu.h
-generic-y += poll.h
-generic-y += posix_types.h
 generic-y += preempt.h
-generic-y += resource.h
 generic-y += scatterlist.h
 generic-y += sections.h
-generic-y += sembuf.h
 generic-y += serial.h
-generic-y += setup.h
-generic-y += shmbuf.h
 generic-y += shmparam.h
-generic-y += signal.h
-generic-y += socket.h
-generic-y += sockios.h
-generic-y += stat.h
-generic-y += statfs.h
-generic-y += swab.h
-generic-y += termbits.h
-generic-y += termios.h
 generic-y += topology.h
 generic-y += trace_clock.h
-generic-y += types.h
 generic-y += unaligned.h
 generic-y += user.h
 generic-y += vga.h
-- 
2.7.4


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] riscv: remove redundant kernel-space generic-y
  2018-12-16 14:11 [PATCH] riscv: remove redundant kernel-space generic-y Masahiro Yamada
@ 2019-01-04  1:05 ` Palmer Dabbelt
  2019-01-04 15:03   ` Masahiro Yamada
  0 siblings, 1 reply; 6+ messages in thread
From: Palmer Dabbelt @ 2019-01-04  1:05 UTC (permalink / raw)
  To: yamada.masahiro
  Cc: aou, alankao, linux-kernel, yamada.masahiro, geert, deepa.kernel,
	linux-riscv, Jim Wilson

On Sun, 16 Dec 2018 06:11:11 PST (-0800), yamada.masahiro@socionext.com wrote:
> This commit removes redundant generic-y defines in
> arch/riscv/include/asm/Kbuild.
>
> [1] It is redundant to define the same generic-y in both
>     arch/$(ARCH)/include/asm/Kbuild and
>     arch/$(ARCH)/include/uapi/asm/Kbuild.
>
>     Remove the following generic-y:
>
>       errno.h
>       fcntl.h
>       ioctl.h
>       ioctls.h
>       ipcbuf.h
>       mman.h
>       msgbuf.h
>       param.h
>       poll.h
>       posix_types.h
>       resource.h
>       sembuf.h
>       setup.h
>       shmbuf.h
>       signal.h
>       socket.h
>       sockios.h
>       stat.h
>       statfs.h
>       swab.h
>       termbits.h
>       termios.h
>       types.h
>
> [2] It is redundant to define generic-y when arch-specific
>     implementation exists in arch/$(ARCH)/include/asm/*.h
>
>     Remove the following generic-y:
>
>       cacheflush.h
>       dma-mapping.h
>       module.h
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  arch/riscv/include/asm/Kbuild | 26 --------------------------
>  1 file changed, 26 deletions(-)
>
> diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
> index 6a646d9..f7068f3 100644
> --- a/arch/riscv/include/asm/Kbuild
> +++ b/arch/riscv/include/asm/Kbuild
> @@ -1,5 +1,4 @@
>  generic-y += bugs.h
> -generic-y += cacheflush.h
>  generic-y += checksum.h
>  generic-y += compat.h
>  generic-y += cputime.h
> @@ -7,18 +6,12 @@ generic-y += device.h
>  generic-y += div64.h
>  generic-y += dma.h
>  generic-y += dma-contiguous.h
> -generic-y += dma-mapping.h
>  generic-y += emergency-restart.h
> -generic-y += errno.h
>  generic-y += exec.h
>  generic-y += fb.h
> -generic-y += fcntl.h
>  generic-y += hardirq.h
>  generic-y += hash.h
>  generic-y += hw_irq.h
> -generic-y += ioctl.h
> -generic-y += ioctls.h
> -generic-y += ipcbuf.h
>  generic-y += irq_regs.h
>  generic-y += irq_work.h
>  generic-y += kdebug.h
> @@ -27,34 +20,15 @@ generic-y += kvm_para.h
>  generic-y += local.h
>  generic-y += local64.h
>  generic-y += mm-arch-hooks.h
> -generic-y += mman.h
> -generic-y += module.h
> -generic-y += msgbuf.h
>  generic-y += mutex.h
> -generic-y += param.h
>  generic-y += percpu.h
> -generic-y += poll.h
> -generic-y += posix_types.h
>  generic-y += preempt.h
> -generic-y += resource.h
>  generic-y += scatterlist.h
>  generic-y += sections.h
> -generic-y += sembuf.h
>  generic-y += serial.h
> -generic-y += setup.h
> -generic-y += shmbuf.h
>  generic-y += shmparam.h
> -generic-y += signal.h
> -generic-y += socket.h
> -generic-y += sockios.h
> -generic-y += stat.h
> -generic-y += statfs.h
> -generic-y += swab.h
> -generic-y += termbits.h
> -generic-y += termios.h
>  generic-y += topology.h
>  generic-y += trace_clock.h
> -generic-y += types.h
>  generic-y += unaligned.h
>  generic-y += user.h
>  generic-y += vga.h

Thanks.  These just sort of collected there because I hadn't trimmed them.  Is 
there a script that checks these?

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] riscv: remove redundant kernel-space generic-y
  2019-01-04  1:05 ` Palmer Dabbelt
@ 2019-01-04 15:03   ` Masahiro Yamada
  2019-01-08 20:17     ` Palmer Dabbelt
  0 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2019-01-04 15:03 UTC (permalink / raw)
  To: Palmer Dabbelt
  Cc: aou, alankao, Linux Kernel Mailing List, Geert Uytterhoeven,
	deepa.kernel, linux-riscv, Jim Wilson

On Fri, Jan 4, 2019 at 11:16 AM Palmer Dabbelt <palmer@sifive.com> wrote:
>
> On Sun, 16 Dec 2018 06:11:11 PST (-0800), yamada.masahiro@socionext.com wrote:
> > This commit removes redundant generic-y defines in
> > arch/riscv/include/asm/Kbuild.
> >
> > [1] It is redundant to define the same generic-y in both
> >     arch/$(ARCH)/include/asm/Kbuild and
> >     arch/$(ARCH)/include/uapi/asm/Kbuild.
> >
> >     Remove the following generic-y:
> >
> >       errno.h
> >       fcntl.h
> >       ioctl.h
> >       ioctls.h
> >       ipcbuf.h
> >       mman.h
> >       msgbuf.h
> >       param.h
> >       poll.h
> >       posix_types.h
> >       resource.h
> >       sembuf.h
> >       setup.h
> >       shmbuf.h
> >       signal.h
> >       socket.h
> >       sockios.h
> >       stat.h
> >       statfs.h
> >       swab.h
> >       termbits.h
> >       termios.h
> >       types.h
> >
> > [2] It is redundant to define generic-y when arch-specific
> >     implementation exists in arch/$(ARCH)/include/asm/*.h
> >
> >     Remove the following generic-y:
> >
> >       cacheflush.h
> >       dma-mapping.h
> >       module.h
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> >
> >  arch/riscv/include/asm/Kbuild | 26 --------------------------
> >  1 file changed, 26 deletions(-)
> >
> > diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
> > index 6a646d9..f7068f3 100644
> > --- a/arch/riscv/include/asm/Kbuild
> > +++ b/arch/riscv/include/asm/Kbuild
> > @@ -1,5 +1,4 @@
> >  generic-y += bugs.h
> > -generic-y += cacheflush.h
> >  generic-y += checksum.h
> >  generic-y += compat.h
> >  generic-y += cputime.h
> > @@ -7,18 +6,12 @@ generic-y += device.h
> >  generic-y += div64.h
> >  generic-y += dma.h
> >  generic-y += dma-contiguous.h
> > -generic-y += dma-mapping.h
> >  generic-y += emergency-restart.h
> > -generic-y += errno.h
> >  generic-y += exec.h
> >  generic-y += fb.h
> > -generic-y += fcntl.h
> >  generic-y += hardirq.h
> >  generic-y += hash.h
> >  generic-y += hw_irq.h
> > -generic-y += ioctl.h
> > -generic-y += ioctls.h
> > -generic-y += ipcbuf.h
> >  generic-y += irq_regs.h
> >  generic-y += irq_work.h
> >  generic-y += kdebug.h
> > @@ -27,34 +20,15 @@ generic-y += kvm_para.h
> >  generic-y += local.h
> >  generic-y += local64.h
> >  generic-y += mm-arch-hooks.h
> > -generic-y += mman.h
> > -generic-y += module.h
> > -generic-y += msgbuf.h
> >  generic-y += mutex.h
> > -generic-y += param.h
> >  generic-y += percpu.h
> > -generic-y += poll.h
> > -generic-y += posix_types.h
> >  generic-y += preempt.h
> > -generic-y += resource.h
> >  generic-y += scatterlist.h
> >  generic-y += sections.h
> > -generic-y += sembuf.h
> >  generic-y += serial.h
> > -generic-y += setup.h
> > -generic-y += shmbuf.h
> >  generic-y += shmparam.h
> > -generic-y += signal.h
> > -generic-y += socket.h
> > -generic-y += sockios.h
> > -generic-y += stat.h
> > -generic-y += statfs.h
> > -generic-y += swab.h
> > -generic-y += termbits.h
> > -generic-y += termios.h
> >  generic-y += topology.h
> >  generic-y += trace_clock.h
> > -generic-y += types.h
> >  generic-y += unaligned.h
> >  generic-y += user.h
> >  generic-y += vga.h
>
> Thanks.  These just sort of collected there because I hadn't trimmed them.  Is
> there a script that checks these?


No script is available for now, but
I'd like to turn on warnings to catch some cases:
https://patchwork.kernel.org/patch/10746823/


BTW, can I apply this to my tree
along with other cleanups?



-- 
Best Regards
Masahiro Yamada

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] riscv: remove redundant kernel-space generic-y
  2019-01-04 15:03   ` Masahiro Yamada
@ 2019-01-08 20:17     ` Palmer Dabbelt
  2019-01-09 14:57       ` Andreas Schwab
  0 siblings, 1 reply; 6+ messages in thread
From: Palmer Dabbelt @ 2019-01-08 20:17 UTC (permalink / raw)
  To: yamada.masahiro
  Cc: aou, alankao, linux-kernel, geert, deepa.kernel, linux-riscv, Jim Wilson

On Fri, 04 Jan 2019 07:03:20 PST (-0800), yamada.masahiro@socionext.com wrote:
> On Fri, Jan 4, 2019 at 11:16 AM Palmer Dabbelt <palmer@sifive.com> wrote:
>>
>> On Sun, 16 Dec 2018 06:11:11 PST (-0800), yamada.masahiro@socionext.com wrote:
>> > This commit removes redundant generic-y defines in
>> > arch/riscv/include/asm/Kbuild.
>> >
>> > [1] It is redundant to define the same generic-y in both
>> >     arch/$(ARCH)/include/asm/Kbuild and
>> >     arch/$(ARCH)/include/uapi/asm/Kbuild.
>> >
>> >     Remove the following generic-y:
>> >
>> >       errno.h
>> >       fcntl.h
>> >       ioctl.h
>> >       ioctls.h
>> >       ipcbuf.h
>> >       mman.h
>> >       msgbuf.h
>> >       param.h
>> >       poll.h
>> >       posix_types.h
>> >       resource.h
>> >       sembuf.h
>> >       setup.h
>> >       shmbuf.h
>> >       signal.h
>> >       socket.h
>> >       sockios.h
>> >       stat.h
>> >       statfs.h
>> >       swab.h
>> >       termbits.h
>> >       termios.h
>> >       types.h
>> >
>> > [2] It is redundant to define generic-y when arch-specific
>> >     implementation exists in arch/$(ARCH)/include/asm/*.h
>> >
>> >     Remove the following generic-y:
>> >
>> >       cacheflush.h
>> >       dma-mapping.h
>> >       module.h
>> >
>> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> > ---
>> >
>> >  arch/riscv/include/asm/Kbuild | 26 --------------------------
>> >  1 file changed, 26 deletions(-)
>> >
>> > diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
>> > index 6a646d9..f7068f3 100644
>> > --- a/arch/riscv/include/asm/Kbuild
>> > +++ b/arch/riscv/include/asm/Kbuild
>> > @@ -1,5 +1,4 @@
>> >  generic-y += bugs.h
>> > -generic-y += cacheflush.h
>> >  generic-y += checksum.h
>> >  generic-y += compat.h
>> >  generic-y += cputime.h
>> > @@ -7,18 +6,12 @@ generic-y += device.h
>> >  generic-y += div64.h
>> >  generic-y += dma.h
>> >  generic-y += dma-contiguous.h
>> > -generic-y += dma-mapping.h
>> >  generic-y += emergency-restart.h
>> > -generic-y += errno.h
>> >  generic-y += exec.h
>> >  generic-y += fb.h
>> > -generic-y += fcntl.h
>> >  generic-y += hardirq.h
>> >  generic-y += hash.h
>> >  generic-y += hw_irq.h
>> > -generic-y += ioctl.h
>> > -generic-y += ioctls.h
>> > -generic-y += ipcbuf.h
>> >  generic-y += irq_regs.h
>> >  generic-y += irq_work.h
>> >  generic-y += kdebug.h
>> > @@ -27,34 +20,15 @@ generic-y += kvm_para.h
>> >  generic-y += local.h
>> >  generic-y += local64.h
>> >  generic-y += mm-arch-hooks.h
>> > -generic-y += mman.h
>> > -generic-y += module.h
>> > -generic-y += msgbuf.h
>> >  generic-y += mutex.h
>> > -generic-y += param.h
>> >  generic-y += percpu.h
>> > -generic-y += poll.h
>> > -generic-y += posix_types.h
>> >  generic-y += preempt.h
>> > -generic-y += resource.h
>> >  generic-y += scatterlist.h
>> >  generic-y += sections.h
>> > -generic-y += sembuf.h
>> >  generic-y += serial.h
>> > -generic-y += setup.h
>> > -generic-y += shmbuf.h
>> >  generic-y += shmparam.h
>> > -generic-y += signal.h
>> > -generic-y += socket.h
>> > -generic-y += sockios.h
>> > -generic-y += stat.h
>> > -generic-y += statfs.h
>> > -generic-y += swab.h
>> > -generic-y += termbits.h
>> > -generic-y += termios.h
>> >  generic-y += topology.h
>> >  generic-y += trace_clock.h
>> > -generic-y += types.h
>> >  generic-y += unaligned.h
>> >  generic-y += user.h
>> >  generic-y += vga.h
>>
>> Thanks.  These just sort of collected there because I hadn't trimmed them.  Is
>> there a script that checks these?
>
>
> No script is available for now, but
> I'd like to turn on warnings to catch some cases:
> https://patchwork.kernel.org/patch/10746823/
>
>
> BTW, can I apply this to my tree
> along with other cleanups?

Acked-by: Palmer Dabbelt <palmer@sifive.com>

Thanks!

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] riscv: remove redundant kernel-space generic-y
  2019-01-08 20:17     ` Palmer Dabbelt
@ 2019-01-09 14:57       ` Andreas Schwab
  2019-01-09 15:15         ` Masahiro Yamada
  0 siblings, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2019-01-09 14:57 UTC (permalink / raw)
  To: Palmer Dabbelt
  Cc: aou, alankao, linux-kernel, yamada.masahiro, geert, deepa.kernel,
	linux-riscv, Jim Wilson

On Jan 08 2019, Palmer Dabbelt <palmer@sifive.com> wrote:

> On Fri, 04 Jan 2019 07:03:20 PST (-0800), yamada.masahiro@socionext.com wrote:
>> On Fri, Jan 4, 2019 at 11:16 AM Palmer Dabbelt <palmer@sifive.com> wrote:
>>>
>>> On Sun, 16 Dec 2018 06:11:11 PST (-0800), yamada.masahiro@socionext.com wrote:
>>> > This commit removes redundant generic-y defines in
>>> > arch/riscv/include/asm/Kbuild.
>>> >
>>> > [1] It is redundant to define the same generic-y in both
>>> >     arch/$(ARCH)/include/asm/Kbuild and
>>> >     arch/$(ARCH)/include/uapi/asm/Kbuild.
>>> >
>>> >     Remove the following generic-y:
>>> >
>>> >       errno.h
>>> >       fcntl.h
>>> >       ioctl.h
>>> >       ioctls.h
>>> >       ipcbuf.h
>>> >       mman.h
>>> >       msgbuf.h
>>> >       param.h
>>> >       poll.h
>>> >       posix_types.h
>>> >       resource.h
>>> >       sembuf.h
>>> >       setup.h
>>> >       shmbuf.h
>>> >       signal.h
>>> >       socket.h
>>> >       sockios.h
>>> >       stat.h
>>> >       statfs.h
>>> >       swab.h
>>> >       termbits.h
>>> >       termios.h
>>> >       types.h
>>> >
>>> > [2] It is redundant to define generic-y when arch-specific
>>> >     implementation exists in arch/$(ARCH)/include/asm/*.h
>>> >
>>> >     Remove the following generic-y:
>>> >
>>> >       cacheflush.h
>>> >       dma-mapping.h
>>> >       module.h
>>> >
>>> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>> > ---
>>> >
>>> >  arch/riscv/include/asm/Kbuild | 26 --------------------------
>>> >  1 file changed, 26 deletions(-)
>>> >
>>> > diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
>>> > index 6a646d9..f7068f3 100644
>>> > --- a/arch/riscv/include/asm/Kbuild
>>> > +++ b/arch/riscv/include/asm/Kbuild
>>> > @@ -1,5 +1,4 @@
>>> >  generic-y += bugs.h
>>> > -generic-y += cacheflush.h
>>> >  generic-y += checksum.h
>>> >  generic-y += compat.h
>>> >  generic-y += cputime.h
>>> > @@ -7,18 +6,12 @@ generic-y += device.h
>>> >  generic-y += div64.h
>>> >  generic-y += dma.h
>>> >  generic-y += dma-contiguous.h
>>> > -generic-y += dma-mapping.h
>>> >  generic-y += emergency-restart.h
>>> > -generic-y += errno.h
>>> >  generic-y += exec.h
>>> >  generic-y += fb.h
>>> > -generic-y += fcntl.h
>>> >  generic-y += hardirq.h
>>> >  generic-y += hash.h
>>> >  generic-y += hw_irq.h
>>> > -generic-y += ioctl.h
>>> > -generic-y += ioctls.h
>>> > -generic-y += ipcbuf.h
>>> >  generic-y += irq_regs.h
>>> >  generic-y += irq_work.h
>>> >  generic-y += kdebug.h
>>> > @@ -27,34 +20,15 @@ generic-y += kvm_para.h
>>> >  generic-y += local.h
>>> >  generic-y += local64.h
>>> >  generic-y += mm-arch-hooks.h
>>> > -generic-y += mman.h
>>> > -generic-y += module.h
>>> > -generic-y += msgbuf.h
>>> >  generic-y += mutex.h
>>> > -generic-y += param.h
>>> >  generic-y += percpu.h
>>> > -generic-y += poll.h
>>> > -generic-y += posix_types.h
>>> >  generic-y += preempt.h
>>> > -generic-y += resource.h
>>> >  generic-y += scatterlist.h
>>> >  generic-y += sections.h
>>> > -generic-y += sembuf.h
>>> >  generic-y += serial.h
>>> > -generic-y += setup.h
>>> > -generic-y += shmbuf.h
>>> >  generic-y += shmparam.h
>>> > -generic-y += signal.h
>>> > -generic-y += socket.h
>>> > -generic-y += sockios.h
>>> > -generic-y += stat.h
>>> > -generic-y += statfs.h
>>> > -generic-y += swab.h
>>> > -generic-y += termbits.h
>>> > -generic-y += termios.h
>>> >  generic-y += topology.h
>>> >  generic-y += trace_clock.h
>>> > -generic-y += types.h
>>> >  generic-y += unaligned.h
>>> >  generic-y += user.h
>>> >  generic-y += vga.h
>>>
>>> Thanks.  These just sort of collected there because I hadn't trimmed them.  Is
>>> there a script that checks these?
>>
>>
>> No script is available for now, but
>> I'd like to turn on warnings to catch some cases:
>> https://patchwork.kernel.org/patch/10746823/
>>
>>
>> BTW, can I apply this to my tree
>> along with other cleanups?
>
> Acked-by: Palmer Dabbelt <palmer@sifive.com>

arch/riscv/include/asm/dma-mapping.h no longer exists.

In file included from ./include/linux/skbuff.h:34,
                 from ./include/net/net_namespace.h:36,
                 from ./include/linux/inet.h:46,
                 from ./include/linux/sunrpc/msg_prot.h:204,
                 from ./include/linux/sunrpc/auth.h:16,
                 from ./include/linux/nfs_fs.h:31,
                 from init/do_mounts.c:22:
./include/linux/dma-mapping.h:261:10: fatal error: asm/dma-mapping.h: No such file or directory
 #include <asm/dma-mapping.h>
          ^~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.build:277: init/do_mounts.o] Error 1

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] riscv: remove redundant kernel-space generic-y
  2019-01-09 14:57       ` Andreas Schwab
@ 2019-01-09 15:15         ` Masahiro Yamada
  0 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2019-01-09 15:15 UTC (permalink / raw)
  To: Andreas Schwab
  Cc: Albert Ou, alankao, Palmer Dabbelt, Linux Kernel Mailing List,
	Geert Uytterhoeven, Deepa Dinamani, linux-riscv, Jim Wilson

On Thu, Jan 10, 2019 at 12:01 AM Andreas Schwab <schwab@suse.de> wrote:
>
> On Jan 08 2019, Palmer Dabbelt <palmer@sifive.com> wrote:
>
> > On Fri, 04 Jan 2019 07:03:20 PST (-0800), yamada.masahiro@socionext.com wrote:
> >> On Fri, Jan 4, 2019 at 11:16 AM Palmer Dabbelt <palmer@sifive.com> wrote:
> >>>
> >>> On Sun, 16 Dec 2018 06:11:11 PST (-0800), yamada.masahiro@socionext.com wrote:
> >>> > This commit removes redundant generic-y defines in
> >>> > arch/riscv/include/asm/Kbuild.
> >>> >
> >>> > [1] It is redundant to define the same generic-y in both
> >>> >     arch/$(ARCH)/include/asm/Kbuild and
> >>> >     arch/$(ARCH)/include/uapi/asm/Kbuild.
> >>> >
> >>> >     Remove the following generic-y:
> >>> >
> >>> >       errno.h
> >>> >       fcntl.h
> >>> >       ioctl.h
> >>> >       ioctls.h
> >>> >       ipcbuf.h
> >>> >       mman.h
> >>> >       msgbuf.h
> >>> >       param.h
> >>> >       poll.h
> >>> >       posix_types.h
> >>> >       resource.h
> >>> >       sembuf.h
> >>> >       setup.h
> >>> >       shmbuf.h
> >>> >       signal.h
> >>> >       socket.h
> >>> >       sockios.h
> >>> >       stat.h
> >>> >       statfs.h
> >>> >       swab.h
> >>> >       termbits.h
> >>> >       termios.h
> >>> >       types.h
> >>> >
> >>> > [2] It is redundant to define generic-y when arch-specific
> >>> >     implementation exists in arch/$(ARCH)/include/asm/*.h
> >>> >
> >>> >     Remove the following generic-y:
> >>> >
> >>> >       cacheflush.h
> >>> >       dma-mapping.h
> >>> >       module.h
> >>> >
> >>> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >>> > ---
> >>> >
> >>> >  arch/riscv/include/asm/Kbuild | 26 --------------------------
> >>> >  1 file changed, 26 deletions(-)
> >>> >
> >>> > diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
> >>> > index 6a646d9..f7068f3 100644
> >>> > --- a/arch/riscv/include/asm/Kbuild
> >>> > +++ b/arch/riscv/include/asm/Kbuild
> >>> > @@ -1,5 +1,4 @@
> >>> >  generic-y += bugs.h
> >>> > -generic-y += cacheflush.h
> >>> >  generic-y += checksum.h
> >>> >  generic-y += compat.h
> >>> >  generic-y += cputime.h
> >>> > @@ -7,18 +6,12 @@ generic-y += device.h
> >>> >  generic-y += div64.h
> >>> >  generic-y += dma.h
> >>> >  generic-y += dma-contiguous.h
> >>> > -generic-y += dma-mapping.h
> >>> >  generic-y += emergency-restart.h
> >>> > -generic-y += errno.h
> >>> >  generic-y += exec.h
> >>> >  generic-y += fb.h
> >>> > -generic-y += fcntl.h
> >>> >  generic-y += hardirq.h
> >>> >  generic-y += hash.h
> >>> >  generic-y += hw_irq.h
> >>> > -generic-y += ioctl.h
> >>> > -generic-y += ioctls.h
> >>> > -generic-y += ipcbuf.h
> >>> >  generic-y += irq_regs.h
> >>> >  generic-y += irq_work.h
> >>> >  generic-y += kdebug.h
> >>> > @@ -27,34 +20,15 @@ generic-y += kvm_para.h
> >>> >  generic-y += local.h
> >>> >  generic-y += local64.h
> >>> >  generic-y += mm-arch-hooks.h
> >>> > -generic-y += mman.h
> >>> > -generic-y += module.h
> >>> > -generic-y += msgbuf.h
> >>> >  generic-y += mutex.h
> >>> > -generic-y += param.h
> >>> >  generic-y += percpu.h
> >>> > -generic-y += poll.h
> >>> > -generic-y += posix_types.h
> >>> >  generic-y += preempt.h
> >>> > -generic-y += resource.h
> >>> >  generic-y += scatterlist.h
> >>> >  generic-y += sections.h
> >>> > -generic-y += sembuf.h
> >>> >  generic-y += serial.h
> >>> > -generic-y += setup.h
> >>> > -generic-y += shmbuf.h
> >>> >  generic-y += shmparam.h
> >>> > -generic-y += signal.h
> >>> > -generic-y += socket.h
> >>> > -generic-y += sockios.h
> >>> > -generic-y += stat.h
> >>> > -generic-y += statfs.h
> >>> > -generic-y += swab.h
> >>> > -generic-y += termbits.h
> >>> > -generic-y += termios.h
> >>> >  generic-y += topology.h
> >>> >  generic-y += trace_clock.h
> >>> > -generic-y += types.h
> >>> >  generic-y += unaligned.h
> >>> >  generic-y += user.h
> >>> >  generic-y += vga.h
> >>>
> >>> Thanks.  These just sort of collected there because I hadn't trimmed them.  Is
> >>> there a script that checks these?
> >>
> >>
> >> No script is available for now, but
> >> I'd like to turn on warnings to catch some cases:
> >> https://patchwork.kernel.org/patch/10746823/
> >>
> >>
> >> BTW, can I apply this to my tree
> >> along with other cleanups?
> >
> > Acked-by: Palmer Dabbelt <palmer@sifive.com>
>
> arch/riscv/include/asm/dma-mapping.h no longer exists.
>
> In file included from ./include/linux/skbuff.h:34,
>                  from ./include/net/net_namespace.h:36,
>                  from ./include/linux/inet.h:46,
>                  from ./include/linux/sunrpc/msg_prot.h:204,
>                  from ./include/linux/sunrpc/auth.h:16,
>                  from ./include/linux/nfs_fs.h:31,
>                  from init/do_mounts.c:22:
> ./include/linux/dma-mapping.h:261:10: fatal error: asm/dma-mapping.h: No such file or directory
>  #include <asm/dma-mapping.h>
>           ^~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[1]: *** [scripts/Makefile.build:277: init/do_mounts.o] Error 1


Looks like you tested v1,
which I sent before c5cd037d1c8044fbd131c57822a67a1576eb16e9 was applied.


I picked up v2:
https://patchwork.kernel.org/patch/10746819/

Now, it is already in Linus tree.
8c4fa8b8d48326353afaf6934edd5f1cc49ee90b




--
Best Regards
Masahiro Yamada

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-16 14:11 [PATCH] riscv: remove redundant kernel-space generic-y Masahiro Yamada
2019-01-04  1:05 ` Palmer Dabbelt
2019-01-04 15:03   ` Masahiro Yamada
2019-01-08 20:17     ` Palmer Dabbelt
2019-01-09 14:57       ` Andreas Schwab
2019-01-09 15:15         ` Masahiro Yamada

Linux-RISC-V Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-riscv/0 linux-riscv/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-riscv linux-riscv/ https://lore.kernel.org/linux-riscv \
		linux-riscv@lists.infradead.org infradead-linux-riscv@archiver.kernel.org
	public-inbox-index linux-riscv


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-riscv


AGPL code for this site: git clone https://public-inbox.org/ public-inbox