From: arnd@arndb.de (Arnd Bergmann) To: linux-riscv@lists.infradead.org Subject: [PATCH] riscv: add asm/unistd.h UAPI header Date: Mon, 5 Nov 2018 21:56:15 +0100 [thread overview] Message-ID: <CAK8P3a3JcztCSYBuu5ZJXaV83VNLv_1v3v-EKMR+tC1oOsQesw@mail.gmail.com> (raw) In-Reply-To: <20181105142602.25750-1-david.abdurachmanov@gmail.com> On 11/5/18, David Abdurachmanov <david.abdurachmanov@gmail.com> wrote: > Marcin Juszkiewicz reported issues while generating syscall table for riscv > using 4.20-rc1. The patch refactors our unistd.h files to match some other > architectures. > > - Add asm/unistd.h UAPI header, which has __ARCH_WANT_NEW_STAT > - Remove asm/syscalls.h UAPI header and merge to asm/unistd.h > - Adjust kernel asm/unistd.h > > So now asm/unistd.h UAPI header should show all syscalls for riscv. > > Before this, Makefile simply put `#include <asm-generic/unistd.h>` into > generated asm/unistd.h UAPI header thus user didn't see: > > - __NR_riscv_flush_icache > - __NR_newfstatat > - __NR_fstat > > which are supported by riscv kernel. > > Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> > Cc: Guenter Roeck <linux@roeck-us.net> Thanks for addressing this, your patch correctly fixes riscv64, and I should have noticed the mistake when I originally merged the broken patch. However, looking closer I found another problem with the original patch that your fix does not address: __ARCH_WANT_NEW_STAT should only be set on 64-bit architectures. For a 32-bit architecture, we only want __ARCH_WANT_STAT64 if any. For 64-bit architectures with compat mode, we still need to set __ARCH_WANT_STAT64 from the non-uapi file so we get the syscall implementation. If we don't care about the riscv32 ABI changing yet, we can decide to leave out __ARCH_WANT_STAT64 here, and require glibc to implement it using statx() like any new architecture. stat64 is not y2038 safe, and statx replaces it because of that. > Fixes: 67314ec7b025 That line should be formatted as Fixes: 67314ec7b025 ("RISC-V: Request newstat syscalls")
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de> To: David Abdurachmanov <david.abdurachmanov@gmail.com> Cc: aou@eecs.berkeley.edu, palmer@sifive.com, linux-kernel@vger.kernel.org, Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>, linux-riscv@lists.infradead.org, Guenter Roeck <linux@roeck-us.net> Subject: Re: [PATCH] riscv: add asm/unistd.h UAPI header Date: Mon, 5 Nov 2018 21:56:15 +0100 [thread overview] Message-ID: <CAK8P3a3JcztCSYBuu5ZJXaV83VNLv_1v3v-EKMR+tC1oOsQesw@mail.gmail.com> (raw) Message-ID: <20181105205615.N9D1wTrNKYnehtYoq_3dWZ1TL1JKuyZtE6YljLHGrcw@z> (raw) In-Reply-To: <20181105142602.25750-1-david.abdurachmanov@gmail.com> On 11/5/18, David Abdurachmanov <david.abdurachmanov@gmail.com> wrote: > Marcin Juszkiewicz reported issues while generating syscall table for riscv > using 4.20-rc1. The patch refactors our unistd.h files to match some other > architectures. > > - Add asm/unistd.h UAPI header, which has __ARCH_WANT_NEW_STAT > - Remove asm/syscalls.h UAPI header and merge to asm/unistd.h > - Adjust kernel asm/unistd.h > > So now asm/unistd.h UAPI header should show all syscalls for riscv. > > Before this, Makefile simply put `#include <asm-generic/unistd.h>` into > generated asm/unistd.h UAPI header thus user didn't see: > > - __NR_riscv_flush_icache > - __NR_newfstatat > - __NR_fstat > > which are supported by riscv kernel. > > Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> > Cc: Guenter Roeck <linux@roeck-us.net> Thanks for addressing this, your patch correctly fixes riscv64, and I should have noticed the mistake when I originally merged the broken patch. However, looking closer I found another problem with the original patch that your fix does not address: __ARCH_WANT_NEW_STAT should only be set on 64-bit architectures. For a 32-bit architecture, we only want __ARCH_WANT_STAT64 if any. For 64-bit architectures with compat mode, we still need to set __ARCH_WANT_STAT64 from the non-uapi file so we get the syscall implementation. If we don't care about the riscv32 ABI changing yet, we can decide to leave out __ARCH_WANT_STAT64 here, and require glibc to implement it using statx() like any new architecture. stat64 is not y2038 safe, and statx replaces it because of that. > Fixes: 67314ec7b025 That line should be formatted as Fixes: 67314ec7b025 ("RISC-V: Request newstat syscalls") _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2018-11-05 20:56 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-05 14:26 [PATCH] riscv: add asm/unistd.h UAPI header David Abdurachmanov 2018-11-05 14:26 ` David Abdurachmanov 2018-11-05 14:43 ` David Abdurachmanov 2018-11-05 14:43 ` David Abdurachmanov 2018-11-05 16:02 ` Marcin Juszkiewicz 2018-11-05 16:02 ` Marcin Juszkiewicz 2018-11-05 20:56 ` Arnd Bergmann [this message] 2018-11-05 20:56 ` Arnd Bergmann 2018-11-07 0:08 ` Palmer Dabbelt 2018-11-07 0:08 ` Palmer Dabbelt 2018-11-07 18:30 ` David Abdurachmanov 2018-11-07 18:30 ` David Abdurachmanov 2018-11-07 21:09 ` Arnd Bergmann 2018-11-07 21:09 ` Arnd Bergmann 2018-11-08 2:10 ` Palmer Dabbelt 2018-11-08 2:10 ` Palmer Dabbelt 2018-11-08 10:30 ` Arnd Bergmann 2018-11-08 10:30 ` Arnd Bergmann 2018-11-08 16:57 ` Palmer Dabbelt 2018-11-08 16:57 ` Palmer Dabbelt 2018-11-08 10:38 ` David Abdurachmanov 2018-11-08 10:38 ` David Abdurachmanov 2018-11-08 16:57 ` Palmer Dabbelt 2018-11-08 16:57 ` Palmer Dabbelt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAK8P3a3JcztCSYBuu5ZJXaV83VNLv_1v3v-EKMR+tC1oOsQesw@mail.gmail.com \ --to=arnd@arndb.de \ --cc=linux-riscv@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).