From: Rob Herring <robh+dt@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv <linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
wefu@redhat.com, Guo Ren <guoren@kernel.org>,
cmuellner@linux.com, Philipp Tomsich <philipp.tomsich@vrull.eu>,
Christoph Hellwig <hch@lst.de>,
Samuel Holland <samuel@sholland.org>,
Atish Patra <atishp@atishpatra.org>,
Anup Patel <anup@brainfault.org>,
Nick Kossifidis <mick@ics.forth.gr>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org, Drew Fustini <drew@beagleboard.org>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v5 1/4] of: also handle dma-noncoherent in of_dma_is_coherent()
Date: Thu, 30 Jun 2022 08:57:55 -0600 [thread overview]
Message-ID: <CAL_JsqJEPL1Jc8k5W4P8hgGzOXxgfqNKNqYuc0nLkCnV274TxA@mail.gmail.com> (raw)
In-Reply-To: <20220629215944.397952-2-heiko@sntech.de>
On Wed, Jun 29, 2022 at 4:00 PM Heiko Stuebner <heiko@sntech.de> wrote:
>
> of_dma_is_coherent() currently expects the architecture to be
> non-coherent and some devices being coherent getting marked
> as such with the dma-coherent devicetree property.
>
> For PowerPC CONFIG_OF_DMA_DEFAULT_COHERENT was added which currently
> makes of_dma_is_coherent() always return true but doesn't handle
> the case of the architecture being coherent but some devices not.
>
> So modify the function to also check for dma-noncoherent and
> set a suitable default return value. If CONFIG_OF_DMA_DEFAULT_COHERENT
> is set the value starts with true and finding dma-noncoherent will
> set it to false and without CONFIG_OF_DMA_DEFAULT_COHERENT, the
> behaviour is reversed.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/of/address.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-06-30 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 21:59 [PATCH v5 0/4] riscv: implement Zicbom-based CMO instructions + the t-head variant Heiko Stuebner
2022-06-29 21:59 ` [PATCH v5 1/4] of: also handle dma-noncoherent in of_dma_is_coherent() Heiko Stuebner
2022-06-30 4:25 ` Christoph Hellwig
2022-06-30 14:57 ` Rob Herring [this message]
2022-06-29 21:59 ` [PATCH v5 2/4] dt-bindings: riscv: document cbom-block-size Heiko Stuebner
2022-06-29 21:59 ` [PATCH v5 3/4] riscv: Implement Zicbom-based cache management operations Heiko Stuebner
2022-06-30 4:28 ` Christoph Hellwig
2022-06-29 21:59 ` [PATCH v5 4/4] riscv: implement cache-management errata for T-Head SoCs Heiko Stuebner
2022-06-30 3:04 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJEPL1Jc8k5W4P8hgGzOXxgfqNKNqYuc0nLkCnV274TxA@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=anup@brainfault.org \
--cc=atishp@atishpatra.org \
--cc=cmuellner@linux.com \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=guoren@kernel.org \
--cc=hch@lst.de \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mick@ics.forth.gr \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=philipp.tomsich@vrull.eu \
--cc=rdunlap@infradead.org \
--cc=samuel@sholland.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).