Re: [PATCH v1 1/7] RISC-V: introduce ARCH_FOO kconfig aliases for SOC_FOO symbols

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Conor Dooley <conor@kernel.org>
Cc: linux-riscv@lists.infradead.org,
	Conor Dooley <conor.dooley@microchip.com>,
	 Arnd Bergmann <arnd@arndb.de>,
	Christoph Hellwig <hch@infradead.org>,
	 Damien Le Moal <damien.lemoal@opensource.wdc.com>,
	 Emil Renner Berthing <emil.renner.berthing@canonical.com>,
	Heiko Stuebner <heiko@sntech.de>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Samuel Holland <samuel@sholland.org>
Subject: Re: [PATCH v1 1/7] RISC-V: introduce ARCH_FOO kconfig aliases for SOC_FOO symbols
Date: Tue, 10 Jan 2023 22:14:51 +0100	[thread overview]
Message-ID: <CAMuHMdVoMzox6FdPFsR515nnEYXtCt-Xs5qBgGQigzL2=Q7kPg@mail.gmail.com> (raw)
In-Reply-To: <20221121221414.109965-2-conor@kernel.org>

Hi Conor,

On Mon, Nov 21, 2022 at 11:18 PM Conor Dooley <conor@kernel.org> wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> To facilitate a transfer from SOC_FOO to ARCH_FOO, over a release cycle,
> introduce some aliases so that drivers etc that use the SOC_FOO symbols
> can be converted.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>

Thanks for your patch, which is now commit fc43211939bb6874
("RISC-V: kconfig.socs: convert usage of SOC_CANAAN to
ARCH_CANAAN") in riscv/for-next

> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs

> @@ -73,6 +91,9 @@ config SOC_CANAAN_K210_DTB_BUILTIN
>           This option should be selected if no bootloader is being used.
>           If unsure, say Y.
>
> +config ARCH_CANAAN_K210_DTB_SOURCE
> +       def_bool SOC_CANAAN_K210_DTB_SOURCE

This is not correct, as SOC_CANAAN_K210_DTB_SOURCE below is
not a bool, but a string.

> +
>  config SOC_CANAAN_K210_DTB_SOURCE
>         string "Source file for the Canaan Kendryte K210 builtin DTB"
>         depends on SOC_CANAAN

Hence

    obj-$(CONFIG_ARCH_CANAAN_K210_DTB_BUILTIN) += $(addsuffix .dtb.o,
$(CONFIG_ARCH_CANAAN_K210_DTB_SOURCE))

will do the wrong thing later, and I get a non-bootable system (no output)
on my MAiX-BiT.

Unfortunately there is no def_string, so I don't think we can fix this
in a backwards-compatible way, and have to replace all
SOC_CANAAN_K210_DTB_SOURCE by ARCH_CANAAN_K210_DTB_SOURCE,
and urging users to update their .config manually.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv