From: Geert Uytterhoeven <geert@linux-m68k.org> To: Drew Fustini <drew@beagleboard.org> Cc: Rob Herring <robh+dt@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Michael Zhu <michael.zhu@starfivetech.com>, Fu Wei <tekkamanninja@gmail.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, linux-riscv <linux-riscv@lists.infradead.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Huan Feng <huan.feng@starfivetech.com> Subject: Re: [RFC PATH 1/2] dt-bindings: gpio: add starfive, jh7100-gpio bindings Date: Fri, 2 Jul 2021 23:03:56 +0200 [thread overview] Message-ID: <CAMuHMdXiebr7SnpShhcN9BPyha+=n=cNiX88q0wMVLrDY0r=qA@mail.gmail.com> (raw) In-Reply-To: <20210702205622.GA1035183@x1> Hi Drew, On Fri, Jul 2, 2021 at 10:56 PM Drew Fustini <drew@beagleboard.org> wrote: > On Thu, Jul 01, 2021 at 10:34:56AM +0200, Geert Uytterhoeven wrote: > > On Thu, Jul 1, 2021 at 2:22 AM Drew Fustini <drew@beagleboard.org> wrote: > > > Add bindings for the GPIO controller in the StarFive JH7100 SoC [1]. > > > > > > [1] https://github.com/starfive-tech/beaglev_doc > > > > > > Signed-off-by: Drew Fustini <drew@beagleboard.org> > > > Signed-off-by: Huan Feng <huan.feng@starfivetech.com> > > > > Thanks for your patch! > > > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/gpio/starfive,jh7100-gpio.yaml > > > @@ -0,0 +1,60 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/gpio/starfive,jh7100-gpio.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: StarFive JH7100 GPIO controller > > > + > > > +maintainers: > > > + - Huan Feng <huan.feng@starfivetech.com> > > > + - Drew Fustini <drew@beagleboard.org> > > > + > > > +properties: > > > + compatible: > > > + items: > > > + - const: starfive,jh7100-gpio > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + description: > > > + Interrupt mapping, one per GPIO. Maximum 32 GPIOs. > > > + minItems: 1 > > > + maxItems: 32 > > > > What about clocks and resets? > > Thank you for your feedback, Geert. > > GPIO controller uses clk_apb1_bus under dom0_sys. I believe the device > tree node would use something like this: > > clocks = <&clkgen JH7100_CLK_APB1>; > > I see the sifive-gpio.yaml has: > > clocks: > maxItems: 1 > > Would that be the correct way to do it for the starfive gpio yaml? Yep. > The reset for GPIO controller is presetn under dom_sys. Do you think > know you know an example that has reset in the YAML? Is there some code > that would actually make use of that information? > > > > > > + > > > + gpio-controller: true > > > + > > > + "#gpio-cells": > > > + const: 2 > > > + > > > + interrupt-controller: true > > > + > > > + "#interrupt-cells": > > > + const: 2 > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - interrupts > > > + - interrupt-controller > > > + - "#interrupt-cells" > > > + - "#gpio-cells" > > > + - gpio-controller > > Do you think I should add 'clocks' to 'required:'? I'm still having issues with i2c if the GPIO block lists a clock, due to fw_devlink dependencies. > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + gpio@11910000 { > > > + compatible = "starfive,jh7100-gpio"; > > > + reg = <0x11910000 0x10000>; > > > + gpio-controller; > > > + #gpio-cells = <2>; > > > + interrupt-controller; > > > + #interrupt-cells = <2>; > > > + interrupts = <32>; > > I would add: > > clocks = <&clkgen JH7100_CLK_APB1>; > > But I am not sure how reset would work? That should become "resets = <&rstgen JH7100_RSTN_GPIO_APB>", but we don't have the reset controller in Linux yet (we do in barebox). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-07-02 21:04 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-01 0:20 [RFC PATH 0/2] gpio: starfive-jh7100: Add StarFive JH7100 GPIO bindings and driver Drew Fustini 2021-07-01 0:20 ` [RFC PATH 1/2] dt-bindings: gpio: add starfive,jh7100-gpio bindings Drew Fustini 2021-07-01 8:34 ` [RFC PATH 1/2] dt-bindings: gpio: add starfive, jh7100-gpio bindings Geert Uytterhoeven 2021-07-02 20:56 ` [RFC PATH 1/2] dt-bindings: gpio: add starfive,jh7100-gpio bindings Drew Fustini 2021-07-02 21:03 ` Geert Uytterhoeven [this message] 2021-07-03 6:46 ` Drew Fustini 2021-07-03 8:49 ` [RFC PATH 1/2] dt-bindings: gpio: add starfive, jh7100-gpio bindings Geert Uytterhoeven 2021-07-01 0:20 ` [RFC PATH 2/2] gpio: starfive-jh7100: Add StarFive JH7100 GPIO driver Drew Fustini 2021-07-01 2:25 ` Bin Meng 2021-07-01 20:44 ` Drew Fustini 2021-07-01 6:39 ` Michael Walle 2021-07-01 20:33 ` Drew Fustini 2021-07-02 14:59 ` Michael Walle 2021-07-02 21:00 ` Drew Fustini 2021-07-23 21:04 ` Linus Walleij 2021-07-26 7:11 ` Drew Fustini 2021-07-26 7:21 ` Michael Walle 2021-07-27 5:28 ` Drew Fustini 2021-07-28 9:49 ` Michael Walle 2021-07-28 10:59 ` Emil Renner Berthing 2021-07-28 11:19 ` Michael Walle 2021-07-28 11:21 ` Emil Renner Berthing 2021-07-02 16:03 ` Andy Shevchenko 2021-07-02 21:06 ` Drew Fustini 2021-07-05 13:29 ` Michael Walle 2021-07-05 14:33 ` Matti Vaittinen 2021-07-15 1:49 ` Ley Foon Tan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMuHMdXiebr7SnpShhcN9BPyha+=n=cNiX88q0wMVLrDY0r=qA@mail.gmail.com' \ --to=geert@linux-m68k.org \ --cc=bgolaszewski@baylibre.com \ --cc=devicetree@vger.kernel.org \ --cc=drew@beagleboard.org \ --cc=huan.feng@starfivetech.com \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=michael.zhu@starfivetech.com \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=robh+dt@kernel.org \ --cc=tekkamanninja@gmail.com \ --subject='Re: [RFC PATH 1/2] dt-bindings: gpio: add starfive, jh7100-gpio bindings' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).