From: Zong Li <email@example.com> To: "Patrick Stählin" <firstname.lastname@example.org>, "Masami Hiramatsu" <email@example.com> Cc: Greentime Hu <firstname.lastname@example.org>, email@example.com, Albert Ou <firstname.lastname@example.org>, Anders Roxell <email@example.com>, Paul Walmsley <firstname.lastname@example.org> Subject: Re: [RFC/RFT 2/2] RISC-V: kprobes/kretprobe support Date: Thu, 19 Dec 2019 17:28:19 +0800 [thread overview] Message-ID: <CANXhq0peZCWZsh37zZVzoi7spSzTfz7v4H5AytiAENKJdWK_tA@mail.gmail.com> (raw) In-Reply-To: <email@example.com> On Wed, Dec 18, 2019 at 9:10 PM Patrick Stählin <firstname.lastname@example.org> wrote: > > Hi all > > On 18.12.19 10:14, Zong Li wrote: > > On Wed, Dec 18, 2019 at 5:09 PM Zong Li <email@example.com> wrote: > >> > >> From: firstname.lastname@example.org (Masami Hiramatsu) > >> > >> On Wed, 14 Nov 2018 21:52:57 +0100 > >> Patrick Staehlin <email@example.com> wrote: > >> > >>> Yeah, I think it's simpler. > >>> > >>> And I found that the kprobe_breakpoint_handler() was called without > >>> checking !user_mode(regs). In that case, you should add the check in > >>> front of kprobe_breakpoint_handler() call. > >>> > >>> Thank you, > >> > >> Hi all, > >> > >> Is there any update? I was wondering if this patch are keep going? If > >> not, I think I could pick it up to go head > > I am still working on it, albeit slowly, holiday season coming up here > in Switzerland may accelerate that a bit. All the feedback I got from > Masami has been implemented. As Masami's suggestion, I don't see stop_machine in your implementation , are there some concerns to use it on SMP? > Additionally I added instruction simulation for everything except memory > accesses. I am currently working on getting compressed instructions > decoded properly into regular instructions but that is very tedious work. > I guess I am two or three full days of work away from getting a RFC/RFT > v2 series ready I guess that will happen in early January. Thanks for the efforts. > > What I currently have is at , that is mostly untested as of now > (beware I will rebase/squash that branch regularly). What I could use > help with in the future (as in for v2), is somebody testing it on real > hardware, as I've never gotten any testing feedback on my original > patch-series (that would not have worked properly because of the lacking > cache-flush). I give some quick tests by using kprobe sanity test and simple LKM on Hifive Unleashed board, it seems to work normally. I could help to test your next version patch as well. > >  https://github.com/packi/linux/tree/kprobes-riscv > > Patrick
next prev parent reply other threads:[~2019-12-19 9:28 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-13 19:58 [RFC/RFT 0/2] " Patrick Stählin 2018-11-13 19:58 ` Patrick Stählin 2018-11-13 19:58 ` [RFC/RFT 1/2] RISC-V: Implement ptrace regs and stack API Patrick Stählin 2018-11-13 19:58 ` Patrick Stählin 2019-11-21 22:34 ` Paul Walmsley 2018-11-13 19:58 ` [RFC/RFT 2/2] RISC-V: kprobes/kretprobe support Patrick Stählin 2018-11-13 19:58 ` Patrick Stählin 2018-11-14 8:37 ` Masami Hiramatsu 2018-11-14 8:37 ` Masami Hiramatsu 2018-11-14 15:49 ` Masami Hiramatsu 2018-11-14 15:49 ` Masami Hiramatsu 2018-11-14 21:10 ` Patrick Staehlin 2018-11-14 21:10 ` Patrick Staehlin 2018-11-15 7:50 ` Masami Hiramatsu 2018-11-15 7:50 ` Masami Hiramatsu 2019-12-20 11:14 ` Paul Walmsley 2019-12-20 22:46 ` Paul Walmsley 2018-11-14 20:52 ` Patrick Staehlin 2018-11-14 20:52 ` Patrick Staehlin 2018-11-15 8:41 ` Masami Hiramatsu 2018-11-15 8:41 ` Masami Hiramatsu [not found] ` <CANXhq0qWwKRrz80Q3LSeQu-cH19otCF1my6dDGDxH0Q5j1RYYw@mail.gmail.com> [not found] ` <firstname.lastname@example.org> 2019-12-19 9:28 ` Zong Li [this message] 2020-03-31 2:45 ` Zong Li 2020-06-12 5:57 ` David Abdurachmanov 2020-06-17 12:58 ` Guo Ren 2020-06-17 14:54 ` Masami Hiramatsu 2020-06-18 16:14 ` Guo Ren 2020-07-05 14:57 ` Guo Ren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CANXhq0peZCWZsh37zZVzoi7spSzTfz7v4H5AytiAENKJdWK_tA@mail.gmail.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [RFC/RFT 2/2] RISC-V: kprobes/kretprobe support' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).