linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Zong Li <zong.li@sifive.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: android-kernel-team@google.com,
	linux-riscv <linux-riscv@lists.infradead.org>,
	Palmer Dabbelt <palmerdabbelt@google.com>
Subject: Re: [PATCH] RISC-V: Stop putting .sbss in .sdata
Date: Wed, 19 Feb 2020 17:26:09 +0800	[thread overview]
Message-ID: <CANXhq0qWejBztV7AzF9_ZkcqzHiuyvN2deedepgkVe-gWaf-xQ@mail.gmail.com> (raw)
In-Reply-To: <20200218212501.85799-1-palmer@dabbelt.com>

On Wed, Feb 19, 2020 at 5:26 AM Palmer Dabbelt <palmer@dabbelt.com> wrote:
>
> From: Palmer Dabbelt <palmerdabbelt@google.com>
>
> I don't know why we were doing this, as it's been there since the beginning.
> After d841f729e655 ("riscv: force hart_lottery to put in .sdata section") my
> guess would be that it made the kernel boot and we forgot to fix it more
> cleanly.
>
> The default .bss segment already contains the .sbss section, so we don't need
> to do anything additional to ensure the symbols in .sbss continue to work.
>
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
> ---
>  arch/riscv/kernel/vmlinux.lds.S | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/vmlinux.lds.S b/arch/riscv/kernel/vmlinux.lds.S
> index 1e0193ded420..a8fb52a00295 100644
> --- a/arch/riscv/kernel/vmlinux.lds.S
> +++ b/arch/riscv/kernel/vmlinux.lds.S
> @@ -64,7 +64,6 @@ SECTIONS
>                 *(.sdata*)
>                 /* End of data section */
>                 _edata = .;
> -               *(.sbss*)
>         }
>
>         BSS_SECTION(PAGE_SIZE, PAGE_SIZE, 0)
> --
> 2.25.0.265.gbab2e86ba0-goog
>

I had given a quick test for that. It works on RV32 and RV64.

Tested-by: Zong Li <zong.li@sifive.com>


  reply	other threads:[~2020-02-19  9:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18 21:25 [PATCH] RISC-V: Stop putting .sbss in .sdata Palmer Dabbelt
2020-02-19  9:26 ` Zong Li [this message]
2020-02-19 18:32   ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANXhq0qWejBztV7AzF9_ZkcqzHiuyvN2deedepgkVe-gWaf-xQ@mail.gmail.com \
    --to=zong.li@sifive.com \
    --cc=android-kernel-team@google.com \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=palmerdabbelt@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).