From: Pekka Enberg <penberg@gmail.com>
To: Guo Ren <guoren@kernel.org>
Cc: "Patrick Stählin" <me@packi.ch>,
"Guo Ren" <guoren@linux.alibaba.com>,
"Anup Patel" <anup@brainfault.org>,
"Palmer Dabbelt" <palmerdabbelt@google.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-csky@vger.kernel.org, "Atish Patra" <atish.patra@wdc.com>,
"Zong Li" <zong.li@sifive.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Greentime Hu" <greentime.hu@sifive.com>,
linux-riscv <linux-riscv@lists.infradead.org>,
bjorn.topel@gmail.com
Subject: Re: [PATCH V1 0/5] riscv: Add k/uprobe supported
Date: Sat, 4 Jul 2020 21:30:50 +0300 [thread overview]
Message-ID: <CAOJsxLFSH2_e03xo_HMqKAzVE+2Y9=hriv-Zu=GdVUHgDMgYtw@mail.gmail.com> (raw)
In-Reply-To: <CAJF2gTSYyj5rTUJW-yDDrrV7T3hUssAhGc0gnCntcQpuixNJzw@mail.gmail.com>
Hi Guo,
On Sat, Jul 4, 2020 at 6:34 AM <guoren@kernel.org> wrote:
> > > There is no single step exception in riscv ISA, so utilize ebreak to
> > > simulate. Some pc related instructions couldn't be executed out of line
> > > and some system/fence instructions couldn't be a trace site at all.
> > > So we give out a reject list and simulate list in decode-insn.c.
On Sat, Jul 4, 2020 at 2:40 PM Pekka Enberg <penberg@gmail.com> wrote:
> > Can you elaborate on what you mean by this? Why would you need a
> > single-step facility for kprobes? Is it for executing the instruction
> > that was replaced with a probe breakpoint?
On Sat, Jul 4, 2020 at 5:55 PM Guo Ren <guoren@kernel.org> wrote:
> It's the single-step exception, not single-step facility!
Aah, right, I didn't read the specification carefully enough. Thanks
for taking the time to clarify this!
FWIW, for the whole series:
Reviewed-by: Pekka Enberg <penberg@kernel.org>
- Pekka
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2020-07-04 18:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 3:34 [PATCH V1 0/5] riscv: Add k/uprobe supported guoren
2020-07-04 3:34 ` [PATCH V1 1/5] riscv: Fixup __vdso_gettimeofday broke dynamic ftrace guoren
2020-07-04 3:34 ` [PATCH V1 2/5] RISC-V: Implement ptrace regs and stack API guoren
2020-07-07 8:21 ` Zong Li
2020-07-04 3:34 ` [PATCH V1 3/5] riscv: Fixup compile error BUILD_BUG_ON failed guoren
2020-07-04 3:34 ` [PATCH V1 4/5] riscv: Add kprobes supported guoren
2020-07-06 10:11 ` Masami Hiramatsu
2020-07-07 8:25 ` Zong Li
2020-07-07 8:53 ` Guo Ren
2020-07-04 3:34 ` [PATCH V1 5/5] riscv: Add uprobes supported guoren
2020-07-07 15:28 ` kernel test robot
2020-07-04 6:39 ` [PATCH V1 0/5] riscv: Add k/uprobe supported Pekka Enberg
2020-07-04 14:55 ` Guo Ren
2020-07-04 18:30 ` Pekka Enberg [this message]
2020-07-14 18:43 ` Palmer Dabbelt
2020-07-15 5:01 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOJsxLFSH2_e03xo_HMqKAzVE+2Y9=hriv-Zu=GdVUHgDMgYtw@mail.gmail.com' \
--to=penberg@gmail.com \
--cc=anup@brainfault.org \
--cc=atish.patra@wdc.com \
--cc=bjorn.topel@gmail.com \
--cc=greentime.hu@sifive.com \
--cc=guoren@kernel.org \
--cc=guoren@linux.alibaba.com \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=me@packi.ch \
--cc=palmerdabbelt@google.com \
--cc=paul.walmsley@sifive.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).