From: Pekka Enberg <penberg@gmail.com>
To: Zong Li <zong.li@sifive.com>
Cc: linux-riscv <linux-riscv@lists.infradead.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
LKML <linux-kernel@vger.kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH 2/2] riscv: fix build warning of mm/pageattr
Date: Thu, 16 Jul 2020 10:13:32 +0300 [thread overview]
Message-ID: <CAOJsxLGfKzGfmA6kGds=n54SORq_=E+SgCoOPzMcsBJnVFeZRw@mail.gmail.com> (raw)
In-Reply-To: <CAOJsxLGHNd1DcStOALkQkcg8u25zj8Hpf0uF1kMj+uO127q+yQ@mail.gmail.com>
On Thu, Jul 16, 2020 at 10:11 AM Pekka Enberg <penberg@gmail.com> wrote:
>
> On Thu, Jul 16, 2020 at 9:16 AM Zong Li <zong.li@sifive.com> wrote:
> >
> > Add hearder for missing prototype. Also, static keyword should be at
> > beginning of declaration.
> >
> > Signed-off-by: Zong Li <zong.li@sifive.com>
>
> Which prototype is missing?
Aah, never mind, you mention them in the cover letter. I think patch
description would be a better place to ensure they end up in git logs.
For both patches:
Reviewed-by: Pekka Enberg <penberg@kernel.org>
- Pekka
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2020-07-16 7:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 6:15 [PATCH 0/2] Fix some build warnings when W=1 Zong Li
2020-07-16 6:15 ` [PATCH 1/2] riscv: Fix build warning for mm/init Zong Li
2020-07-16 6:15 ` [PATCH 2/2] riscv: fix build warning of mm/pageattr Zong Li
2020-07-16 7:11 ` Pekka Enberg
2020-07-16 7:13 ` Pekka Enberg [this message]
2020-07-16 7:24 ` Andreas Schwab
2020-07-16 7:46 ` Zong Li
2020-07-25 18:24 ` [PATCH 0/2] Fix some build warnings when W=1 Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOJsxLGfKzGfmA6kGds=n54SORq_=E+SgCoOPzMcsBJnVFeZRw@mail.gmail.com' \
--to=penberg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).