Linux-RISC-V Archive on lore.kernel.org
 help / color / Atom feed
* Re: [Bug 209317] ftrace kernel self test failure on RISC-V on 5.8, regression from 5.4.0
       [not found] ` <bug-209317-8243-E6Z0ICootN@https.bugzilla.kernel.org/>
@ 2020-09-28 15:13   ` Steven Rostedt
  2020-09-28 17:25     ` Atish Patra
  0 siblings, 1 reply; 5+ messages in thread
From: Steven Rostedt @ 2020-09-28 15:13 UTC (permalink / raw)
  To: Atish Patra
  Cc: Albert Ou, bugzilla-daemon, LKML, Palmer Dabbelt, Paul Walmsley,
	linux-riscv

On Sat, 26 Sep 2020 22:02:35 +0000
bugzilla-daemon@bugzilla.kernel.org wrote:

> https://bugzilla.kernel.org/show_bug.cgi?id=209317
> 
> --- Comment #4 from Colin Ian King (colin.king@canonical.com) ---
> Issue still in 5.9-rc6
> 


Atish,

As the issues bisects down to your commit, care to take a look at this.
(And take ownership of this bug)

-- Steve

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Bug 209317] ftrace kernel self test failure on RISC-V on 5.8, regression from 5.4.0
  2020-09-28 15:13   ` [Bug 209317] ftrace kernel self test failure on RISC-V on 5.8, regression from 5.4.0 Steven Rostedt
@ 2020-09-28 17:25     ` Atish Patra
  2020-10-03 17:33       ` Atish Patra
  0 siblings, 1 reply; 5+ messages in thread
From: Atish Patra @ 2020-09-28 17:25 UTC (permalink / raw)
  To: rostedt
  Cc: aou, bugzilla-daemon, linux-kernel, palmer, paul.walmsley, linux-riscv

On Mon, 2020-09-28 at 11:13 -0400, Steven Rostedt wrote:
> On Sat, 26 Sep 2020 22:02:35 +0000
> bugzilla-daemon@bugzilla.kernel.org wrote:
> 
> > https://bugzilla.kernel.org/show_bug.cgi?id=209317
> > 
> > --- Comment #4 from Colin Ian King (colin.king@canonical.com) ---
> > Issue still in 5.9-rc6
> > 
> 
> Atish,
> 
> As the issues bisects down to your commit, care to take a look at
> this.
> (And take ownership of this bug)
> 

Yes. I am already looking into this. Colin informed me about the bug
over the weekend.

I couldn't change the ownership as I am not part of the editbugs group.
I have sent an email to helpdesk@kernel.org for access.

> -- Steve

-- 
Regards,
Atish
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Bug 209317] ftrace kernel self test failure on RISC-V on 5.8, regression from 5.4.0
  2020-09-28 17:25     ` Atish Patra
@ 2020-10-03 17:33       ` Atish Patra
  2020-10-05  6:08         ` Zong Li
  0 siblings, 1 reply; 5+ messages in thread
From: Atish Patra @ 2020-10-03 17:33 UTC (permalink / raw)
  To: Alan Kao, Zong Li
  Cc: aou, bugzilla-daemon, linux-kernel, rostedt, Atish Patra, palmer,
	paul.walmsley, linux-riscv

Hi Alan and Zong,
I initially suspected ftrace is broken between v5.6 & v5.7 as Kolin pointed out.
I couldn't find any reason how the HSM patch is related. Zong's ftrace
patching code was also merged in that release.
However, I was able to reproduce the issue in the older kernel(v5.4)
as well on both Qemu & Unleashed hardware.
Here are the steps:

mount -t debugfs none /sys/kernel/debug/
cd /sys/kernel/debug/tracing
echo function_graph > current_tracer
echo function > current_tracer

It works for the first time with function_graph but writing any other
tracer crashes immediately.
Can you take a look to check if the bug is in ftrace infrastructure code ?

On Mon, Sep 28, 2020 at 10:25 AM Atish Patra <Atish.Patra@wdc.com> wrote:
>
> On Mon, 2020-09-28 at 11:13 -0400, Steven Rostedt wrote:
> > On Sat, 26 Sep 2020 22:02:35 +0000
> > bugzilla-daemon@bugzilla.kernel.org wrote:
> >
> > > https://bugzilla.kernel.org/show_bug.cgi?id=209317
> > >
> > > --- Comment #4 from Colin Ian King (colin.king@canonical.com) ---
> > > Issue still in 5.9-rc6
> > >
> >
> > Atish,
> >
> > As the issues bisects down to your commit, care to take a look at
> > this.
> > (And take ownership of this bug)
> >
>
> Yes. I am already looking into this. Colin informed me about the bug
> over the weekend.
>
> I couldn't change the ownership as I am not part of the editbugs group.
> I have sent an email to helpdesk@kernel.org for access.
>
> > -- Steve
>
> --
> Regards,
> Atish
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv



-- 
Regards,
Atish

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Bug 209317] ftrace kernel self test failure on RISC-V on 5.8, regression from 5.4.0
  2020-10-03 17:33       ` Atish Patra
@ 2020-10-05  6:08         ` Zong Li
  2020-10-05 18:47           ` Atish Patra
  0 siblings, 1 reply; 5+ messages in thread
From: Zong Li @ 2020-10-05  6:08 UTC (permalink / raw)
  To: Atish Patra
  Cc: aou, Alan Kao, bugzilla-daemon, linux-kernel, rostedt,
	Atish Patra, palmer, paul.walmsley, linux-riscv

Hi Atish,

I can take out some time to take a look at it together, if anyone here
fixes it or has ideas, please share the information, thanks.

On Sun, Oct 4, 2020 at 1:33 AM Atish Patra <atishp@atishpatra.org> wrote:
>
> Hi Alan and Zong,
> I initially suspected ftrace is broken between v5.6 & v5.7 as Kolin pointed out.
> I couldn't find any reason how the HSM patch is related. Zong's ftrace
> patching code was also merged in that release.
> However, I was able to reproduce the issue in the older kernel(v5.4)
> as well on both Qemu & Unleashed hardware.
> Here are the steps:
>
> mount -t debugfs none /sys/kernel/debug/
> cd /sys/kernel/debug/tracing
> echo function_graph > current_tracer
> echo function > current_tracer
>
> It works for the first time with function_graph but writing any other
> tracer crashes immediately.
> Can you take a look to check if the bug is in ftrace infrastructure code ?
>
> On Mon, Sep 28, 2020 at 10:25 AM Atish Patra <Atish.Patra@wdc.com> wrote:
> >
> > On Mon, 2020-09-28 at 11:13 -0400, Steven Rostedt wrote:
> > > On Sat, 26 Sep 2020 22:02:35 +0000
> > > bugzilla-daemon@bugzilla.kernel.org wrote:
> > >
> > > > https://bugzilla.kernel.org/show_bug.cgi?id=209317
> > > >
> > > > --- Comment #4 from Colin Ian King (colin.king@canonical.com) ---
> > > > Issue still in 5.9-rc6
> > > >
> > >
> > > Atish,
> > >
> > > As the issues bisects down to your commit, care to take a look at
> > > this.
> > > (And take ownership of this bug)
> > >
> >
> > Yes. I am already looking into this. Colin informed me about the bug
> > over the weekend.
> >
> > I couldn't change the ownership as I am not part of the editbugs group.
> > I have sent an email to helpdesk@kernel.org for access.
> >
> > > -- Steve
> >
> > --
> > Regards,
> > Atish
> > _______________________________________________
> > linux-riscv mailing list
> > linux-riscv@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-riscv
>
>
>
> --
> Regards,
> Atish

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Bug 209317] ftrace kernel self test failure on RISC-V on 5.8, regression from 5.4.0
  2020-10-05  6:08         ` Zong Li
@ 2020-10-05 18:47           ` Atish Patra
  0 siblings, 0 replies; 5+ messages in thread
From: Atish Patra @ 2020-10-05 18:47 UTC (permalink / raw)
  To: Zong Li
  Cc: aou, Alan Kao, bugzilla-daemon, linux-kernel, rostedt,
	Atish Patra, palmer, paul.walmsley, linux-riscv

On Sun, Oct 4, 2020 at 11:08 PM Zong Li <zong.li@sifive.com> wrote:
>
> Hi Atish,
>
> I can take out some time to take a look at it together, if anyone here
> fixes it or has ideas, please share the information, thanks.
>

Thanks. I observed this in case it helps.

Across kernels, the panic trace seems to point out the one of the
first two functions after patching is corrupted.
rcu_momentary_dyntick_idle or stop_machine_yield[1]

[1]https://elixir.bootlin.com/linux/v5.9-rc7/source/kernel/stop_machine.c#L213

I am suspecting nop was not replaced with the correct auipc+jalr pair?

> On Sun, Oct 4, 2020 at 1:33 AM Atish Patra <atishp@atishpatra.org> wrote:
> >
> > Hi Alan and Zong,
> > I initially suspected ftrace is broken between v5.6 & v5.7 as Kolin pointed out.
> > I couldn't find any reason how the HSM patch is related. Zong's ftrace
> > patching code was also merged in that release.
> > However, I was able to reproduce the issue in the older kernel(v5.4)
> > as well on both Qemu & Unleashed hardware.
> > Here are the steps:
> >
> > mount -t debugfs none /sys/kernel/debug/
> > cd /sys/kernel/debug/tracing
> > echo function_graph > current_tracer
> > echo function > current_tracer
> >
> > It works for the first time with function_graph but writing any other
> > tracer crashes immediately.
> > Can you take a look to check if the bug is in ftrace infrastructure code ?
> >
> > On Mon, Sep 28, 2020 at 10:25 AM Atish Patra <Atish.Patra@wdc.com> wrote:
> > >
> > > On Mon, 2020-09-28 at 11:13 -0400, Steven Rostedt wrote:
> > > > On Sat, 26 Sep 2020 22:02:35 +0000
> > > > bugzilla-daemon@bugzilla.kernel.org wrote:
> > > >
> > > > > https://bugzilla.kernel.org/show_bug.cgi?id=209317
> > > > >
> > > > > --- Comment #4 from Colin Ian King (colin.king@canonical.com) ---
> > > > > Issue still in 5.9-rc6
> > > > >
> > > >
> > > > Atish,
> > > >
> > > > As the issues bisects down to your commit, care to take a look at
> > > > this.
> > > > (And take ownership of this bug)
> > > >
> > >
> > > Yes. I am already looking into this. Colin informed me about the bug
> > > over the weekend.
> > >
> > > I couldn't change the ownership as I am not part of the editbugs group.
> > > I have sent an email to helpdesk@kernel.org for access.
> > >
> > > > -- Steve
> > >
> > > --
> > > Regards,
> > > Atish
> > > _______________________________________________
> > > linux-riscv mailing list
> > > linux-riscv@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/linux-riscv
> >
> >
> >
> > --
> > Regards,
> > Atish



-- 
Regards,
Atish

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-209317-8243@https.bugzilla.kernel.org/>
     [not found] ` <bug-209317-8243-E6Z0ICootN@https.bugzilla.kernel.org/>
2020-09-28 15:13   ` [Bug 209317] ftrace kernel self test failure on RISC-V on 5.8, regression from 5.4.0 Steven Rostedt
2020-09-28 17:25     ` Atish Patra
2020-10-03 17:33       ` Atish Patra
2020-10-05  6:08         ` Zong Li
2020-10-05 18:47           ` Atish Patra

Linux-RISC-V Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-riscv/0 linux-riscv/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-riscv linux-riscv/ https://lore.kernel.org/linux-riscv \
		linux-riscv@lists.infradead.org
	public-inbox-index linux-riscv

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-riscv


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git