From: Song Liu <song@kernel.org>
To: Luke Nelson <lukenels@cs.washington.edu>
Cc: "Song Liu" <songliubraving@fb.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jiong Wang" <jiong.wang@netronome.com>,
"Björn Töpel" <bjorn.topel@gmail.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Alexei Starovoitov" <ast@kernel.org>,
linux-riscv@lists.infradead.org,
"open list" <linux-kernel@vger.kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
Networking <netdev@vger.kernel.org>, "Yonghong Song" <yhs@fb.com>,
bpf <bpf@vger.kernel.org>, "Andrii Nakryiko" <andriin@fb.com>,
"Martin KaFai Lau" <kafai@fb.com>, "Xi Wang" <xi.wang@gmail.com>
Subject: Re: [PATCH v3 bpf-next] RV32G eBPF JIT
Date: Tue, 25 Feb 2020 14:56:00 -0800 [thread overview]
Message-ID: <CAPhsuW5mdL6CHSCqqwQnm3V4URONoaamPCGUD9zHSz84h3X2GA@mail.gmail.com> (raw)
In-Reply-To: <CADasFoBoEs+UArgqwQSqesKJhmvZEJP5so9nN-u9s6a3rQEUdA@mail.gmail.com>
On Tue, Feb 25, 2020 at 10:37 AM Luke Nelson <lukenels@cs.washington.edu> wrote:
>
>
> > I found a lot of common code between RV32G and RV64G. Can we move
> > these code into a header file?
>
> Certainly! I was planning on doing this in a separate patch to minimize the changes
> to the RV64 JIT. I can also do it in another revision of this patch if that seems like a better idea.
I would recommend expand this patch into two patches: one patch moves
common code
to a header, the other adds logic for RV32G.
Thanks,
Song
next prev parent reply other threads:[~2020-02-25 22:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 4:16 [PATCH v3 bpf-next] RV32G eBPF JIT Luke Nelson
2020-02-24 21:46 ` Song Liu
[not found] ` <CADasFoBoEs+UArgqwQSqesKJhmvZEJP5so9nN-u9s6a3rQEUdA@mail.gmail.com>
2020-02-25 22:56 ` Song Liu [this message]
2020-02-25 0:42 ` Alexei Starovoitov
2020-02-25 6:41 ` Björn Töpel
2020-02-28 14:24 ` Björn Töpel
2020-02-28 22:20 ` Luke Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPhsuW5mdL6CHSCqqwQnm3V4URONoaamPCGUD9zHSz84h3X2GA@mail.gmail.com \
--to=song@kernel.org \
--cc=andriin@fb.com \
--cc=aou@eecs.berkeley.edu \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jiong.wang@netronome.com \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lukenels@cs.washington.edu \
--cc=netdev@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=songliubraving@fb.com \
--cc=xi.wang@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).