From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50E88C43215 for ; Mon, 18 Nov 2019 07:50:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28552206F4 for ; Mon, 18 Nov 2019 07:50:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="T0sw1+i2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sifive.com header.i=@sifive.com header.b="AbHKXxVy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28552206F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0enV0D8UhVJ/1flFPGQXcxr69Iwf5Kn7NmcOjXAMbhc=; b=T0sw1+i2dJYYoG e9xo8F91TFwdxqiEtM89XIJZdnKepu0GwqFzzi1VLH1U7f0/zPK9B492EkvC7mP1bSdGcchXpBW0X YpUkcLsPAClUpkACvN0fmhdBcPHEiYOfYZT+J53P0DbS+YiKFYojYCJXnDMcPXdljf2SD3zFjgN1I sMVmQvbgRRuGFLtzZvty2B4ltARd5AuJwpLh1arEh70z3WUT2C7mUM63znT4rGIDFmYhMRvov969q VawovrEN8pKnpGh51l51CBQC1W4wEuRXJrtF4NohCCcQlY+h/TMWxDsgkEIzD1bhyIH5wj1Dv4jbK K4yNTAn5V7mHRx7WCDPw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWboG-0006xA-71; Mon, 18 Nov 2019 07:50:56 +0000 Received: from mail-eopbgr800081.outbound.protection.outlook.com ([40.107.80.81] helo=NAM03-DM3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWboC-0006w3-5m for linux-riscv@lists.infradead.org; Mon, 18 Nov 2019 07:50:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IpAibOMlo7EEscnED5tRpAs8Sx9E8lKOeapqOkdIE/v6wg4X1GBP2tiWOGqxfvytJoEt3fJng3r5eg88nrhn/O92f8u03JPGXQ/lE5UhvbKVeMOLAuMmbAjCQuMul5TNrwaPuqKP1FqaBGUpANbwwi5TZoY2lDYMVseI4J2zzmf6xziN3mAc11uvJi7tG9BLtiGSqHEChhiyZeXwI8Pv/4yjT1CzDxIAK1vQO9xARSbhxzIXukoCXlOY0sDF57tArRVEWnuSRjMr3TELdu+lkoq3xMhLOiih3CYlbbhkU3feJRCrlka4Jv44x2YRzMRa3eoGfp8xL+4AepSByhro6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3EOPxIJkiz0vUXdV0duYpOM6sD9HCm0NTTrHR7UMpK0=; b=h5wYGfeYzTbMZZDboMEzJQZZXTFs0n8cendDfRLv5sGt82ikJG4uoFFZ9kq1AWczPc9K72PY59Y2yUye6x3Yz0TQNtvrGZGUqiXvhAD8KS6D+NOsNflDO9DGYmL2FeGo9GkAKgZ9mX6+Vu9iH/gB+VAG2I/u/yk/z++eC3w6Z0qB6nPWNfWt5+nyOO273ABmfTb9+ZXsSJZzBHUqo6w2DUIMNqLw7eciFKymiSz+fzV9TnOUCsFitC8vjjmZGDJsHaUPIrMjZAH1ItS02TMf7/FwVAAfXZJibPfHLCPUGF1Oazl1W9yOUFFHcLwfasumK49HMDr/YbuiLFeRp8vqYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3EOPxIJkiz0vUXdV0duYpOM6sD9HCm0NTTrHR7UMpK0=; b=AbHKXxVyJJXKNx3uOcy6rmwEQV/R8hVkJXIu0bv1zsHvTwra0fqPxsR5D8Qx3YmA/1FFGhVqTWNHEH3IInfic4LVKXxfilVHhvUr0Y4kAmMqlBU2y+iwzNPYlto81uCCbiYauO/VmoSaPuCxPniZGdFZJRSW5PfOUgymgfez7Ec= Received: from CH2PR13MB3368.namprd13.prod.outlook.com (52.132.246.90) by CH2PR13MB3591.namprd13.prod.outlook.com (52.132.244.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.9; Mon, 18 Nov 2019 07:50:49 +0000 Received: from CH2PR13MB3368.namprd13.prod.outlook.com ([fe80::853e:1256:311e:d29]) by CH2PR13MB3368.namprd13.prod.outlook.com ([fe80::853e:1256:311e:d29%7]) with mapi id 15.20.2474.012; Mon, 18 Nov 2019 07:50:49 +0000 From: Yash Shah To: Marc Zyngier Subject: RE: [PATCH 3/4] gpio: sifive: Add GPIO driver for SiFive SoCs Thread-Topic: [PATCH 3/4] gpio: sifive: Add GPIO driver for SiFive SoCs Thread-Index: AQHVmVJqQXFGHo/64k2Vkr22HauCBaeHfxOAgAkN8OA= Date: Mon, 18 Nov 2019 07:50:48 +0000 Message-ID: References: <1573560684-48104-1-git-send-email-yash.shah@sifive.com> <1573560684-48104-4-git-send-email-yash.shah@sifive.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yash.shah@sifive.com; x-originating-ip: [114.143.65.226] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ac3fbad0-f9c1-4624-5976-08d76bfc0712 x-ms-traffictypediagnostic: CH2PR13MB3591: x-ld-processed: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0225B0D5BC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6029001)(346002)(39840400004)(396003)(136003)(366004)(376002)(13464003)(199004)(189003)(26005)(6506007)(186003)(55016002)(9686003)(6436002)(102836004)(33656002)(81156014)(486006)(44832011)(14454004)(6246003)(81166006)(8936002)(25786009)(11346002)(229853002)(76176011)(7696005)(8676002)(476003)(6916009)(76116006)(446003)(107886003)(66946007)(4326008)(66476007)(66556008)(64756008)(66446008)(6116002)(3846002)(66066001)(4001150100001)(53546011)(2906002)(54906003)(316002)(305945005)(71190400001)(52536014)(74316002)(478600001)(71200400001)(256004)(5660300002)(7736002)(99286004)(86362001)(7416002); DIR:OUT; SFP:1101; SCL:1; SRVR:CH2PR13MB3591; H:CH2PR13MB3368.namprd13.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: sifive.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WJkYap20R0uHot8uumffsd3UfTWqP+M5rhSNCEU/xAXV1JVN+HpE5MHqH8W05oRVWMBJhNERympMHKTpoO7vlzyXV6ftDL9EozT325REJo/OXMrhCJihwfMQeZzgUTwxL6ClZbYNeYllTayL0Sy0FK9BRYV25z05PBCzSKqFkyUMidKLcteOaSKH1O+KGjAwK1P7S89NQmeyqdcf0wWIMrcZMnjgdHsrs72OeKN00kqyLFP2tbh/Pzr9v4Bf98KMpUGIhNv3KnYh0rOoNfkyUuvkRhdQOzhhm6xpDduHv0UVOaeCNuP2lVaKazi1j2LIfeHUvoIc1T9Rf58oKis8rrlXkkUi2xkklcagE4pyByGnhKGVKXO3a7VWl3hSQ4QW2N1gq8s/7OqkALR53aPoW3qlPHTkRoWgAFBpmrxmjBxzWfzeyomjQqGAqS8kGIuD MIME-Version: 1.0 X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac3fbad0-f9c1-4624-5976-08d76bfc0712 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2019 07:50:48.9419 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jrOtzAVrdtJKSOWMHHV7yVecFNthirnvKBXLuQOnei6F+MPHg/hPB6D+NLlLIqmFUtvtjpCLBdzq1BVxJF/6Qg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB3591 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191117_235052_254666_13966CAD X-CRM114-Status: GOOD ( 12.20 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "aou@eecs.berkeley.edu" , "jason@lakedaemon.net" , "atish.patra@wdc.com" , Sachin Ghadi , "linus.walleij@linaro.org" , "linux-kernel@vger.kernel.org" , "bgolaszewski@baylibre.com" , "robh+dt@kernel.org" , "palmer@dabbelt.com" , Sagar Kadam , "linux-gpio@vger.kernel.org" , "Paul Walmsley \( Sifive\)" , "tglx@linutronix.de" , "bmeng.cn@gmail.com" , "linux-riscv@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Marc Zyngier > Sent: 12 November 2019 18:28 > To: Yash Shah > Cc: linus.walleij@linaro.org; bgolaszewski@baylibre.com; > robh+dt@kernel.org; mark.rutland@arm.com; palmer@dabbelt.com; Paul > Walmsley ( Sifive) ; aou@eecs.berkeley.edu; > tglx@linutronix.de; jason@lakedaemon.net; bmeng.cn@gmail.com; > atish.patra@wdc.com; Sagar Kadam ; linux- > gpio@vger.kernel.org; devicetree@vger.kernel.org; linux- > riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Sachin Ghadi > > Subject: Re: [PATCH 3/4] gpio: sifive: Add GPIO driver for SiFive SoCs > > On 2019-11-12 13:21, Yash Shah wrote: > > Adds the GPIO driver for SiFive RISC-V SoCs. > > > > Signed-off-by: Wesley W. Terpstra > > [Atish: Various fixes and code cleanup] > > Signed-off-by: Atish Patra > > Signed-off-by: Yash Shah > > [...] > > > +static int sifive_gpio_child_to_parent_hwirq(struct gpio_chip *gc, > > + unsigned int child, > > + unsigned int child_type, > > + unsigned int *parent, > > + unsigned int *parent_type) > > +{ > > + /* All these interrupts are level high in the CPU */ > > + *parent_type = IRQ_TYPE_LEVEL_HIGH; > > It is bizare that you enforce LEVEL_HIGH here, while setting it to NONE in the > PLIC driver. These things should be consistent. Will change this to IRQ_TYPE_NONE. > > > + *parent = child + 7; > > Irk, magic numbers... This is the offset for GPIO IRQs. Will add a macro for this. Thanks for your comments! - Yash _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv