From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1ECA8C4332F for ; Wed, 23 Nov 2022 15:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v+LbRyIWkzhbk0R0mqO3YN0pCE+3Pd/0zMxBkjanewA=; b=1x/99FziQYWYTW OEMHOb9QSZPpGvjdm1uGh/PPKDxzWMxlAzZbFqAesxAJMZUYVCVWiewK7KJ44Kkk07DRj+kqQUiy9 B5Y6dJFagiyWsHhXMlfwpjS/PWL32U5+wgdMV7/yazrSIpPXcl/8UW2TBv+FDSZufFtgJxW2LCkSL ucRUbXD2ydALr14cIYFFt/4uEz4cy/bHVKdcL3ivuxaKe3xIZNhriSPADBwTU8cELFh1+Jmw1iYXX u4i1/JhUIidwtMdA9XdrjUZFS5lCPzavSvADXTef6R+ntayd3gQ9tlC3ekpbwqAg+mG+IrwmyFBnQ O/VQsoAI06sRfYkBGBYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxrnd-000UtX-Af; Wed, 23 Nov 2022 15:36:33 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxrnZ-000Uql-RA for linux-riscv@lists.infradead.org; Wed, 23 Nov 2022 15:36:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 416E2B82108; Wed, 23 Nov 2022 15:36:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78167C433D6; Wed, 23 Nov 2022 15:36:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669217787; bh=HZhzktOoDe/GEDqHDGyY18dESmqG5q+xXSAft4Q3o64=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IBbNL7BwmqqR0QzV7oTARYzvN1gvt+4swSNBoNL1f4iLbmxaKN5y+LJVhmmix2mG1 b2kHDHcPpMf4/1+P+mep1JmxGuwQoyZU6l/wreh13C0Rs7sG/T6iXjX2htVPHQncIk IMQhkA7HpSVEqX4W+A8y5gTy6Totma2gQp6b5oKAV8C+HhLB6En9M5/D9QG9aUv6VQ JCYP//1Mq5gk7vgKahhC2VGx8YHFLIApBb9viPdzEmQncbUJ41s+8p4JJ5kMxv9yQw SBlOQBTOJcNXuyse0/Ve52k20hX+mxQOF1uxY/HoFb83SBv74ldSa7+Gz0gveoyGEX UG4JzM72Xjmmw== Date: Wed, 23 Nov 2022 23:26:32 +0800 From: Jisheng Zhang To: guoren@kernel.org Cc: arnd@arndb.de, palmer@rivosinc.com, tglx@linutronix.de, peterz@infradead.org, luto@kernel.org, conor.dooley@microchip.com, heiko@sntech.de, lazyparser@gmail.com, falcon@tinylab.org, chenhuacai@kernel.org, apatel@ventanamicro.com, atishp@atishpatra.org, palmer@dabbelt.com, paul.walmsley@sifive.com, mark.rutland@arm.com, zouyipeng@huawei.com, bigeasy@linutronix.de, David.Laight@aculab.com, chenzhongjin@huawei.com, greentime.hu@sifive.com, andy.chiu@sifive.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Guo Ren Subject: Re: [PATCH -next V8 00/14] riscv: Add GENERIC_ENTRY support and related features Message-ID: References: <20221103075047.1634923-1-guoren@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221103075047.1634923-1-guoren@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221123_073630_188356_2DC68E94 X-CRM114-Status: GOOD ( 20.81 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Nov 03, 2022 at 03:50:33AM -0400, guoren@kernel.org wrote: > From: Guo Ren > > The patches convert riscv to use the generic entry infrastructure from > kernel/entry/*. Additionally, add independent irq stacks (IRQ_STACKS) > for percpu to prevent kernel stack overflows. Add generic_entry based > STACKLEAK support. Some optimization for entry.S with new .macro and > merge ret_from_kernel_thread into ret_from_fork. > > We have tested it with rv64, rv32, rv64 + 32rootfs, all are passed. > > You can directly try it with: > [1] https://github.com/guoren83/linux/tree/generic_entry_v8 > > Any reviews and tests are helpful. Thanks for this series, Tested-by: Jisheng Zhang > > v8: > - Rebase on palmer/for-next branch (20221102) > - Add save/restore_from_x5_to_x31 .macro (JishengZhang) > - Consolidate ret_from_kernel_thread into ret_from_fork (JishengZhang) > - Optimize __noinstr_section comment (JiangshanLai) > > v7: > https://lore.kernel.org/linux-riscv/20221015114702.3489989-1-guoren@kernel.org/ > - Fixup regs_irqs_disabled with SR_PIE > - Optimize stackleak_erase -> stackleak_erase_on_task_stack (Thx Mark > Rutland) > - Add BUG_ON(!irqs_disabled()) in trap handlers > - Using regs_irqs_disabled in __do_page_fault > - Remove unnecessary irq disable in ret_from_exception and add comment > > v6: > https://lore.kernel.org/linux-riscv/20221002012451.2351127-1-guoren@kernel.org/ > - Use THEAD_SIZE_ORDER for thread size adjustment in kconfig (Thx Arnd) > - Move call_on_stack to inline style (Thx Peter Zijlstra) > - Fixup fp chain broken (Thx Chen Zhongjin) > - Remove common entry modification, and fixup page_fault entry (Thx > Peter Zijlstra) > - Treat some traps as nmi entry (Thx Peter Zijlstra) > > v5: > https://lore.kernel.org/linux-riscv/20220918155246.1203293-1-guoren@kernel.org/ > - Add riscv own stackleak patch instead of generic entry modification > (by Mark Rutland) > - Add EXPERT dependency for THREAD_SIZE (by Arnd) > - Add EXPERT dependency for IRQ_STACK (by Sebastian, David Laight) > - Corrected __trap_section (by Peter Zijlstra) > - Add Tested-by (Yipeng Zou) > - Use CONFIG_SOFTIRQ_ON_OWN_STACK replace "#ifndef CONFIG_PREEMPT_RT" > - Fixup systrace_enter compile error > - Fixup exit_to_user_mode_prepare preempt_disable warning > > V4: > https://lore.kernel.org/linux-riscv/20220908022506.1275799-1-guoren@kernel.org/ > - Fixup entry.S with "la" bug (by Conor.Dooley) > - Fixup missing noinstr bug (by Peter Zijlstra) > > V3: > https://lore.kernel.org/linux-riscv/20220906035423.634617-1-guoren@kernel.org/ > - Fixup CONFIG_COMPAT=n compile error > - Add THREAD_SIZE_ORDER config > - Optimize elf_kexec.c warning fixup > - Add static to irq_stack_ptr definition > > V2: > https://lore.kernel.org/linux-riscv/20220904072637.8619-1-guoren@kernel.org/ > - Fixup compile error by include "riscv: ptrace: Remove duplicate > operation" > - Fixup compile warning > Reported-by: kernel test robot > - Add test repo link in cover letter > > V1: > https://lore.kernel.org/linux-riscv/20220903163808.1954131-1-guoren@kernel.org/ > > > Dao Lu (1): > riscv: Add support for STACKLEAK gcc plugin > > Guo Ren (9): > riscv: elf_kexec: Fixup compile warning > riscv: compat_syscall_table: Fixup compile warning > riscv: ptrace: Remove duplicate operation > riscv: traps: Add noinstr to prevent instrumentation inserted > riscv: convert to generic entry > riscv: Support HAVE_IRQ_EXIT_ON_IRQ_STACK > riscv: Support HAVE_SOFTIRQ_ON_OWN_STACK > riscv: Add config of thread stack size > riscv: Typo fixup for addi -> andi in comment > > Jisheng Zhang (3): > riscv: remove extra level wrappers of trace_hardirqs_{on,off} > riscv: consolidate ret_from_kernel_thread into ret_from_fork > riscv: entry: consolidate general regs saving/restoring > > Lai Jiangshan (1): > compiler_types.h: Add __noinstr_section() for noinstr > > arch/riscv/Kconfig | 21 ++ > arch/riscv/include/asm/asm.h | 63 +++++ > arch/riscv/include/asm/csr.h | 1 - > arch/riscv/include/asm/entry-common.h | 8 + > arch/riscv/include/asm/ptrace.h | 10 +- > arch/riscv/include/asm/stacktrace.h | 5 + > arch/riscv/include/asm/syscall.h | 6 + > arch/riscv/include/asm/thread_info.h | 27 +-- > arch/riscv/include/asm/vmap_stack.h | 28 +++ > arch/riscv/kernel/Makefile | 3 +- > arch/riscv/kernel/elf_kexec.c | 2 +- > arch/riscv/kernel/entry.S | 327 +++----------------------- > arch/riscv/kernel/irq.c | 110 +++++++++ > arch/riscv/kernel/mcount-dyn.S | 56 +---- > arch/riscv/kernel/process.c | 5 +- > arch/riscv/kernel/ptrace.c | 44 ---- > arch/riscv/kernel/signal.c | 21 +- > arch/riscv/kernel/sys_riscv.c | 27 +++ > arch/riscv/kernel/trace_irq.c | 27 --- > arch/riscv/kernel/trace_irq.h | 11 - > arch/riscv/kernel/traps.c | 74 ++++-- > arch/riscv/mm/fault.c | 16 +- > drivers/firmware/efi/libstub/Makefile | 2 +- > include/linux/compiler_types.h | 15 +- > 24 files changed, 407 insertions(+), 502 deletions(-) > create mode 100644 arch/riscv/include/asm/entry-common.h > create mode 100644 arch/riscv/include/asm/vmap_stack.h > delete mode 100644 arch/riscv/kernel/trace_irq.c > delete mode 100644 arch/riscv/kernel/trace_irq.h > > -- > 2.36.1 > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv