From: Conor Dooley <conor@kernel.org>
To: guoren@kernel.org
Cc: palmer@rivosinc.com, conor.dooley@microchip.com,
liaochang1@huawei.com, lizhengyu3@huawei.com,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org,
Guo Ren <guoren@linux.alibaba.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] riscv: Fixup compile error with !MMU
Date: Wed, 7 Dec 2022 09:32:20 +0000 [thread overview]
Message-ID: <Y5BdpHrKrRCw9izQ@spud> (raw)
In-Reply-To: <20221207091112.2258674-1-guoren@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 1644 bytes --]
On Wed, Dec 07, 2022 at 04:11:12AM -0500, guoren@kernel.org wrote:
> From: Guo Ren <guoren@linux.alibaba.com>
>
> Current nommu_virt_defconfig can't compile:
>
> In file included from
> arch/riscv/kernel/crash_core.c:3:
> arch/riscv/kernel/crash_core.c:
> In function 'arch_crash_save_vmcoreinfo':
> arch/riscv/kernel/crash_core.c:8:27:
> error: 'VA_BITS' undeclared (first use in this function)
> 8 | VMCOREINFO_NUMBER(VA_BITS);
> | ^~~~~~~
>
> Add MMU dependency for KEXEC_FILE.
>
> Fixes: 6261586e0c91 ("RISC-V: Add kexec_file support")
> Reported-by: Conor Dooley <conor@kernel.org>
FWIW (but certainly don't resend for this)
s/conor@kernel.org/conor.dooley@microchip.com
Thanks for the quick fix, there's other issues w/ that config for me,
but this fixed the kexec bits :)
Tested-by: Conor Dooley <conor.dooley@microchip.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> ---
> arch/riscv/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index ef8d66de5f38..91319044fd13 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -496,7 +496,7 @@ config KEXEC_FILE
> select KEXEC_CORE
> select KEXEC_ELF
> select HAVE_IMA_KEXEC if IMA
> - depends on 64BIT
> + depends on 64BIT && MMU
> help
> This is new version of kexec system call. This system call is
> file based and takes file descriptors as system call argument
> --
> 2.36.1
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-12-07 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 9:11 [PATCH] riscv: Fixup compile error with !MMU guoren
2022-12-07 9:32 ` Conor Dooley [this message]
2022-12-07 14:01 ` Guo Ren
2022-12-13 17:39 ` Palmer Dabbelt
2022-12-13 17:40 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5BdpHrKrRCw9izQ@spud \
--to=conor@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=guoren@kernel.org \
--cc=guoren@linux.alibaba.com \
--cc=liaochang1@huawei.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lizhengyu3@huawei.com \
--cc=lkp@intel.com \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).