From: Sergey Matyukevich <geomatsi@gmail.com>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org,
Anup Patel <anup@brainfault.org>,
Atish Patra <atishp@rivosinc.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Guo Ren <guoren@kernel.org>,
Alexandre Ghiti <alexandre.ghiti@canonical.com>,
Heiko Stuebner <heiko@sntech.de>,
Sergey Matyukevich <sergey.matyukevich@syntacore.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Conor Dooley <Conor.Dooley@microchip.com>
Subject: Re: [RFC PATCH 1/1] riscv: mm: notify remote harts about mmu cache updates
Date: Fri, 23 Dec 2022 00:14:51 +0300 [thread overview]
Message-ID: <Y6TIywUWZ3nrPeon@curiosity> (raw)
In-Reply-To: <CA+V-a8u0qUF81RUTF9+4T4F1GxW3=4P7RMTTjjsaMq4MiiQSMQ@mail.gmail.com>
Hi Prabhakar,
> > > > From: Sergey Matyukevich <sergey.matyukevich@syntacore.com>
> > > >
> > > > Current implementation of update_mmu_cache function performs local TLB
> > > > flush. It does not take into account ASID information. Besides, it does
> > > > not take into account other harts currently running the same mm context
> > > > or possible migration of the running context to other harts. Meanwhile
> > > > TLB flush is not performed for every context switch if ASID support
> > > > is enabled.
> > > >
> > > > Patch [1] proposed to add ASID support to update_mmu_cache to avoid
> > > > flushing local TLB entirely. This patch takes into account other
> > > > harts currently running the same mm context as well as possible
> > > > migration of this context to other harts.
> > > >
> > > > For this purpose the approach from flush_icache_mm is reused. Remote
> > > > harts currently running the same mm context are informed via SBI calls
> > > > that they need to flush their local TLBs. All the other harts are marked
> > > > as needing a deferred TLB flush when this mm context runs on them.
> > > >
> > > > [1] https://lore.kernel.org/linux-riscv/20220821013926.8968-1-tjytimi@163.com/
> > > >
> > > > Signed-off-by: Sergey Matyukevich <sergey.matyukevich@syntacore.com>
> > > > ---
> > > > arch/riscv/include/asm/mmu.h | 2 ++
> > > > arch/riscv/include/asm/pgtable.h | 2 +-
> > > > arch/riscv/include/asm/tlbflush.h | 18 ++++++++++++++++++
> > > > arch/riscv/mm/context.c | 10 ++++++++++
> > > > arch/riscv/mm/tlbflush.c | 28 +++++++++++-----------------
> > > > 5 files changed, 42 insertions(+), 18 deletions(-)
> > > >
> <snip>
> > > [ 133.008752] Hardware name: Renesas SMARC EVK based on r9a07g043f01 (DT)
> > > [ 133.015338] Call Trace:
> > > [ 133.017778] [<ffffffff800055cc>] dump_backtrace+0x1c/0x24
> > > [ 133.023174] [<ffffffff80776836>] show_stack+0x2c/0x38
> > > [ 133.028214] [<ffffffff80780244>] dump_stack_lvl+0x3c/0x54
> > > [ 133.033597] [<ffffffff80780270>] dump_stack+0x14/0x1c
> > > [ 133.038633] [<ffffffff80776c00>] panic+0x102/0x29a
> > > [ 133.043409] [<ffffffff800137ba>] do_exit+0x704/0x70a
> > > [ 133.048362] [<ffffffff8001390e>] do_group_exit+0x24/0x70
> > > [ 133.053659] [<ffffffff8001de54>] get_signal+0x68a/0x6dc
> > > [ 133.058874] [<ffffffff8000494e>] do_work_pending+0xd6/0x44e
> > > [ 133.064427] [<ffffffff800036c2>] resume_userspace_slow+0x8/0xa
> > > [ 133.070249] ---[ end Kernel panic - not syncing: Attempted to kill
> > > init! exitcode=0x0000000b ]---
> > >
> > > If I revert this patch [0] bonnie++ works as expected.
> > >
> > > Any pointers on what could be the issue here?
> > >
> > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/palmer/linux.git/commit/?h=for-next&id=4bd1d80efb5af640f99157f39b50fb11326ce641
> > >
> > > Cheers,
> > > Prabhakar
> >
> > Good catch. Thanks for reporting ! Discussion around the issue and
> > possible ways to fix it can be found in the following email thread:
> >
> > https://lore.kernel.org/linux-riscv/20221111075902.798571-1-guoren@kernel.org/
> >
> > Could you please apply the patch from Guo Ren instead of [0] and check
> > if you have any issues with your test ? Besides, could you please share
> > your kernel configuration and the actual bonnie++ params from emmc_t_002.sh script ?
> >
> Thanks for the pointer, I'll undo my changes and test Guo's patch.
>
> I have pasted the script here [0] and attached config.
>
> [0] https://paste.debian.net/hidden/a7a769b5/
Thanks for the script and config. Could you please also share the
following information:
- how many cores your system has
- does your system support ASID
Regards,
Sergey
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-12-22 21:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 20:52 [RFC PATCH 1/1] riscv: mm: notify remote harts about mmu cache updates Sergey Matyukevich
2022-12-22 17:50 ` Lad, Prabhakar
2022-12-22 19:54 ` Sergey Matyukevich
2022-12-22 21:00 ` Lad, Prabhakar
2022-12-22 21:14 ` Sergey Matyukevich [this message]
2022-12-22 21:26 ` Lad, Prabhakar
2022-12-22 22:20 ` Sergey Matyukevich
2022-12-23 13:02 ` Lad, Prabhakar
2022-12-23 17:22 ` Sergey Matyukevich
2022-12-24 8:46 ` Lad, Prabhakar
2022-12-24 11:48 ` Sergey Matyukevich
2022-12-30 16:15 ` Lad, Prabhakar
2022-12-30 16:53 ` Sergey Matyukevich
2022-12-30 17:28 ` Lad, Prabhakar
2023-01-26 17:17 ` Lad, Prabhakar
2023-01-26 20:07 ` Sergey Matyukevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6TIywUWZ3nrPeon@curiosity \
--to=geomatsi@gmail.com \
--cc=Conor.Dooley@microchip.com \
--cc=alexandre.ghiti@canonical.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@rivosinc.com \
--cc=geert+renesas@glider.be \
--cc=guoren@kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=prabhakar.csengg@gmail.com \
--cc=sergey.matyukevich@syntacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).