From: Stafford Horne <shorne@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Pierre Morel <pmorel@linux.ibm.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-csky@vger.kernel.org,
linux-riscv <linux-riscv@lists.infradead.org>,
linux-um <linux-um@lists.infradead.org>,
linux-pci <linux-pci@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH v5 4/4] asm-generic: Add new pci.h and use it
Date: Sat, 23 Jul 2022 06:43:31 +0900 [thread overview]
Message-ID: <YtsaA2Zjqa/XZZou@antec> (raw)
In-Reply-To: <CAK8P3a3T0GvYyRgw=ojD_wts_pfdzfqXS8iNfUYuByBvLF9SGQ@mail.gmail.com>
On Fri, Jul 22, 2022 at 09:53:07AM +0200, Arnd Bergmann wrote:
> On Thu, Jul 21, 2022 at 11:58 PM Stafford Horne <shorne@gmail.com> wrote:
> > On Thu, Jul 21, 2022 at 12:37:33PM -0500, Bjorn Helgaas wrote:
>
> >
> > Thanks, you are right, I think some of the earlier functions may have needed it,
> > which is why I had it earlier. But now that we have removed those we should be
> > able to remove this.
> >
> > That said, I think some of the architecture includes could also be removed. On
> > OpenRISC we are able to get away with only having the global asm-generic/pci.h
> > so we don't need a wrapper pci.h header at all.
> >
> > However, I don't have everything setup to build all of those architectures so I
> > was being a bit conservative to remove headers. I'll see what I can do in the
> > next version.
>
> No need to worry about linux/types.h, this is pretty much included everywhere
> already and neither the risk of extraneous includes or missing ones is
> something to worry about. I'd just remove it if you do another respin, or
> we can leave it in if Bjorn wants to just apply the v5 version.
I will respin a v6 as we didn't get a reply on this. Bjorn are you planning to
apply the series before the upcoming merge window?
Originally I was thinking to merge these with my OpenRISC PCI support patches as
OpenRISC depends on this. However, the series is getting a bit more involved
for OpenRISC only.
Once you get it merged I will like to rebase my OpenRISC PCI support patches on
you branch. Hopefully, we can make it by the merge window.
Also, Palmer has a conflict with the series and his RISC-V for-next branch.
He would like to have a tag or branch to be able to merge into is branch to
resolve the conflict.
-Stafford
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-07-22 21:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 13:49 [PATCH v5 0/4] Cleanups for asm-generic/pci.h Stafford Horne
2022-07-21 13:49 ` [PATCH v5 1/4] PCI: Remove pci_get_legacy_ide_irq and asm-generic/pci.h Stafford Horne
2022-07-21 13:49 ` [PATCH v5 2/4] PCI: Move isa_dma_bridge_buggy out of dma.h Stafford Horne
2022-07-21 13:49 ` [PATCH v5 4/4] asm-generic: Add new pci.h and use it Stafford Horne
2022-07-21 17:37 ` Bjorn Helgaas
2022-07-21 21:58 ` Stafford Horne
2022-07-22 7:53 ` Arnd Bergmann
2022-07-22 21:43 ` Stafford Horne [this message]
2022-07-22 22:31 ` Bjorn Helgaas
2022-07-22 22:56 ` Stafford Horne
2022-07-22 23:37 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtsaA2Zjqa/XZZou@antec \
--to=shorne@gmail.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=geert@linux-m68k.org \
--cc=guoren@kernel.org \
--cc=helgaas@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pmorel@linux.ibm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=richard@nod.at \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).