From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1B55C43334 for ; Mon, 25 Jul 2022 20:49:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IF3im/aO6SeHdA8DwokfcCyyk/WtkWn3+JZLtcoeA3A=; b=t3+7nVqdJ/+R9A kF8z0mImNXQhccNRE3UmoTSwHDisYqHCrJj7o/3d+KmNpSIHPU6FO+qmbCqsgx6oM1joNmx6WQRbg t0DtAUHQcr6bACg9OV8+elkC8omJ389mU2ojN+jRYrCj0d+HVi6QMPBzdVcPO17B+9L3+btqwUo9/ ossmWgKTx/yAkCRzkVytFVGrnXOt6Y4ngVoCl8KIl7dmlXroLFwrM25pfM7r2n5xeKM887P+ONoom rEZXa3OkTVvvyPgVyjtc4ntZX/3LFDAFFWqC+sv1/eAe/IgIpxh9nUwptdNDJaowJa1IYLVYo3dD3 tPC61RhUqYhzqMo7YmCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oG50V-002DXi-5Z; Mon, 25 Jul 2022 20:48:51 +0000 Received: from imap5.colo.codethink.co.uk ([78.40.148.171]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oG50S-002DSI-1e; Mon, 25 Jul 2022 20:48:49 +0000 Received: from cpc152649-stkp13-2-0-cust121.10-2.cable.virginm.net ([86.15.83.122] helo=[192.168.0.17]) by imap5.colo.codethink.co.uk with esmtpsa (Exim 4.94.2 #2 (Debian)) id 1oG508-006V3d-JH; Mon, 25 Jul 2022 21:48:29 +0100 Message-ID: Date: Mon, 25 Jul 2022 21:48:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] profile: setup_profiling_timer() is moslty not implemented Content-Language: en-GB To: Andrew Morton , Ben Dooks Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-parisc@vger.kernel.org, openrisc@lists.librecores.org, linux-ia64@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-csky@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-snps-arc@lists.infradead.org, linux-alpha@vger.kernel.org References: <20220721195509.418205-1-ben-linux@fluff.org> <20220725123948.f16674b10022404814161d4a@linux-foundation.org> From: Ben Dooks Organization: Codethink Limited. In-Reply-To: <20220725123948.f16674b10022404814161d4a@linux-foundation.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220725_134848_137097_ED802FE0 X-CRM114-Status: GOOD ( 13.93 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 25/07/2022 20:39, Andrew Morton wrote: > On Thu, 21 Jul 2022 20:55:09 +0100 Ben Dooks wrote: > >> The setup_profiling_timer() is mostly un-implemented by many >> architectures. In many places it isn't guarded by CONFIG_PROFILE >> which is needed for it to be used. Make it a weak symbol in >> kernel/profile.c and remove the 'return -EINVAL' implementations >> from the kenrel. >> >> There are a couple of architectures which do return 0 from >> the setup_profiling_timer() function but they don't seem to >> do anything else with it. To keep the /proc compatibility for >> now, leave these for a future update or removal. >> >> On ARM, this fixes the following sparse warning: >> arch/arm/kernel/smp.c:793:5: warning: symbol 'setup_profiling_timer' was not declared. Should it be static? > > I'll grab this. > > We have had some problems with weak functions lately. See > > https://lore.kernel.org/all/87ee0q7b92.fsf@email.froward.int.ebiederm.org/T/#u > > Hopefully that was a rare corner case. Great, thanks. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv