From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Anup Patel <Anup.Patel@wdc.com>,
"seanga2@gmail.com" <seanga2@gmail.com>,
Atish Patra <Atish.Patra@wdc.com>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v16 09/16] riscv: Update Canaan Kendryte K210 device tree
Date: Sat, 6 Feb 2021 00:13:33 +0000 [thread overview]
Message-ID: <aab05bea310fbdbac38990656647dd0fbf3c8323.camel@wdc.com> (raw)
In-Reply-To: <20210205202505.GA3625674@robh.at.kernel.org>
On Fri, 2021-02-05 at 14:25 -0600, Rob Herring wrote:
[...]
> > + otp0: nvmem@50420000 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "canaan,k210-otp";
> > + reg = <0x50420000 0x100>,
> > + <0x88000000 0x20000>;
> > + reg-names = "reg", "mem";
> > + clocks = <&sysclk K210_CLK_ROM>;
> > + resets = <&sysrst K210_RST_ROM>;
> > + read-only;
> > + status = "disabled";
>
> Your disabled nodes seem a bit excessive. A device should really only be
> disabled if it's a board level decision to use or not. I'd assume the
> OTP is always there and usable.
Please see below.
>
> > +
> > + /* Bootloader */
> > + firmware@00000 {
>
> Drop leading 0s.
>
> Is this memory mapped? If so, you are missing 'ranges' in the parent to
> make it translateable.
>
> > + reg = <0x00000 0xC200>;
> > + };
> > +
> > + /*
> > + * config string as described in RISC-V
> > + * privileged spec 1.9
> > + */
> > + config-1-9@1c000 {
> > + reg = <0x1C000 0x1000>;
> > + };
> > +
> > + /*
> > + * Device tree containing only registers,
> > + * interrupts, and cpus
> > + */
> > + fdt@1d000 {
> > + reg = <0x1D000 0x2000>;
> > + };
> > +
> > + /* CPU/ROM credits */
> > + credits@1f000 {
> > + reg = <0x1F000 0x1000>;
> > + };
> > + };
> > +
> > + dvp0: camera@50430000 {
> > + compatible = "canaan,k210-dvp";
>
> No documented. Seems to be several of them.
There are no Linux drivers for these undocumented nodes. That is why I did not
add any documentation. make dtbs_check does not complain about that as long as
the nodes are marked disabled. I kept these nodes to have the DTS in sync with
U-Boot which has them. Keeping them also creates documentation for the SoC
since this device tree is more detailed than the SoC specsheet...
I removed "status = disabled;" from all nodes that have a Linux driver and kept
it for all nodes that don't have one.
--
Damien Le Moal
Western Digital Research
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-02-06 0:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 6:58 [PATCH v16 00/16] RISC-V Kendryte K210 support improvements Damien Le Moal
2021-02-05 6:58 ` [PATCH v16 01/16] clk: Add RISC-V Canaan Kendryte K210 clock driver Damien Le Moal
2021-02-05 6:58 ` [PATCH v16 02/16] dt-bindings: add Canaan boards compatible strings Damien Le Moal
2021-02-05 6:58 ` [PATCH v16 03/16] dt-bindings: update risc-v cpu properties Damien Le Moal
2021-02-05 19:47 ` Rob Herring
2021-02-05 6:58 ` [PATCH v16 04/16] dt-bindings: update sifive plic compatible string Damien Le Moal
2021-02-05 19:47 ` Rob Herring
2021-02-05 6:58 ` [PATCH v16 05/16] dt-bindings: update sifive clint " Damien Le Moal
2021-02-05 19:48 ` Rob Herring
2021-02-05 6:58 ` [PATCH v16 06/16] dt-bindings: update sifive uart " Damien Le Moal
2021-02-05 6:58 ` [PATCH v16 07/16] dt-bindings: fix sifive gpio properties Damien Le Moal
2021-02-05 6:58 ` [PATCH v16 08/16] dt-bindings: add resets property to dw-apb-timer Damien Le Moal
2021-02-05 6:58 ` [PATCH v16 09/16] riscv: Update Canaan Kendryte K210 device tree Damien Le Moal
2021-02-05 20:25 ` Rob Herring
2021-02-05 22:52 ` Sean Anderson
2021-02-05 23:49 ` Damien Le Moal
2021-02-08 19:49 ` Rob Herring
2021-02-08 22:41 ` Damien Le Moal
2021-02-06 0:13 ` Damien Le Moal [this message]
2021-02-08 20:00 ` Rob Herring
2021-02-08 22:53 ` Sean Anderson
2021-02-08 22:55 ` Damien Le Moal
2021-02-08 23:04 ` Sean Anderson
2021-02-09 0:12 ` Damien Le Moal
2021-02-05 6:58 ` [PATCH v16 10/16] riscv: Add SiPeed MAIX BiT board " Damien Le Moal
2021-02-05 6:58 ` [PATCH v16 11/16] riscv: Add SiPeed MAIX DOCK " Damien Le Moal
2021-02-05 6:58 ` [PATCH v16 12/16] riscv: Add SiPeed MAIX GO " Damien Le Moal
2021-02-05 6:58 ` [PATCH v16 13/16] riscv: Add SiPeed MAIXDUINO " Damien Le Moal
2021-02-05 6:58 ` [PATCH v16 14/16] riscv: Add Kendryte KD233 " Damien Le Moal
2021-02-05 6:58 ` [PATCH v16 15/16] riscv: Update Canaan Kendryte K210 defconfig Damien Le Moal
2021-02-05 6:58 ` [PATCH v16 16/16] riscv: Add Canaan Kendryte K210 SD card defconfig Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aab05bea310fbdbac38990656647dd0fbf3c8323.camel@wdc.com \
--to=damien.lemoal@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=robh@kernel.org \
--cc=seanga2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).