From: Paul Walmsley <paul.walmsley@sifive.com>
To: Alistair Francis <Alistair.Francis@wdc.com>
Cc: "linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"Palmpalmer@sifive.com" <palmer@sifive.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] RISC-V: defconfig: Enable Generic PCIE by default
Date: Thu, 10 Jan 2019 22:06:59 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1901102153570.22105@viisi.sifive.com> (raw)
In-Reply-To: <20190110193451.29016-1-alistair.francis@wdc.com>
Hi Alistair,
Looks like you're still sending patches to "palmpalmer" ?
On Thu, 10 Jan 2019, Alistair Francis wrote:
> Enable generic PCIe by default in the RISC-V defconfig, this allows us
> to use QEMU's PCIe support out of the box.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> arch/riscv/configs/defconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> index f399659d3b8d..ccfd3f05223c 100644
> --- a/arch/riscv/configs/defconfig
> +++ b/arch/riscv/configs/defconfig
> @@ -14,6 +14,8 @@ CONFIG_EXPERT=y
> CONFIG_BPF_SYSCALL=y
> CONFIG_SMP=y
> CONFIG_PCI=y
> +CONFIG_PCIEPORTBUS=y
> +CONFIG_PCI_HOST_GENERIC=y
> CONFIG_PCIE_XILINX=y
> CONFIG_MODULES=y
> CONFIG_MODULE_UNLOAD=y
> @@ -77,5 +79,6 @@ CONFIG_NFS_V4_1=y
> CONFIG_NFS_V4_2=y
> CONFIG_ROOT_NFS=y
> CONFIG_CRYPTO_USER_API_HASH=y
> +CONFIG_CRYPTO_DEV_VIRTIO=y
> CONFIG_PRINTK_TIME=y
> # CONFIG_RCU_TRACE is not set
Not sure what commit this patch is against - I picked v5.0-rc1. Before
applying your patch, I generated a seedconfig with "make defconfig
savedefconfig; mv defconfig defconfig.1". Then applied your patch and did
a "make defconfig savedefconfig" and then ran "diff -u defconfig.1
defconfig".
That should have shown me just the patch above. But it also included a
line removing CONFIG_RAS=y. I am sorry to ask you to fix such a nitpicky
item, but it is good practice for these defconfig patches. Otherwise the
defconfig deltas gradually get out of control.
When you repost it, if you verify that the ./defconfig delta from running
"make savedefconfig" before and after your patch applied is simply your
patch, then feel free to add a Reviewed-by: line from my E-mail address
above.
- Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-01-11 6:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 19:35 [PATCH v2] RISC-V: defconfig: Enable Generic PCIE by default Alistair Francis
2019-01-11 6:06 ` Paul Walmsley [this message]
2019-01-11 17:10 ` Palmer Dabbelt
-- strict thread matches above, loose matches on Subject: below --
2018-12-21 22:06 Alistair Francis
2018-12-22 0:25 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1901102153570.22105@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=Alistair.Francis@wdc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).