From: Paul Walmsley <paul.walmsley@sifive.com>
To: Andreas Schwab <schwab@suse.de>
Cc: paul@pwsan.com, aou@eecs.berkeley.edu, palmer@sifive.com,
linux-kernel@vger.kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] arch: riscv: support kernel command line forcing when no DTB passed
Date: Tue, 19 Feb 2019 13:19:32 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1902191318520.6518@viisi.sifive.com> (raw)
In-Reply-To: <mvm36p22ksx.fsf@suse.de>
On Tue, 5 Feb 2019, Andreas Schwab wrote:
> On Dez 17 2018, Paul Walmsley <paul.walmsley@sifive.com> wrote:
>
> > diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
> > index 2c290e6aaa6e..e6b962ff39b1 100644
> > --- a/arch/riscv/kernel/setup.c
> > +++ b/arch/riscv/kernel/setup.c
> > @@ -171,7 +171,14 @@ asmlinkage void __init setup_vm(void)
> >
> > void __init parse_dtb(unsigned int hartid, void *dtb)
> > {
> > - early_init_dt_scan(__va(dtb));
> > + if (!early_init_dt_scan(__va(dtb)))
> > + return;
> > +
> > + pr_err("No DTB passed to the kernel\n");
>
> Isn't that backwards? early_init_dt_scan returns true if it found a
> DTB.
Yes, it's backwards. Thanks for the catch. Looks like I sent an older
version of the patch.
- Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-02-19 21:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 3:15 [PATCH] arch: riscv: support kernel command line forcing when no DTB passed Paul Walmsley
2019-01-15 15:44 ` Christoph Hellwig
2019-02-05 17:43 ` Andreas Schwab
2019-02-19 21:19 ` Paul Walmsley [this message]
2019-02-07 14:44 ` [PATCH] arch: riscv: fix logic error in parse_dtb Andreas Schwab
2019-02-07 22:47 ` Atish Patra
2019-02-19 21:20 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1902191318520.6518@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul@pwsan.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).