linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Paul Walmsley <paul.walmsley@sifive.com>
To: Alan Mikhak <alan.mikhak@sifive.com>
Cc: lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org,
	palmer@sifive.com, linux-kernel@vger.kernel.org, kishon@ti.com,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH 2/2] tools: PCI: Fix compiler warning in pcitest
Date: Thu, 23 May 2019 13:30:37 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.9999.1905231330010.31734@viisi.sifive.com> (raw)
In-Reply-To: <1558642464-9946-3-git-send-email-alan.mikhak@sifive.com>

On Thu, 23 May 2019, Alan Mikhak wrote:

> From: Alan Mikhak <alan.mikhak@sifive.com>
> 
> Fixes: fbca0b284bd0 ("tools: PCI: Add 'h' in optstring of getopt()")

Same comments here as on the other patch - please drop the From: line 
(since it's in the message header) and move the Fixes: line down with the 
Signed-off-by:.


- Paul

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

      reply	other threads:[~2019-05-23 20:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 20:14 [PATCH 0/2] tools: PCI: Fix broken pcitest compilation Alan Mikhak
2019-05-23 20:14 ` [PATCH 1/2] " Alan Mikhak
2019-05-23 20:29   ` Paul Walmsley
2019-05-23 20:14 ` [PATCH 2/2] tools: PCI: Fix compiler warning in pcitest Alan Mikhak
2019-05-23 20:30   ` Paul Walmsley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.9999.1905231330010.31734@viisi.sifive.com \
    --to=paul.walmsley@sifive.com \
    --cc=alan.mikhak@sifive.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=palmer@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).