From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCDA1C43218 for ; Tue, 11 Jun 2019 14:29:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0C0F206BB for ; Tue, 11 Jun 2019 14:29:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Xnapp4nw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="XIxL3van" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0C0F206BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GE+L8K+fdQtcl13rbAdR8cD8s3ctmgga89K5eeUNQaI=; b=Xnapp4nwjmmf3g 8kyMNPaCs/TKTRdF5MZ3bPTMKy5RBUYmeOjBDiIadPqK/XF4wS8+4/EkjhtP058OY1i08H0wG7Cpj H1nf1HGwjgu8lg4aDIaa8vNBN8A0Pc7ON0YpG3Cl2IoPUTengq4Pecfmxi5rH7S9+wZTqN9jNXFmU nYc20paOjC3kmYue3wVXCFjElv/n0D8LOMcEABX80h+hMAsz6VK5MPIXeYXzQLLAx14GE3HD6nSUI hZRkfVQvvgMfPd/ObfIUBS/cBDgnaDY7ox6I+A8FgifjjNd97EhTwHYhwV921yik0ZoQprWsupG32 bWCl2H3SDQYWaIHa6ahg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hahm1-00059t-Fg; Tue, 11 Jun 2019 14:29:17 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hahlx-00058b-Na for linux-riscv@lists.infradead.org; Tue, 11 Jun 2019 14:29:15 +0000 Received: by mail-ed1-x544.google.com with SMTP id p26so16378455edr.2 for ; Tue, 11 Jun 2019 07:29:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=EcfTiCsffQkaI+Cy4Vw69CL5IwRZfczcRgXiPSVSIEU=; b=XIxL3vanV/BoGlCosN7UlsPccmg8Ri4Z8jWnddxaVhRqyTSA97xSsXt4jxSXSMip0O HpFjrqn/vPjrVZMT+GeJYFnV9HKUuOHcxOOmIXtwvxxVEptP5nNbKMHcw25Zwbpt5xDk O298v3Df7onxgjfwyNZNwkBvKJi1f4y7FYoa0hEYG65ZtOyDeMsOfaKSZO+JsanpC834 S2zaSeOhqvsaAfk0Jujd0TFA+Xl9+PKsQ7dWYUFQtH6acylZeup5URZAeMT6WhYZ3HwX kiZI3rRCQsNnIm8DqX7+/EL9zhGJPvTFhsGeDF07K2fy8wWla6yffNDEYa6lSQQxTU92 5DWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=EcfTiCsffQkaI+Cy4Vw69CL5IwRZfczcRgXiPSVSIEU=; b=beB/G6XDKIGfnIEkmuLjCEAAiD00ie5cPE1dBKFQZFgDTM10zYBiOeHx03Pb1cZDcl xWraavOv8tvfo63lT83wBed357SeRTXAEZxTn+dHc8RT86QGjnmg1wa07+MjxWR/aGoe XPffe6XAOSsOPN7eI3/HUhj47xvcVPzAM4w/iaBR/oD9NcvMznqlVX9HP2QOxFwjJX09 rUyEyf7i+bVOFqj2Yy6AProq+LYlXiTbRqQDICPLb/SIvIsgFgLj0eBXQEgfNYjGbyKS idJuEPuGbqwXZZON9yIsPaZ9rdMJ1mW186VXgLGEQ5bDzFaYv4bOTDcJb/2QWXGh80JK cbjA== X-Gm-Message-State: APjAAAUV+9ahgzmYuYJpckBs9XRvqq9cT+fxOGW1jHX8/JBZiHfK66gc 4+QLsho3lVrf4vdV/3hGPXqq7g== X-Google-Smtp-Source: APXvYqxbHgB3hqxZayzzwYf//1JUbrAUHjHKk5IFJ5cxpjXezsvGZFi9XeOdup4uWumqb5EpI3IoQA== X-Received: by 2002:a17:906:e203:: with SMTP id gf3mr45163746ejb.210.1560263352423; Tue, 11 Jun 2019 07:29:12 -0700 (PDT) Received: from localhost (mpp-cp1-natpool-1-037.ethz.ch. [82.130.71.37]) by smtp.gmail.com with ESMTPSA id s11sm1250132ejo.51.2019.06.11.07.29.11 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 11 Jun 2019 07:29:11 -0700 (PDT) Date: Tue, 11 Jun 2019 07:29:10 -0700 (PDT) From: Paul Walmsley X-X-Sender: paulw@viisi.sifive.com To: Nick Hu Subject: Re: [PATCH v3] riscv: Fix udelay in RV32. In-Reply-To: <67bfbb11e64273427b125528a4e2bc83b5efe70b.1559199430.git.nickhu@andestech.com> Message-ID: References: <67bfbb11e64273427b125528a4e2bc83b5efe70b.1559199430.git.nickhu@andestech.com> User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190611_072914_042976_AC991BF6 X-CRM114-Status: UNSURE ( 6.26 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: greentime@andestech.com, palmer@sifive.com, linux-kernel@vger.kernel.org, hch@infradead.org, green.hu@gmail.com, albert@sifive.com, linux-riscv@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, 30 May 2019, Nick Hu wrote: > In RV32, udelay would delay the wrong cycle. When it shifts right > "UDELAY_SHITFT" bits, it either delays 0 cycle or 1 cycle. It only works > correctly in RV64. Because the 'ucycles' always needs to be 64 bits > variable. > > Signed-off-by: Nick Hu > Reviewed-by: Palmer Dabbelt Thanks, queued for v5.2-rc. - Paul _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv