From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2D32C5B578 for ; Wed, 3 Jul 2019 22:57:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6E6F218A4 for ; Wed, 3 Jul 2019 22:57:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ajLg4SmF"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="mlmuaMzW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6E6F218A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=whM8p0qrHX2BHMeSDAjBIzhH5nzyGgWk71hqff13Tkg=; b=ajLg4SmF62eLt+ rqduEG1oFbwNkX+ykGqLc4lqbI2wB6EMFP6CdRUfMi6FUajY0BhAsvAzW5jQETDuRmo3YSJ2r4WtQ PE4q0ymYBckNfmAJKrWTwMEZ69Pgx5li4z8MVuCjmOEKUtsQVFMGygYIixPLKWNEn0zPg5E6RYukK w0vn6MWttvGWe6ZMuL/zC2SjartNaLT1TsPSetD0RFJ9tAATVST6Gqc8BKw0WdMNj4Hy+tFSPViHQ 2JD3/mNjqm/KstTcm44ij07vl8zBW/5kiAF2t7wdlVAGz7X9Mi/sGZ+HBHqA2B4Iy+xPzb8e+Z1mh 9H1REOFsF5VmCxnIwF0w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hioCC-0005OZ-Eq; Wed, 03 Jul 2019 22:57:48 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hioBu-0005Ck-Fe for linux-riscv@lists.infradead.org; Wed, 03 Jul 2019 22:57:32 +0000 Received: by mail-io1-xd43.google.com with SMTP id u13so4468243iop.0 for ; Wed, 03 Jul 2019 15:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=uJUFOB1+pEjI3tqctrrTDNSdgarQtW2/vrE2Xz2pZ+I=; b=mlmuaMzWXwGNHTh1m9kPgfFo2Tw4pDtMkFdH4Q8+iwU6WOvBBv+g+2gbbLw3KWFaqb 7FLAJSeHJgfzvHDK607Tlpd1IPoKX4mLRsWOcFka5tUNQoVMczZpTuh4/w9bFwzUXmPy UuCtSXoCq+HxS1tFFUH0y6rS8oD7aTWevTQPPr6ajTGvc9FGNDQrr3XF7LflhJeAMWGe SAmyBrF5/20cB6m7c25cdcrCzB28DIl9S1l7bCcUpCLgUd8bNVkX+R1x2h/BvXuYjhMZ YAUMvPh7JwSlOBjQVaVRhrOUuJHYb9xQ1QCSO3s9QqsWqosKNro4zaqPQrztFo4bJFQk bflw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=uJUFOB1+pEjI3tqctrrTDNSdgarQtW2/vrE2Xz2pZ+I=; b=oOPgwhtWsvyHShFQfXNBgfSrih+bVtOIpDH6Phpati7IIQ+vwNbPsQEXkqtfVrOuOj nkPksapyTPGhPq60aG80AIFyjW78mK1KVc0VV+jYyiL9HNq3IuNuvmJs6+uQiAO/QIim CEJTRX2bDQl6B/aLtIbWgIywG4A4xdxF2COqdbKF0jXvshJeWD2TfOElgRKkvhOXFX7n R1OplVkh6+UQbWbPa7oW7IuJKv+hxjZMhPPaWOi54p8zZKz8AY5YRTrL8I55eoV/MKUT 2Cr9FkftfkNq8m+nJCImKx5CA+Bcs7WynRUlVvMB0YR0fgKF5rhMIyuDczEq48bLgkjP Aa5A== X-Gm-Message-State: APjAAAV+fQ94+v7EtxTBzNOl5osvfLyUABXsH64J5Tq70/aDylDaDGUR 1z7HORgL0LPY7eCFZSDAsqfF8w== X-Google-Smtp-Source: APXvYqyCZRuDgBNhLr4vL06qazVYpkUtLUhcx0drufzzinnuyuFvTR6JEyWtD29EbtSghjg4j3uMvQ== X-Received: by 2002:a5e:9747:: with SMTP id h7mr1968603ioq.299.1562194647999; Wed, 03 Jul 2019 15:57:27 -0700 (PDT) Received: from localhost (c-73-95-159-87.hsd1.co.comcast.net. [73.95.159.87]) by smtp.gmail.com with ESMTPSA id a7sm3741904iok.19.2019.07.03.15.57.27 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 03 Jul 2019 15:57:27 -0700 (PDT) Date: Wed, 3 Jul 2019 15:57:26 -0700 (PDT) From: Paul Walmsley X-X-Sender: paulw@viisi.sifive.com To: Alexandre Ghiti Subject: Re: [PATCH v3 0/2] Hugetlbfs support for riscv In-Reply-To: <20190701175900.4034-1-alex@ghiti.fr> Message-ID: References: <20190701175900.4034-1-alex@ghiti.fr> User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190703_155730_525670_BD05E592 X-CRM114-Status: GOOD ( 16.36 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Albert Ou , "H . Peter Anvin" , Catalin Marinas , Palmer Dabbelt , Will Deacon , x86@kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Ingo Molnar , Borislav Petkov , Hanjun Guo , Thomas Gleixner , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Mike Kravetz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org Hi Alex, Thanks for writing and testing these patches, and thanks for your patience waiting for reviews and testing. On Mon, 1 Jul 2019, Alexandre Ghiti wrote: > This series introduces hugetlbfs support for both riscv 32/64. Riscv32 > is architecturally limited to huge pages of size 4MB whereas riscv64 has > 2MB/1G huge pages support. Transparent huge page support is not > implemented here, I will submit another series later. > [ ... ] > This series was validated using libhugetlbfs testsuite ported to riscv64 > without linker script support. > (https://github.com/AlexGhiti/libhugetlbfs.git, branch dev/alex/riscv). > > - libhugetlbfs testsuite on riscv64/2M: > - brk_near_huge triggers an assert in malloc.c, does not on x86. I was able to reproduce the 2MB megapages test results on rv64 QEMU. On a HiFive Unleashed, though, a few more tests fail: - icache_hygiene fails ("icache unclean") # LD_LIBRARY_PATH=obj64 ./tests/obj64/icache-hygiene Starting testcase "./tests/obj64/icache-hygiene", pid 732 SIGILL at 0x15559fff80 (sig_expected=0x15559fff80) SIGILL at 0x1555dfff80 (sig_expected=0x1555dfff80) SIGILL at 0x15561fff80 (sig_expected=0x15561fff80) SIGILL at 0x15565fff80 (sig_expected=0x15565fff80) SIGILL at 0x15569fff80 (sig_expected=0x15569fff80) SIGILL at 0x1556dfff80 (sig_expected=(nil)) FAIL SIGILL somewhere unexpected # - One of the heapshrink tests fails ("Heap did not shrink") # LD_PRELOAD="obj64/libhugetlbfs_privutils.so obj64/libhugetlbfs.so tests/obj64/libheapshrink.so" HUGETLB_MORECORE_SHRINK=yes HUGETLB_MORECORE=yes tests/obj64/heapshrink Starting testcase "tests/obj64/heapshrink", pid 753 FAIL Heap did not shrink # Some of these may be related to the top-down mmap work, but there might be more work to do on actual hardware. > - libhugetlbfs testsuite on riscv64/1G: > - brk_near_huge triggers an assert in malloc.c, does not on x86. > - mmap-gettest, mmap-cow: testsuite passes the number of default free > pages as parameters and then fails for 1G which is not the default. > Otherwise succeeds when given the right number of pages. > - map_high_truncate_2 fails on x86 too: 0x60000000 is not 1G aligned > and fails at line 694 of fs/hugetlbfs/inode.c. > - heapshrink on 1G fails on x86 too, not investigated. > - counters.sh on 1G fails on x86 too: alloc_surplus_huge_page returns > NULL in case of gigantic pages. > - icache-hygiene succeeds after patch #3 of this series which lowers > the base address of mmap. > - fallocate_stress.sh on 1G never ends, on x86 too, not investigated. I can reproduce some of these here on QEMU. But for reasons that are unclear to me, 1G gigapages aren't working on the HiFive Unleashed here. In any case, these patches are clearly a good start, so I've queued them for v5.3. - Paul _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv