From: Paul Walmsley <paul.walmsley@sifive.com>
To: Palmer Dabbelt <palmer@sifive.com>, Nicolas Pitre <nico@fluxnic.net>
Cc: linux-riscv@lists.infradead.org, Alan Kao <alankao@andestech.com>
Subject: Re: [PATCH] RISC-V: Remove udivdi3
Date: Tue, 6 Aug 2019 19:09:05 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1908061907340.25231@viisi.sifive.com> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1908061738130.13971@viisi.sifive.com>
On Tue, 6 Aug 2019, Paul Walmsley wrote:
> On Wed, 7 Aug 2019, Alan Kao wrote:
>
> > On Tue, Aug 06, 2019 at 05:05:08PM -0700, Palmer Dabbelt wrote:
> > > This should never have landed in the first place: it was added as part
> > > of 64-bit divide support for 32-bit systems, but the kernel doesn't
> > > allow this sort of division. I must have forgotten to remove it.
> > >
> > > This patch removes the support. Since this routine only worked on
> > > 64-bit platforms but was only built on 32-bit platforms, it's
> > > essentially just nonsense anyway.
> > >
> >
> > It would be more complete if we add
> > "Reported-by: Eric Lin <tesheng@andestech.com>" here.
> >
> > > Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
> > > Acked-by: Nicolas Pitre <nico@fluxnic.net>
>
> Thanks, queued for v5.3-rc with Eric's Reported-by.
This patch breaks the rv32_defconfig build, since udelay() still relies on
__udivdi3(). I'll queue "riscv: delay: use do_div() instead of
__udivdi3()" along with it:
https://lore.kernel.org/linux-riscv/alpine.DEB.2.21.9999.1908061906240.25231@viisi.sifive.com/T/#u
- Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-08-07 2:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 0:05 [PATCH] RISC-V: Remove udivdi3 Palmer Dabbelt
2019-08-07 0:18 ` Alan Kao
2019-08-07 0:38 ` Paul Walmsley
2019-08-07 2:09 ` Paul Walmsley [this message]
2019-08-07 2:33 ` Nicolas Pitre
2019-08-07 2:40 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1908061907340.25231@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=alankao@andestech.com \
--cc=linux-riscv@lists.infradead.org \
--cc=nico@fluxnic.net \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).