From: Paul Walmsley <paul.walmsley@sifive.com>
To: Christoph Hellwig <hch@lst.de>
Cc: arnd@arndb.de, Greg KH <gregkh@linuxfoundation.org>,
palmer@sifive.com, linux-kernel@vger.kernel.org,
james.morse@arm.com, linux-riscv@lists.infradead.org,
mchehab@kernel.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/misc
Date: Wed, 7 Aug 2019 08:40:58 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1908070832500.13971@viisi.sifive.com> (raw)
In-Reply-To: <20190807152438.GA16495@lst.de>
On Wed, 7 Aug 2019, Christoph Hellwig wrote:
> On Wed, Aug 07, 2019 at 05:22:15PM +0200, Greg KH wrote:
> > > Fixes: a967a289f169 ("RISC-V: sifive_l2_cache: Add L2 cache controller driver for SiFive SoCs")
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > > ---
> > > arch/riscv/mm/Makefile | 1 -
> > > drivers/misc/Makefile | 1 +
> > > {arch/riscv/mm => drivers/misc}/sifive_l2_cache.c | 0
> > > 3 files changed, 1 insertion(+), 1 deletion(-)
> > > rename {arch/riscv/mm => drivers/misc}/sifive_l2_cache.c (100%)
> >
> > Why isn't this in drivers/edac/ ?
> > why is this a misc driver? Seems like it should sit next to the edac
> > stuff.
>
> No idea. EDAC maintainers, would you object to taking what is
> currently in arch/riscv/mm//sifive_l2_cache.c to drivers/edac/ ?
If this driver is moved out of arch/riscv/mm, it should ideally go into
some sort of common L2 cache controller driver directory, along
with other L2 cache controller drivers like arch/arm/mm/*l2c*.
Like many L2 cache controllers, this controller also supports cache
flushing operations and SoC-specific way operations. We just don't use
those on RISC-V - yet.
- Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-08-07 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 15:10 [PATCH] riscv: move sifive_l2_cache.c to drivers/misc Christoph Hellwig
2019-08-07 15:22 ` Greg KH
2019-08-07 15:24 ` Christoph Hellwig
2019-08-07 15:40 ` Paul Walmsley [this message]
2019-08-08 7:50 ` Christoph Hellwig
2019-08-08 8:07 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1908070832500.13971@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).