Linux-RISC-V Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding
@ 2019-07-19 11:10 Yash Shah
  2019-07-19 11:10 ` [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000 Yash Shah
                   ` (4 more replies)
  0 siblings, 5 replies; 19+ messages in thread
From: Yash Shah @ 2019-07-19 11:10 UTC (permalink / raw)
  To: davem, robh+dt, paul.walmsley, netdev, devicetree, linux-kernel,
	linux-riscv
  Cc: mark.rutland, aou, palmer, nicolas.ferre, sachin.ghadi, Yash Shah, ynezz

As per the discussion with Nicolas Ferre, rename the compatible property
to a more appropriate and specific string.
LINK: https://lkml.org/lkml/2019/7/17/200

Signed-off-by: Yash Shah <yash.shah@sifive.com>
---
 Documentation/devicetree/bindings/net/macb.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
index 63c73fa..0b61a90 100644
--- a/Documentation/devicetree/bindings/net/macb.txt
+++ b/Documentation/devicetree/bindings/net/macb.txt
@@ -15,10 +15,10 @@ Required properties:
   Use "atmel,sama5d4-gem" for the GEM IP (10/100) available on Atmel sama5d4 SoCs.
   Use "cdns,zynq-gem" Xilinx Zynq-7xxx SoC.
   Use "cdns,zynqmp-gem" for Zynq Ultrascale+ MPSoC.
-  Use "sifive,fu540-macb" for SiFive FU540-C000 SoC.
+  Use "sifive,fu540-c000-gem" for SiFive FU540-C000 SoC.
   Or the generic form: "cdns,emac".
 - reg: Address and length of the register set for the device
-	For "sifive,fu540-macb", second range is required to specify the
+	For "sifive,fu540-c000-gem", second range is required to specify the
 	address and length of the registers for GEMGXL Management block.
 - interrupts: Should contain macb interrupt
 - phy-mode: See ethernet.txt file in the same directory.
-- 
1.9.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000
  2019-07-19 11:10 [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding Yash Shah
@ 2019-07-19 11:10 ` Yash Shah
  2019-07-19 12:05   ` Nicolas.Ferre
                     ` (2 more replies)
  2019-07-19 11:10 ` [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver Yash Shah
                   ` (3 subsequent siblings)
  4 siblings, 3 replies; 19+ messages in thread
From: Yash Shah @ 2019-07-19 11:10 UTC (permalink / raw)
  To: davem, robh+dt, paul.walmsley, netdev, devicetree, linux-kernel,
	linux-riscv
  Cc: mark.rutland, aou, palmer, nicolas.ferre, sachin.ghadi, Yash Shah, ynezz

Update the compatibility string for SiFive FU540-C000 as per the new
string updated in the binding doc.
Reference: https://lkml.org/lkml/2019/7/17/200

Signed-off-by: Yash Shah <yash.shah@sifive.com>
---
 drivers/net/ethernet/cadence/macb_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 15d0737..305371c 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4112,7 +4112,7 @@ static int fu540_c000_init(struct platform_device *pdev)
 	{ .compatible = "cdns,emac", .data = &emac_config },
 	{ .compatible = "cdns,zynqmp-gem", .data = &zynqmp_config},
 	{ .compatible = "cdns,zynq-gem", .data = &zynq_config },
-	{ .compatible = "sifive,fu540-macb", .data = &fu540_c000_config },
+	{ .compatible = "sifive,fu540-c000-gem", .data = &fu540_c000_config },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, macb_dt_ids);
-- 
1.9.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver
  2019-07-19 11:10 [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding Yash Shah
  2019-07-19 11:10 ` [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000 Yash Shah
@ 2019-07-19 11:10 ` Yash Shah
  2019-07-19 11:53   ` Sagar Kadam
  2019-07-22 21:48   ` Paul Walmsley
  2019-07-19 12:02 ` [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding Nicolas.Ferre
                   ` (2 subsequent siblings)
  4 siblings, 2 replies; 19+ messages in thread
From: Yash Shah @ 2019-07-19 11:10 UTC (permalink / raw)
  To: davem, robh+dt, paul.walmsley, netdev, devicetree, linux-kernel,
	linux-riscv
  Cc: mark.rutland, aou, palmer, nicolas.ferre, sachin.ghadi, Yash Shah, ynezz

DT node for SiFive FU540-C000 GEMGXL Ethernet controller driver added

Signed-off-by: Yash Shah <yash.shah@sifive.com>
---
 arch/riscv/boot/dts/sifive/fu540-c000.dtsi          | 15 +++++++++++++++
 arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts |  9 +++++++++
 2 files changed, 24 insertions(+)

diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
index cc73522..588669f0 100644
--- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
+++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
@@ -231,5 +231,20 @@
 			#size-cells = <0>;
 			status = "disabled";
 		};
+		eth0: ethernet@10090000 {
+			compatible = "sifive,fu540-c000-gem";
+			interrupt-parent = <&plic0>;
+			interrupts = <53>;
+			reg = <0x0 0x10090000 0x0 0x2000
+			       0x0 0x100a0000 0x0 0x1000>;
+			local-mac-address = [00 00 00 00 00 00];
+			clock-names = "pclk", "hclk";
+			clocks = <&prci PRCI_CLK_GEMGXLPLL>,
+				 <&prci PRCI_CLK_GEMGXLPLL>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
 	};
 };
diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
index 0b55c53..85c17a7 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
@@ -76,3 +76,12 @@
 		disable-wp;
 	};
 };
+
+&eth0 {
+	status = "okay";
+	phy-mode = "gmii";
+	phy-handle = <&phy1>;
+	phy1: ethernet-phy@0 {
+		reg = <0>;
+	};
+};
-- 
1.9.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver
  2019-07-19 11:10 ` [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver Yash Shah
@ 2019-07-19 11:53   ` Sagar Kadam
  2019-07-19 13:26     ` Andrew Lunn
  2019-07-22 21:48   ` Paul Walmsley
  1 sibling, 1 reply; 19+ messages in thread
From: Sagar Kadam @ 2019-07-19 11:53 UTC (permalink / raw)
  To: Yash Shah
  Cc: Mark Rutland, devicetree, Albert Ou, netdev, Palmer Dabbelt,
	ynezz, Linux Kernel Mailing List, nicolas.ferre, Sachin Ghadi,
	Rob Herring, Paul Walmsley, linux-riscv, davem

The series looks good to me.

Reviewed-by: Sagar Kadam <sagar.kadam@sifive.com>

On Fri, Jul 19, 2019 at 4:41 PM Yash Shah <yash.shah@sifive.com> wrote:
>
> DT node for SiFive FU540-C000 GEMGXL Ethernet controller driver added
>
> Signed-off-by: Yash Shah <yash.shah@sifive.com>
> ---
>  arch/riscv/boot/dts/sifive/fu540-c000.dtsi          | 15 +++++++++++++++
>  arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts |  9 +++++++++
>  2 files changed, 24 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
> index cc73522..588669f0 100644
> --- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
> +++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
> @@ -231,5 +231,20 @@
>                         #size-cells = <0>;
>                         status = "disabled";
>                 };
> +               eth0: ethernet@10090000 {
> +                       compatible = "sifive,fu540-c000-gem";
> +                       interrupt-parent = <&plic0>;
> +                       interrupts = <53>;
> +                       reg = <0x0 0x10090000 0x0 0x2000
> +                              0x0 0x100a0000 0x0 0x1000>;
> +                       local-mac-address = [00 00 00 00 00 00];
> +                       clock-names = "pclk", "hclk";
> +                       clocks = <&prci PRCI_CLK_GEMGXLPLL>,
> +                                <&prci PRCI_CLK_GEMGXLPLL>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       status = "disabled";
> +               };
> +
>         };
>  };
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> index 0b55c53..85c17a7 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> @@ -76,3 +76,12 @@
>                 disable-wp;
>         };
>  };
> +
> +&eth0 {
> +       status = "okay";
> +       phy-mode = "gmii";
> +       phy-handle = <&phy1>;
> +       phy1: ethernet-phy@0 {
> +               reg = <0>;
> +       };
> +};
> --
> 1.9.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding
  2019-07-19 11:10 [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding Yash Shah
  2019-07-19 11:10 ` [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000 Yash Shah
  2019-07-19 11:10 ` [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver Yash Shah
@ 2019-07-19 12:02 ` Nicolas.Ferre
  2019-07-22 19:59 ` Paul Walmsley
  2019-08-12 23:32 ` Rob Herring
  4 siblings, 0 replies; 19+ messages in thread
From: Nicolas.Ferre @ 2019-07-19 12:02 UTC (permalink / raw)
  To: yash.shah, davem, robh+dt, paul.walmsley, netdev, devicetree,
	linux-kernel, linux-riscv
  Cc: mark.rutland, sachin.ghadi, ynezz, palmer, aou

On 19/07/2019 at 13:10, Yash Shah wrote:
> As per the discussion with Nicolas Ferre, rename the compatible property
> to a more appropriate and specific string.
> LINK: https://lkml.org/lkml/2019/7/17/200
> 
> Signed-off-by: Yash Shah <yash.shah@sifive.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>   Documentation/devicetree/bindings/net/macb.txt | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
> index 63c73fa..0b61a90 100644
> --- a/Documentation/devicetree/bindings/net/macb.txt
> +++ b/Documentation/devicetree/bindings/net/macb.txt
> @@ -15,10 +15,10 @@ Required properties:
>     Use "atmel,sama5d4-gem" for the GEM IP (10/100) available on Atmel sama5d4 SoCs.
>     Use "cdns,zynq-gem" Xilinx Zynq-7xxx SoC.
>     Use "cdns,zynqmp-gem" for Zynq Ultrascale+ MPSoC.
> -  Use "sifive,fu540-macb" for SiFive FU540-C000 SoC.
> +  Use "sifive,fu540-c000-gem" for SiFive FU540-C000 SoC.
>     Or the generic form: "cdns,emac".
>   - reg: Address and length of the register set for the device
> -	For "sifive,fu540-macb", second range is required to specify the
> +	For "sifive,fu540-c000-gem", second range is required to specify the
>   	address and length of the registers for GEMGXL Management block.
>   - interrupts: Should contain macb interrupt
>   - phy-mode: See ethernet.txt file in the same directory.
> 


-- 
Nicolas Ferre

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000
  2019-07-19 11:10 ` [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000 Yash Shah
@ 2019-07-19 12:05   ` Nicolas.Ferre
  2019-07-22  4:39     ` Yash Shah
  2019-07-22 20:02   ` Paul Walmsley
  2019-07-22 21:46   ` Paul Walmsley
  2 siblings, 1 reply; 19+ messages in thread
From: Nicolas.Ferre @ 2019-07-19 12:05 UTC (permalink / raw)
  To: yash.shah, davem, robh+dt, paul.walmsley, netdev, devicetree,
	linux-kernel, linux-riscv
  Cc: mark.rutland, sachin.ghadi, ynezz, palmer, aou

On 19/07/2019 at 13:10, Yash Shah wrote:
> Update the compatibility string for SiFive FU540-C000 as per the new
> string updated in the binding doc.
> Reference: https://lkml.org/lkml/2019/7/17/200

Maybe referring to lore.kernel.org is better:
https://lore.kernel.org/netdev/CAJ2_jOFEVZQat0Yprg4hem4jRrqkB72FKSeQj4p8P5KA-+rgww@mail.gmail.com/

> Signed-off-by: Yash Shah <yash.shah@sifive.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Thanks, best regards,
   Nicolas

> ---
>   drivers/net/ethernet/cadence/macb_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 15d0737..305371c 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -4112,7 +4112,7 @@ static int fu540_c000_init(struct platform_device *pdev)
>   	{ .compatible = "cdns,emac", .data = &emac_config },
>   	{ .compatible = "cdns,zynqmp-gem", .data = &zynqmp_config},
>   	{ .compatible = "cdns,zynq-gem", .data = &zynq_config },
> -	{ .compatible = "sifive,fu540-macb", .data = &fu540_c000_config },
> +	{ .compatible = "sifive,fu540-c000-gem", .data = &fu540_c000_config },
>   	{ /* sentinel */ }
>   };
>   MODULE_DEVICE_TABLE(of, macb_dt_ids);
> 


-- 
Nicolas Ferre

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver
  2019-07-19 11:53   ` Sagar Kadam
@ 2019-07-19 13:26     ` Andrew Lunn
  2019-07-22  8:27       ` Sagar Kadam
  0 siblings, 1 reply; 19+ messages in thread
From: Andrew Lunn @ 2019-07-19 13:26 UTC (permalink / raw)
  To: Sagar Kadam
  Cc: Mark Rutland, devicetree, Albert Ou, netdev, Palmer Dabbelt,
	ynezz, Linux Kernel Mailing List, nicolas.ferre, Sachin Ghadi,
	Yash Shah, Rob Herring, Paul Walmsley, linux-riscv, davem

On Fri, Jul 19, 2019 at 05:23:45PM +0530, Sagar Kadam wrote:
> > +&eth0 {
> > +       status = "okay";
> > +       phy-mode = "gmii";
> > +       phy-handle = <&phy1>;
> > +       phy1: ethernet-phy@0 {
> > +               reg = <0>;
> > +       };

Hi Sagar

Is there a good reason to call it phy1? Is there a phy0?

Thanks

   Andrew

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000
  2019-07-19 12:05   ` Nicolas.Ferre
@ 2019-07-22  4:39     ` Yash Shah
  2019-08-13 18:42       ` Paul Walmsley
  0 siblings, 1 reply; 19+ messages in thread
From: Yash Shah @ 2019-07-22  4:39 UTC (permalink / raw)
  To: Nicolas Ferre
  Cc: Mark Rutland, devicetree, Albert Ou, netdev, Palmer Dabbelt,
	Petr Štetiar, linux-kernel@vger.kernel.org List,
	Sachin Ghadi, Rob Herring, Paul Walmsley, linux-riscv,
	David Miller

On Fri, Jul 19, 2019 at 5:36 PM <Nicolas.Ferre@microchip.com> wrote:
>
> On 19/07/2019 at 13:10, Yash Shah wrote:
> > Update the compatibility string for SiFive FU540-C000 as per the new
> > string updated in the binding doc.
> > Reference: https://lkml.org/lkml/2019/7/17/200
>
> Maybe referring to lore.kernel.org is better:
> https://lore.kernel.org/netdev/CAJ2_jOFEVZQat0Yprg4hem4jRrqkB72FKSeQj4p8P5KA-+rgww@mail.gmail.com/

Sure. Will keep that in mind for future reference.

>
> > Signed-off-by: Yash Shah <yash.shah@sifive.com>
>
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Thanks.

- Yash

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver
  2019-07-19 13:26     ` Andrew Lunn
@ 2019-07-22  8:27       ` Sagar Kadam
  0 siblings, 0 replies; 19+ messages in thread
From: Sagar Kadam @ 2019-07-22  8:27 UTC (permalink / raw)
  To: Andrew Lunn
  Cc: Mark Rutland, devicetree, Albert Ou, davem, netdev,
	Palmer Dabbelt, Linux Kernel Mailing List, nicolas.ferre,
	Sachin Ghadi, Yash Shah, Rob Herring, Paul Walmsley, ynezz,
	linux-riscv

Hello Andrew,

On Fri, Jul 19, 2019 at 6:57 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Fri, Jul 19, 2019 at 05:23:45PM +0530, Sagar Kadam wrote:
> > > +&eth0 {
> > > +       status = "okay";
> > > +       phy-mode = "gmii";
> > > +       phy-handle = <&phy1>;
> > > +       phy1: ethernet-phy@0 {
> > > +               reg = <0>;
> > > +       };
>
> Hi Sagar
>
> Is there a good reason to call it phy1? Is there a phy0?
>

Sorry for the delayed response.
There is a single phy, so yes phy0 is a better name.
Thank you for pointing this out.

Thanks & Regards,
Sagar Kadam




> Thanks
>
>    Andrew
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding
  2019-07-19 11:10 [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding Yash Shah
                   ` (2 preceding siblings ...)
  2019-07-19 12:02 ` [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding Nicolas.Ferre
@ 2019-07-22 19:59 ` Paul Walmsley
  2019-08-12 23:32 ` Rob Herring
  4 siblings, 0 replies; 19+ messages in thread
From: Paul Walmsley @ 2019-07-22 19:59 UTC (permalink / raw)
  To: Yash Shah
  Cc: mark.rutland, devicetree, aou, netdev, palmer, linux-kernel,
	nicolas.ferre, sachin.ghadi, robh+dt, ynezz, linux-riscv, davem

On Fri, 19 Jul 2019, Yash Shah wrote:

> As per the discussion with Nicolas Ferre, rename the compatible property
> to a more appropriate and specific string.
> LINK: https://lkml.org/lkml/2019/7/17/200
> 
> Signed-off-by: Yash Shah <yash.shah@sifive.com>

Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com>

- Paul

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000
  2019-07-19 11:10 ` [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000 Yash Shah
  2019-07-19 12:05   ` Nicolas.Ferre
@ 2019-07-22 20:02   ` Paul Walmsley
  2019-07-22 21:46   ` Paul Walmsley
  2 siblings, 0 replies; 19+ messages in thread
From: Paul Walmsley @ 2019-07-22 20:02 UTC (permalink / raw)
  To: Yash Shah
  Cc: mark.rutland, devicetree, aou, netdev, palmer, linux-kernel,
	nicolas.ferre, sachin.ghadi, robh+dt, ynezz, linux-riscv, davem

On Fri, 19 Jul 2019, Yash Shah wrote:

> Update the compatibility string for SiFive FU540-C000 as per the new
> string updated in the binding doc.
> Reference: https://lkml.org/lkml/2019/7/17/200
> 
> Signed-off-by: Yash Shah <yash.shah@sifive.com>

Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com>

- Paul

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000
  2019-07-19 11:10 ` [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000 Yash Shah
  2019-07-19 12:05   ` Nicolas.Ferre
  2019-07-22 20:02   ` Paul Walmsley
@ 2019-07-22 21:46   ` Paul Walmsley
  2 siblings, 0 replies; 19+ messages in thread
From: Paul Walmsley @ 2019-07-22 21:46 UTC (permalink / raw)
  To: Yash Shah
  Cc: mark.rutland, devicetree, aou, netdev, palmer, linux-kernel,
	nicolas.ferre, sachin.ghadi, robh+dt, ynezz, linux-riscv, davem

On Fri, 19 Jul 2019, Yash Shah wrote:

> Update the compatibility string for SiFive FU540-C000 as per the new
> string updated in the binding doc.
> Reference: https://lkml.org/lkml/2019/7/17/200
> 
> Signed-off-by: Yash Shah <yash.shah@sifive.com>

Tested-by: Paul Walmsley <paul.walmsley@sifive.com>


- Paul

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver
  2019-07-19 11:10 ` [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver Yash Shah
  2019-07-19 11:53   ` Sagar Kadam
@ 2019-07-22 21:48   ` Paul Walmsley
  2019-08-12 23:33     ` Rob Herring
  1 sibling, 1 reply; 19+ messages in thread
From: Paul Walmsley @ 2019-07-22 21:48 UTC (permalink / raw)
  To: Yash Shah, davem
  Cc: mark.rutland, devicetree, aou, andrew, netdev, palmer,
	linux-kernel, nicolas.ferre, sachin.ghadi, robh+dt, sagar.kadam,
	linux-riscv, ynezz

On Fri, 19 Jul 2019, Yash Shah wrote:

> DT node for SiFive FU540-C000 GEMGXL Ethernet controller driver added
> 
> Signed-off-by: Yash Shah <yash.shah@sifive.com>

Thanks, queuing this one for v5.3-rc with Andrew's suggested change to 
change phy1 to phy0.

Am assuming patches 1 and 2 will go in via -net.


- Paul

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding
  2019-07-19 11:10 [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding Yash Shah
                   ` (3 preceding siblings ...)
  2019-07-22 19:59 ` Paul Walmsley
@ 2019-08-12 23:32 ` Rob Herring
  2019-08-13 18:41   ` Paul Walmsley
  4 siblings, 1 reply; 19+ messages in thread
From: Rob Herring @ 2019-08-12 23:32 UTC (permalink / raw)
  To: Yash Shah
  Cc: mark.rutland, devicetree, aou, netdev, palmer, ynezz,
	linux-kernel, nicolas.ferre, sachin.ghadi, Yash Shah, robh+dt,
	paul.walmsley, linux-riscv, davem

On Fri, 19 Jul 2019 16:40:29 +0530, Yash Shah wrote:
> As per the discussion with Nicolas Ferre, rename the compatible property
> to a more appropriate and specific string.
> LINK: https://lkml.org/lkml/2019/7/17/200
> 
> Signed-off-by: Yash Shah <yash.shah@sifive.com>
> ---
>  Documentation/devicetree/bindings/net/macb.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver
  2019-07-22 21:48   ` Paul Walmsley
@ 2019-08-12 23:33     ` Rob Herring
  0 siblings, 0 replies; 19+ messages in thread
From: Rob Herring @ 2019-08-12 23:33 UTC (permalink / raw)
  To: Paul Walmsley
  Cc: mark.rutland, devicetree, aou, andrew, netdev, palmer,
	linux-kernel, nicolas.ferre, sachin.ghadi, Yash Shah,
	sagar.kadam, ynezz, linux-riscv, davem

On Mon, Jul 22, 2019 at 02:48:40PM -0700, Paul Walmsley wrote:
> On Fri, 19 Jul 2019, Yash Shah wrote:
> 
> > DT node for SiFive FU540-C000 GEMGXL Ethernet controller driver added
> > 
> > Signed-off-by: Yash Shah <yash.shah@sifive.com>
> 
> Thanks, queuing this one for v5.3-rc with Andrew's suggested change to 
> change phy1 to phy0.
> 
> Am assuming patches 1 and 2 will go in via -net.

I don't think that has happened.

Rob

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding
  2019-08-12 23:32 ` Rob Herring
@ 2019-08-13 18:41   ` Paul Walmsley
  0 siblings, 0 replies; 19+ messages in thread
From: Paul Walmsley @ 2019-08-13 18:41 UTC (permalink / raw)
  To: davem, nicolas.ferre
  Cc: mark.rutland, Rob Herring, aou, devicetree, netdev, palmer,
	linux-kernel, sachin.ghadi, Yash Shah, robh+dt, linux-riscv,
	ynezz

Nicolas, Dave,

On Mon, 12 Aug 2019, Rob Herring wrote:

> On Fri, 19 Jul 2019 16:40:29 +0530, Yash Shah wrote:
> > As per the discussion with Nicolas Ferre, rename the compatible property
> > to a more appropriate and specific string.
> > LINK: https://lkml.org/lkml/2019/7/17/200
> > 
> > Signed-off-by: Yash Shah <yash.shah@sifive.com>
> > ---
> >  Documentation/devicetree/bindings/net/macb.txt | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Am assuming you'll pick this up for the -net tree for v5.4-rc1 or earlier.  
If not, please let us know.


- Paul

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000
  2019-07-22  4:39     ` Yash Shah
@ 2019-08-13 18:42       ` Paul Walmsley
  2019-08-20  9:10         ` Andreas Schwab
  0 siblings, 1 reply; 19+ messages in thread
From: Paul Walmsley @ 2019-08-13 18:42 UTC (permalink / raw)
  To: Nicolas Ferre, David Miller
  Cc: Mark Rutland, devicetree, Albert Ou, netdev, Palmer Dabbelt,
	linux-kernel@vger.kernel.org List, Sachin Ghadi, Yash Shah,
	Rob Herring, linux-riscv, Petr Štetiar

Dave, Nicolas,

On Mon, 22 Jul 2019, Yash Shah wrote:

> On Fri, Jul 19, 2019 at 5:36 PM <Nicolas.Ferre@microchip.com> wrote:
> >
> > On 19/07/2019 at 13:10, Yash Shah wrote:
> > > Update the compatibility string for SiFive FU540-C000 as per the new
> > > string updated in the binding doc.
> > > Reference: https://lkml.org/lkml/2019/7/17/200
> >
> > Maybe referring to lore.kernel.org is better:
> > https://lore.kernel.org/netdev/CAJ2_jOFEVZQat0Yprg4hem4jRrqkB72FKSeQj4p8P5KA-+rgww@mail.gmail.com/
> 
> Sure. Will keep that in mind for future reference.
> 
> >
> > > Signed-off-by: Yash Shah <yash.shah@sifive.com>
> >
> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> 
> Thanks.

Am assuming you'll pick this up for the -net tree for v5.4-rc1 or earlier.
If not, please let us know.


- Paul

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000
  2019-08-13 18:42       ` Paul Walmsley
@ 2019-08-20  9:10         ` Andreas Schwab
  2019-08-20 10:16           ` Nicolas.Ferre
  0 siblings, 1 reply; 19+ messages in thread
From: Andreas Schwab @ 2019-08-20  9:10 UTC (permalink / raw)
  To: Paul Walmsley
  Cc: Mark Rutland, devicetree, Albert Ou, netdev, Palmer Dabbelt,
	Nicolas Ferre, linux-kernel@vger.kernel.org List, Sachin Ghadi,
	Yash Shah, Rob Herring, Petr Štetiar, linux-riscv,
	David Miller

On Aug 13 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote:

> Dave, Nicolas,
>
> On Mon, 22 Jul 2019, Yash Shah wrote:
>
>> On Fri, Jul 19, 2019 at 5:36 PM <Nicolas.Ferre@microchip.com> wrote:
>> >
>> > On 19/07/2019 at 13:10, Yash Shah wrote:
>> > > Update the compatibility string for SiFive FU540-C000 as per the new
>> > > string updated in the binding doc.
>> > > Reference: https://lkml.org/lkml/2019/7/17/200
>> >
>> > Maybe referring to lore.kernel.org is better:
>> > https://lore.kernel.org/netdev/CAJ2_jOFEVZQat0Yprg4hem4jRrqkB72FKSeQj4p8P5KA-+rgww@mail.gmail.com/
>> 
>> Sure. Will keep that in mind for future reference.
>> 
>> >
>> > > Signed-off-by: Yash Shah <yash.shah@sifive.com>
>> >
>> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>> 
>> Thanks.
>
> Am assuming you'll pick this up for the -net tree for v5.4-rc1 or earlier.
> If not, please let us know.

This is still missing in v5.4-rc5, which means that networking is broken.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000
  2019-08-20  9:10         ` Andreas Schwab
@ 2019-08-20 10:16           ` Nicolas.Ferre
  0 siblings, 0 replies; 19+ messages in thread
From: Nicolas.Ferre @ 2019-08-20 10:16 UTC (permalink / raw)
  To: schwab, paul.walmsley, davem, jakub.kicinski
  Cc: mark.rutland, devicetree, aou, netdev, palmer, linux-kernel,
	sachin.ghadi, yash.shah, robh+dt, linux-riscv, ynezz

On 20/08/2019 at 11:10, Andreas Schwab wrote:
> External E-Mail
> 
> 
> On Aug 13 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote:
> 
>> Dave, Nicolas,
>>
>> On Mon, 22 Jul 2019, Yash Shah wrote:
>>
>>> On Fri, Jul 19, 2019 at 5:36 PM <Nicolas.Ferre@microchip.com> wrote:
>>>>
>>>> On 19/07/2019 at 13:10, Yash Shah wrote:
>>>>> Update the compatibility string for SiFive FU540-C000 as per the new
>>>>> string updated in the binding doc.
>>>>> Reference: https://lkml.org/lkml/2019/7/17/200
>>>>
>>>> Maybe referring to lore.kernel.org is better:
>>>> https://lore.kernel.org/netdev/CAJ2_jOFEVZQat0Yprg4hem4jRrqkB72FKSeQj4p8P5KA-+rgww@mail.gmail.com/
>>>
>>> Sure. Will keep that in mind for future reference.
>>>
>>>>
>>>>> Signed-off-by: Yash Shah <yash.shah@sifive.com>
>>>>
>>>> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>>>
>>> Thanks.
>>
>> Am assuming you'll pick this up for the -net tree for v5.4-rc1 or earlier.
>> If not, please let us know.
> 
> This is still missing in v5.4-rc5, which means that networking is broken.

Andreas, Paul,

The patchwork state for the 2 first patches of this series is "Changes 
Requested". It's probably due to my advice of using lore.kernel.org (or 
something else).

I'm perfectly fine in accepting the patches are they are today but can't 
change their patchwork state myself. We would need Dave or Jakub to take 
them.

Dave, Jakub,

All tags are collected in patchwork and all should be fine on DT (Rob) 
side as well.
Please tell me if you're waiting some sign from me.

Best regards,
-- 
Nicolas Ferre

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, back to index

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-19 11:10 [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding Yash Shah
2019-07-19 11:10 ` [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000 Yash Shah
2019-07-19 12:05   ` Nicolas.Ferre
2019-07-22  4:39     ` Yash Shah
2019-08-13 18:42       ` Paul Walmsley
2019-08-20  9:10         ` Andreas Schwab
2019-08-20 10:16           ` Nicolas.Ferre
2019-07-22 20:02   ` Paul Walmsley
2019-07-22 21:46   ` Paul Walmsley
2019-07-19 11:10 ` [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver Yash Shah
2019-07-19 11:53   ` Sagar Kadam
2019-07-19 13:26     ` Andrew Lunn
2019-07-22  8:27       ` Sagar Kadam
2019-07-22 21:48   ` Paul Walmsley
2019-08-12 23:33     ` Rob Herring
2019-07-19 12:02 ` [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding Nicolas.Ferre
2019-07-22 19:59 ` Paul Walmsley
2019-08-12 23:32 ` Rob Herring
2019-08-13 18:41   ` Paul Walmsley

Linux-RISC-V Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-riscv/0 linux-riscv/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-riscv linux-riscv/ https://lore.kernel.org/linux-riscv \
		linux-riscv@lists.infradead.org infradead-linux-riscv@archiver.kernel.org
	public-inbox-index linux-riscv


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-riscv


AGPL code for this site: git clone https://public-inbox.org/ public-inbox