Linux-RISC-V Archive on lore.kernel.org
 help / color / Atom feed
From: Paul Walmsley <paul.walmsley@sifive.com>
To: Logan Gunthorpe <logang@deltatee.com>, Greentime Hu <green.hu@gmail.com>
Cc: Rob Herring <robh@kernel.org>, Albert Ou <aou@eecs.berkeley.edu>,
	Andrew Waterman <andrew@sifive.com>,
	Palmer Dabbelt <palmer@sifive.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Stephen Bates <sbates@raithlin.com>,
	linux-mm@vger.kernel.org, Olof Johansson <olof@lixom.net>,
	greentime.hu@sifive.com, linux-riscv@lists.infradead.org,
	Michael Clark <michaeljclark@mac.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v4 2/2] RISC-V: Implement sparsemem
Date: Wed, 14 Aug 2019 10:40:35 -0700 (PDT)
Message-ID: <alpine.DEB.2.21.9999.1908141035020.18249@viisi.sifive.com> (raw)
In-Reply-To: <0d81412d-73fc-fa56-6f84-dedda72b9cc6@deltatee.com>

On Wed, 14 Aug 2019, Logan Gunthorpe wrote:

> On 2019-08-14 7:35 a.m., Greentime Hu wrote:
>
> > Maybe this commit explains why it used HAVE_ARCH_PFN_VALID instead of SPARSEMEM.
> > https://github.com/torvalds/linux/commit/7b7bf499f79de3f6c85a340c8453a78789523f85
> > 
> > BTW, I found another issue here.
> > #define FIXADDR_TOP            (VMALLOC_START)
> > #define FIXADDR_START           (FIXADDR_TOP - FIXADDR_SIZE)
> > #define VMEMMAP_END    (VMALLOC_START - 1)
> > #define VMEMMAP_START  (VMALLOC_START - VMEMMAP_SIZE)
> > These 2 regions are overlapped.
> > 
> > How about this fix? Not sure if it is good for everyone.
> 
> Yes, this looks good to me. I can fold these changes into my patch and
> send a v5 to the list.

The change to FIXADDR_TOP should be separated out into its own patch - it 
probably needs to go up as a fix.


- Paul

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply index

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09 20:39 [PATCH v4 0/2] [PATCH v2 0/6] sparsemem support for RISC-V Logan Gunthorpe
2019-01-09 20:39 ` [PATCH v4 1/2] sh: mm: make use of new memblocks_present() helper Logan Gunthorpe
2019-01-15 13:58   ` Christoph Hellwig
2019-01-15 17:30     ` Logan Gunthorpe
2019-01-09 20:39 ` [PATCH v4 2/2] RISC-V: Implement sparsemem Logan Gunthorpe
2019-01-15 13:58   ` Christoph Hellwig
2019-07-31  6:30   ` Greentime Hu
2019-07-31 17:07     ` Logan Gunthorpe
2019-08-01  3:34       ` Greentime Hu
     [not found]         ` <CAEbi=3eZcgWevpX9VO9ohgxVDFVprk_t52Xbs3-TdtZ+js3NVA@mail.gmail.com>
2019-08-09 15:46           ` Logan Gunthorpe
2019-08-09 17:01             ` Greentime Hu
2019-08-09 19:03               ` Logan Gunthorpe
2019-08-12  4:01                 ` Greentime Hu
2019-08-12 15:51                   ` Logan Gunthorpe
2019-08-13  6:04                     ` Greentime Hu
2019-08-13 16:14                       ` Logan Gunthorpe
2019-08-13 16:39                         ` Paul Walmsley
2019-08-13 16:48                           ` Paul Walmsley
2019-08-13 16:49                           ` Logan Gunthorpe
2019-08-14 13:35                             ` Greentime Hu
2019-08-14 16:56                               ` Logan Gunthorpe
2019-08-14 17:40                                 ` Paul Walmsley [this message]
2019-08-14 17:46                                   ` Logan Gunthorpe
2019-08-14 20:09                                     ` Paul Walmsley
2019-08-14 22:21                               ` Logan Gunthorpe
2019-08-15  9:31                                 ` Greentime Hu
2019-08-15 16:20                                   ` Logan Gunthorpe
2019-08-16  2:07                                     ` Greentime Hu

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.9999.1908141035020.18249@viisi.sifive.com \
    --to=paul.walmsley@sifive.com \
    --cc=andrew@sifive.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=green.hu@gmail.com \
    --cc=greentime.hu@sifive.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=logang@deltatee.com \
    --cc=michaeljclark@mac.com \
    --cc=olof@lixom.net \
    --cc=palmer@sifive.com \
    --cc=robh@kernel.org \
    --cc=sbates@raithlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RISC-V Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-riscv/0 linux-riscv/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-riscv linux-riscv/ https://lore.kernel.org/linux-riscv \
		linux-riscv@lists.infradead.org infradead-linux-riscv@archiver.kernel.org
	public-inbox-index linux-riscv

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-riscv


AGPL code for this site: git clone https://public-inbox.org/ public-inbox